Page MenuHomePhabricator
Create Task
Maniphest T617

Provide static dump of Gerrit
Closed, DeclinedPublic
Actions

Description

T18: Plan to migrate code review from Gerrit to Phabricator contains a discussion about how to preserve the Gerrit code review data. Converting all Gerrit changesets in Differential diffs preserving all comments looks like an herculean effort with an unclear added value compared with this other manageable option:

In T18#9753, @demon wrote:

We could actually push all of the refs/* to the new repo locations on Phabricator which would contain a good amount of data about who reviewed what and when, even if it doesn't contain all the comments. That + a static dump of Gerrit as it is would make a decent compromise.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedQgilT553 Engineering Community team goals for October 2014
 ResolvedQgilT174 Launch Wikimedia Phabricator Day 1
 ResolvedQgilT175 Nominate a team in charge of deploying and maintaining Wikimedia Phabricator code
 Resolved• RobLa-WMFT17 Allocate resources for the migration and maintenance
 ResolvedQgilT19 Define which features existing in our current tools are really missing in Phabricator
 Resolved• demonT114311 [keyresult] Code review RFC (Differential) - Write, publish, publicize, and respond to/incorporate feedback.
 DeclinedNoneT207 Update Code Review related documentation on wiki pages from Gerrit to Differential
 DeclinedNoneT130094 Align Differential with Wikimedia workflow (instead of aligning Wikimedia workflow with Differential)
 DeclinedNoneT617 Provide static dump of Gerrit
 DuplicateNoneT18 Plan to migrate code review from Gerrit to Phabricator
 ResolvedQgilT23 Identify features Gerrit users would miss in Phabricator
 Resolved• mmodellT31 [keyresult] Connect Differential code review with continuous integration
 Resolved• mmodellT103127 [keyresult] Prototype CI integration with Differential
 Resolved• mmodellT128 [keyresult] Allow cloning of Phabricator hosted git repositories
 Resolved• chasempT100519 Phabricator needs to expose ssh
 Resolved• mmodellT127741 Develop a CI Testing and Release pipeline for the SCAP package (and potentially other debian packages that we maintain)
 Resolved• mmodellT130950 Build glue from Differential to Nodepool
 Resolved• mmodellT130949 Spec out needed glue for Differential to Gearman to Nodepool
 Resolved• chasempT131375 Make sure phab can talk to gearman and nodepool instances can talk to phabricator
 Resolved• mmodellT137770 Package xhpast (libphutil)
 ResolvedQgilT68 Watch a user (via Phabricator's Herald)
 InvalidQgilT157 Phabricator should sustain crawling by internet search engines
 ResolvedQgilT161 Set Applications -> Differential -> Default View Policy to "Public (No Login Required)"
 DeclinedNoneT162 Commit hashes of landed patches need not match the latest ones shown in Differential
 InvalidQChrisT163 `arc diff` changes current ref in local checkout
 ResolvedNoneT135 Updating a commit in a Differential does not reset “Accepted” review flag
 DeclinedNoneT136 Pulling patches from Phabricator does not give consistent commit hashes
 DeclinedNoneT125 Allow viewing diffs of single commits within a Differential
 DeclinedNoneT134 Arc does not allow to land a commit from a local master branch that is ahead of the remote's master onto the remote's master
 ResolvedyuvipandaT131 IRC bot to report Phabricator activity exactly like Wikibugs does with Bugzilla
 Invalid• chasempT249 Write event notification handler to dump to Redis Pubsub
 ResolvedvalhallaswT324 Have wikiphabot follow the same channel announce rules as wikibugs
 DeclinedvalhallaswT571 Make wikibugs parse phab emails & send messages
 ResolvedvalhallaswT573 Get phawikibugs to run on tools.wmflabs
 ResolvedLegoktmT647 wikibugs should Ignore CC changes
 ResolvedLegoktmT75710 Cannot find transaction info for some events
 ResolvedLegoktmT778 irc: Ignore changes by @gerritbot
 InvalidLegoktmT648 Set up PhabricatorBotObjectNameHandler for specific channels
 DeclinedNoneT120 Changing the Git remote of a repository locks it
 DuplicateNoneT91420 git commit hash remains the same from submitting to after merge
 DeclinedNoneT91746 Tool to maintain offline copy of open changesets like gertty
 DeclinedNoneT409 Editing files and contributing changes via web
 ResolvedgregT560 Proof of concept of code review in Phabricator
 ResolvedgregT584 Define main tasks (epics) for code review in Phabricator
 Resolved• demonT753 Demonstrate the conversion of mirrored repositories into local repositories
ResolvedgregT94167 Opt-in Differential for projects needing code review but not Jenkins/Zuul for continuous integration
DeclinedNoneT95526 Migrate Pywikibot to Differential code review
 ResolvedgregT597 Identify Arcanist showstoppers for wikimedians
 InvalidgregT612 Landing a patch with arc currently will sometimes strip author information
 DeclinedNoneT137 Running `arc diff` twice on the same commit creates another redundant diff within the same differential
 DeclinedNoneT127 Find way to use Differential with plain git (i.e.: without requiring arc)
 Declined• mmodellT132863 Set up arcyd to create differential revisions with `git push` (code review without arcanist)
 ResolvedgregT91422 Phabricator and Arcanist versions must be kept in sync because of occasional breaking api changes between phabricator versions.
 Resolved• demonT118049 Ensure default branches for arcanist and libphutil from gerrit and diffusion clones are compatible with phabricator.wikimedia.org
 Invalid• mmodellT99905 You should be able to merge your own patches
 DuplicateNoneT112967 Document git-review -> arc mapping.
 Resolved• mmodellT117058 Initial documentation of example Differential workflows (with Gerrit equivalents)
 DeclinedNoneT167 Align basics of current Gerrit code-review process with Differential
 Invalid• mmodellT181 Figure out how to configure default arc diff behavior
 InvalidgregT182 Support automatic commit generation in Phabricator
 DeclinedNoneT138 Define an equivalent to Gerrit's +-1 +-2 for code review evaluation
 DeclinedgregT164 Uploading a new Differential Revision does not reset “Accept” states in commit messages
 ResolvedQgilT185 Make it possible to bypass missing test plan
 Resolved• mmodellT183 Per-branch access control in code repositories
 ResolvedgregT121751 Document best practices to amend a change written by another contributor
 ResolvedgregT1009 Define a process to import and create repositories
 DeclinedgregT76446 Revise phabricator.wikimedia.org service level
 DeclinedNoneT92493 Train L10n-bot to work with repositories hosted in Wikimedia Phabricator (Diffusion)

Event Timeline

Qgil created this task.Oct 10 2014, 11:27 AM
Qgil raised the priority of this task from to Medium.
Qgil updated the task description. (Show Details)
Qgil added a project: Gerrit-Migration.
Qgil changed Security from none to None.
Qgil added a subtask: T18: Plan to migrate code review from Gerrit to Phabricator.
Qgil subscribed.
Qgil mentioned this in T584: Define main tasks (epics) for code review in Phabricator.Oct 10 2014, 11:29 AM
Qgil lowered the priority of this task from Medium to Low.Nov 27 2014, 7:57 AM

Currently #Code-Review is in the queue of Phabricator subprojects after Project-Management and Gitblit-Deprecate. If someone wants to work on this task, take it and assign the priority accordingly.

• MZMcBride subscribed.Dec 5 2014, 7:18 PM
Negative24 subscribed.Apr 1 2015, 4:11 AM
Ricordisamoa subscribed.Apr 9 2015, 7:33 PM
• mmodell subscribed.May 1 2015, 5:25 AM

I propose closing this as declined.

Legoktm subscribed.May 1 2015, 5:34 AM
In T617#1251411, @mmodell wrote:

I propose closing this as declined.

What is the alternative for preserving the CR history then?

• mmodell added a comment.May 1 2015, 5:40 AM

A static snapshot of gerrit? If we don't want to commit to maintaining gerrit it's self, we could just capture a static html dump.

• mmodell added a comment.May 1 2015, 5:41 AM

I just don't think there are enough people dedicated to this project to facilitate migration of the gerrit data. It's a huge project that would require several months of effort.

Legoktm added a comment.May 1 2015, 5:42 AM

So then why would you decline it...? This bug is titled "Preserve code review history", declining it means you don't want to preserve that history.

• mmodell added a comment.May 1 2015, 5:58 AM

Sorry I took it to mean "preserve history in phabricator" which, on further consideration, I realize that is not explicitly required for this task.

Ricordisamoa added a comment.May 1 2015, 6:04 AM

Of course the Gerrit history must be preserved somehow.
I think it'll end up like Special:Code or Bugzilla...

• mmodell added a comment.May 1 2015, 8:12 AM

Well bugzilla got imported into phabricator. That really isn't practical with gerrit - it was a huge amount of work to import bugzilla and I suspect that gerrit would be even more difficult than that migration.

Ricordisamoa added a comment.May 1 2015, 8:25 AM
In T617#1251479, @mmodell wrote:

Well bugzilla got imported into phabricator. That really isn't practical with gerrit - it was a huge amount of work to import bugzilla and I suspect that gerrit would be even more difficult than that migration.

I mean, Bugzilla is still around for searching, etc.

greg subscribed.Dec 1 2015, 11:18 PM
In T617#1251499, @Ricordisamoa wrote:
In T617#1251479, @mmodell wrote:

Well bugzilla got imported into phabricator. That really isn't practical with gerrit - it was a huge amount of work to import bugzilla and I suspect that gerrit would be even more difficult than that migration.

I mean, Bugzilla is still around for searching, etc.

a labs install not maintained officially, for the record.

A static dump of gerrit should be fine for this.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2015, 11:18 PM
greg renamed this task from Preserve code review history to Provide static dump of Gerrit.Dec 1 2015, 11:19 PM
greg updated the task description. (Show Details)
greg added a subscriber: • demon.
greg raised the priority of this task from Low to Medium.Dec 2 2015, 12:24 AM
greg moved this task from To Triage to Tooling on the Gerrit-Migration board.
greg mentioned this in T114320: Code-review migration to Differential status/discussion.Jan 6 2016, 7:18 PM
JanZerebecki subscribed.Feb 12 2016, 11:41 AM
greg moved this task from Tooling to Software Changes on the Gerrit-Migration board.Mar 15 2016, 11:00 PM
greg added a project: Gerrit.Mar 23 2016, 10:55 PM
• mmodell moved this task from Software Changes to Repository Migrations on the Gerrit-Migration board.Mar 31 2016, 4:50 PM
TerraCodes subscribed.Apr 27 2016, 8:04 AM
• demon moved this task from Bugs & stuff to WMF customizations on the Gerrit board.Jul 25 2016, 5:20 PM
Paladox lowered the priority of this task from Medium to Lowest.Jan 28 2018, 2:54 AM
• demon closed this task as Resolved.Jan 31 2018, 12:12 AM
• demon claimed this task.
In T617#1843228, @greg wrote:
In T617#1251499, @Ricordisamoa wrote:
In T617#1251479, @mmodell wrote:

Well bugzilla got imported into phabricator. That really isn't practical with gerrit - it was a huge amount of work to import bugzilla and I suspect that gerrit would be even more difficult than that migration.

I mean, Bugzilla is still around for searching, etc.

a labs install not maintained officially, for the record.

A static dump of gerrit should be fine for this.

The Differential migration is so low priority it may as well not be happening these days. A static dump is a huge waste of time. Marking this stalled pending some decision on Differential/Diffusion.

• demon reopened this task as Stalled.Jan 31 2018, 12:12 AM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJan 31 2018, 12:12 AM
• demon removed • demon as the assignee of this task.Jan 31 2018, 8:17 PM
• demon removed a project: Release-Engineering-Team (Kanban).
• demon closed this task as Declined.Mar 7 2018, 10:14 PM

Per T119908

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits