Description
Details
- Reference
- fl351
Status | Subtype | Assigned | Task | |
---|---|---|---|---|
· · · | ||||
Declined | None | T207 Update Code Review related documentation on wiki pages from Gerrit to Differential | ||
Resolved | • mmodell | T117058 Initial documentation of example Differential workflows (with Gerrit equivalents) | ||
Declined | None | T123081 Update Commit Message Guidelines for Differential | ||
Declined | None | T130786 Document permissions standards for code-reviewers/committers | ||
Resolved | • mmodell | T128372 Document use of Owners in Phabricator and advertise it | ||
· · · |
Event Timeline
Why do these pages live under "Gerrit"?
- https://www.mediawiki.org/wiki/Gerrit/Code_review
- https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews
It looks like mw:Git was redirected to mw:Gerrit, sadly.
I actually recommend that Code_review and Code_review/Getting_reviews pages become top level, eg: [[mw:Code_review]] (not having Git/ or Gerrit/ in front).
To be fair, the content of mw:Git wasn't the most useful: https://www.mediawiki.org/w/index.php?title=Git&oldid=754984
I actually recommend that Code_review and Code_review/Getting_reviews pages become top level, eg: [[mw:Code_review]] (not having Git/ or Gerrit/ in front).
I still recommend this though :)
We'll have to figure out where pages like https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines go, however. Under Phabricator/Differential ?
Now we have pages like Phabricator/Project_management... I would not dig much into the past. :)
In any case, having Code_review as top level makes total sense. Once this principle is clear, naming/moving pages accordingly is simple and cheap. What matters is to have useful content properly linked (or should I say discoverable).
Tempted to merge this into T129067: Document a structured, standardized approach for reviewing code contributions and T129068: Improve code contribution guidelines for patch authors - anyone disagreeing?
Well, as long as all of the crazy stuff under Gerrit that isn't (or shouldn't be) Gerrit specific is cleaned up and moved somewhere else (like under the proposed [[Code_review]] page) then sure.
But I don't want either of those tasks you link to be blockers for the Differential migration, which this task is (because it's about the confusion of having code review stuff being under [[Gerrit]]).
Makes a lot of sense. I clarified the task summary and will keep this separate for the time being.