Opt-in Differential for projects needing code review but not Jenkins/Zuul for continuous integration
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Qgil
	Mar 27 2015, 1:42 PM

Description

Background

In T560#1095147, @Qgil wrote:

Never surrender... :)

On Fri, Feb 20, 2015 at 5:35 PM, Chad Horohoe wrote in an email:

Step 1 should be doing projects that don't even need Gerrit or Jenkins. Then we can focus on the Arc-Differential bits right without any other moving pieces.

What about a demo-able project for the Wikimedia-Hackathon-2015 consisting Pywikibot code review in Phabricator? Could be a test in phab-01 or the real deal in production, depending on how good is the implementation and how on board the Pywikibot folks are.

If @mmodell (Wikimedia Phabricator maintainer) and @jayvdb (Pywikibot maintainer) are also in, I don't think we require anything else to try this out in Lyon. Other #Code-Review interested parties will be either in Lyon or available online, busy with other things but probably able to answer and help on specific bits during the event. It is very likely that more Pywikibot folks will be at the event. It is going to be a very good environment for ad-hoc technical & social discussions and decisions in the Phabricator and Pywikibot sides.

Also, if we define what "projects that don't even need Gerrit or Jenkins" means, we might get other projects during the weekend from the pool of bots, Tool Labs, etc, that will be at the event.

No matter at which point we leave the work at the end of the hackathon, we could continue polishing after the event, opening the door to all these non-Jenkins projects, and starting to build a critical mass of projects using Differential for code review.

This task is marked as stretch goal at T93770: Engineering Community quarterly goals for April-June 2015

Getting Started with Differential

In order to access the Wikimedia instance of Differential, all that is required is that you join the Differential-Beta project.

Before you can actually make use of Differential in a meaningful way, there are a few more things that must be in place:

You need to set up Arcanist locally in order to submit changes to Differential.
- A good first step would be to read the Arcanist Quick Start Guide.
Your repository needs to be mirrored in phabricator before it'll work with Differential.
- To verify, be sure that you can find the repository listed in Diffusion.
- If it's missing, ask @mmodell (IRC: twentyafterfour) or @demon (IRC: ^d) to set it up for you.

Related Objects
Search...

Status	Assigned	Task
Resolved	Dzahn	T123525 reduce amount of remaining Ubuntu 12.04 (precise) systems in production
Resolved	• Cmjohnson	T138978 decom antimony (datacenter)
Resolved	Dzahn	T123718 Phase out antimony.wikimedia.org (git.wikimedia.org / gitblit)
Resolved	Danny_B	T138986 Archive #Gitblit-Deprecate
Resolved	Paladox	T137353 Update all on-wiki references to git.wikimedia.org and replace them with the Phabricator equivalent
Open	Dzahn	T323073 Make https://git.wikimedia.org not redirect to Phabricator Diffusion
Resolved	• demon	T111465 [keyresult] Deprecate gitblit in favor of Diffusion
Resolved	• demon	T752 Use Diffusion as canonical location for browsing code repos (not gitblit)
Resolved	Paladox	T108864 Update mediawiki.org templates to link to Diffusion, not gitblit
Resolved	Nemo_bis	T101358 Update {{git file}} to link to diffusion
Resolved	• demon	T110607 redirect gerrit repo paths to diffusion callsigns
Resolved	Paladox	T111887 Diffusion replacement for tarfile download from git.wikimedia.org
Resolved	Krenair	T122674 Make all /r/project/* paths in phabricator accessible without login
Resolved	• mmodell	T129447 Diffusion redirect from name to callsign doesn't always work
Invalid	None	T135336 Update Module:Callsigns in mediawiki.org
Declined	None	T76788 ExtensionDistributor should use Phabricator/Diffusion instead of Gerrit
Resolved	• demon	T616 Import all gerrit.wikimedia.org repositories with Diffusion
Invalid	None	T98348 Implement the Wikimedia Foundation Call to Action 2015
Invalid	None	T98358 WMF to integrate, consolidate, and pause or stop stalled initiatives
Resolved	Qgil	T553 Engineering Community team goals for October 2014
Declined	None	T617 Provide static dump of Gerrit
Duplicate	None	T18 Plan to migrate code review from Gerrit to Phabricator
Resolved	greg	T560 Proof of concept of code review in Phabricator
Resolved	greg	T94167 Opt-in Differential for projects needing code review but not Jenkins/Zuul for continuous integration

Event Timeline

Qgil created this task.Mar 27 2015, 1:42 PM

Qgil raised the priority of this task from to Low.

Qgil updated the task description. (Show Details)

Qgil added projects: Wikimania-Hackathon-2015, Gerrit-Migration.

Qgil added subscribers: Ricordisamoa, JanZerebecki, jayvdb and 7 others.

Qgil mentioned this in T560: Proof of concept of code review in Phabricator.Mar 27 2015, 1:49 PM

Qgil updated the task description. (Show Details)

Qgil set Security to None.

Qgil mentioned this in T93770: Engineering Community quarterly goals for April-June 2015.Mar 27 2015, 1:54 PM

The title only mentions Jenkins/Zuul. Is there any offer of CI included in this step of our Differential installation?

If there is a git repo with code someone wants to run but no CI then that is a bug. (I know they exists, but why would you want to prevent basic syntax checking?)

IMHO we should not introduce Differential by any means without considering the losses. And not move code into a place where quality improvements are prevented. And only add a new tool for the same task if we retire one other. Please clarify if/how you disagree.

The title only mentions Jenkins/Zuul. Is there any offer of CI included in this step of our Differential installation?

We're waiting for Harbormaster in Phabricator. Also see some of the discussion comments in T89714.

Qgil mentioned this in T18: Plan to migrate code review from Gerrit to Phabricator.Apr 8 2015, 10:51 AM

Qgil mentioned this in T95526: Migrate Pywikibot to Differential code review.Apr 9 2015, 9:37 AM

Pywikibot really needs its integration with integrated CI for work by new contributors, however we have extensive tests run by travis and many of the core devs push changes to github/travis in addition to submitting to gerrit, and we push complex gerrit changes to github/travis before +2 in gerrit to help show hard to see unexpected problems.

So some core devs could use Differential without CI and utilise travis for CI, provided gerrit remains an option for some contributors. Not sure if gerrit and differential can play nice together on the same master. If not we could look at other approaches, like using differential only for a new pwb3 branch while gerrit is used for the current pwb2 master which is close to being released.

differential doesn't use git directly so it can easily co-exist with other systems. And since phabricator can track git repos hosted elsewhere then you just point phab at the repo, set up arcanist locally and start submitting diffs.

there is also http://www.dctrwatson.com/2013/01/jenkins-and-phabricator/ -> it's pretty easy to hook arcanist up to jenkins bypassing zuul. It might be a valid way to set things up for a alpha-stage differential experiment.

Ya. Looks easy and good enough for our needs.

we could also look at pushing review changesets to github branches, which would trigger our travis testsuite.
https://secure.phabricator.com/T4482

To use differential please join the Differential-Beta project.

I did and there is no Application named Differential showing up for me.

@JanZerebecki: https://phabricator.wikimedia.org/differential/

You do not have permission to view this object.
Members of the project "Gerrit-Migration" can take this action.

@JanZerebecki: Sorry I had it set up incorrectly. Would you mind giving it another try?

• mmodell mentioned this in T95749: Use GitHub as main repo for Wikipedia iOS.Apr 30 2015, 11:21 AM

• mmodell updated the task description. (Show Details)Apr 30 2015, 11:34 AM

• mmodell added a subscriber: • demon.

After joining the project, I can access https://phabricator.wikimedia.org/differential/. Cool!

Works: Now it shows up under Applications and I can access it.

• mmodell moved this task from To Triage to Tooling on the Gerrit-Migration board.May 1 2015, 4:32 AM

D1 created!

Please confirm and promote this activity by assigning it to its owner, listing it or scheduling it at the Hackathon wiki page and by placing it in the right column at #Wikimania-Hackathon-2015. Thank you!

@mmodell are you or anyone you know planning to work on this task at Wikimania? (I'm not going this year)

Aklapper removed a project: Wikimania-Hackathon-2015.Jul 17 2015, 1:22 PM

This is done. Differential is available in an opt-in basis. RelEng is using it for Scap work (see: https://phabricator.wikimedia.org/differential/query/Bl4g_4o5nAT8/ )

(If there's a desire to have a place where people can ask to do this for themselves, that should be on-wiki under Phabricator/ somewhere, not this task.)

Restricted Application added a project: User-greg. · View Herald TranscriptOct 22 2015, 9:41 PM

Legoktm mentioned this in T116330: Broadcast Differential activity to IRC.Oct 22 2015, 9:51 PM

• demon moved this task from Tooling to Done/Archive on the Gerrit-Migration board.Dec 1 2015, 6:45 PM

Opt-in Differential for projects needing code review but not Jenkins/Zuul for continuous integration Closed, ResolvedPublicActions