Page MenuHomePhabricator

Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo
Closed, DuplicatePublic8 Story Points

Description

Intention:
Adding a link to a file (on Commons)

Steps to Reproduce:

  1. Enter edit mode
  2. Click add link
  3. Enter a link to a file on Commons (e.g. :File:Foo.svg)
  4. Accept link [you possibly have to fiddle with the colons due to bug 63353]
  5. Save page or switch to source mode and preview

Actual Results:

  1. Link shows red
  2. Link shows blue (if file exists on Commons)

Expected Results:
Link should be blue in VE if file exists on Commons (just in for preview in old editor)

Reproducible: Didn't try


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63353

Details

Reference
bz63355

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:03 AM
bzimport set Reference to bz63355.

Created attachment 14993
Screenshot VE compared to old preview

Attached:

Jdforrester-WMF renamed this task from VisualEditor: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo to Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo.Jul 3 2015, 3:51 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF set Security to None.
Jdforrester-WMF removed Esanders as the assignee of this task.Sep 16 2015, 11:37 PM
Jdforrester-WMF edited a custom field.

I found an unusual example of this in an infobox today:

This is easily reproduced at https://en.wikipedia.org/w/index.php?title=Tetulomab&oldid=698223500&veaction=edit

The red "Type" item is actually a link to https://commons.wikimedia.org/wiki/File:Engineered_monoclonal_antibodies.svg

This task is a dupe of that indeed. Foreign files such as Commons is just one of many things that Title::isAlwaysKnown takes care of, in addition to Special pages, MediaWiki messages, and extension hooks such as for GlobalUserPages.

That's a similar issue indeed, but in Page curation. That will needs its own fix separate from VE.