Page MenuHomePhabricator
Create Task
Maniphest T65355

Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo
Closed, DuplicatePublic8 Estimated Story Points
Actions

Description

Intention:
Adding a link to a file (on Commons)

Steps to Reproduce:

  1. Enter edit mode
  2. Click add link
  3. Enter a link to a file on Commons (e.g. :File:Foo.svg)
  4. Accept link [you possibly have to fiddle with the colons due to bug 63353]
  5. Save page or switch to source mode and preview

Actual Results:

  1. Link shows red
  2. Link shows blue (if file exists on Commons)

Expected Results:
Link should be blue in VE if file exists on Commons (just in for preview in old editor)

Reproducible: Didn't try

Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63353

Details

Reference
bz63355

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:03 AM
• bzimport added projects: Browser-Support-Firefox, VisualEditor-MediaWiki.
• bzimport set Reference to bz63355.
Lokal_Profil created this task.Apr 1 2014, 9:44 AM
Lokal_Profil added a comment.Apr 1 2014, 9:51 AM

Created attachment 14993
Screenshot VE compared to old preview

Attached:

Screenshot_from_2014-04-01_11:41:08.png (305×997 px, 58 KB)

Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:08 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 4:15 PM
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Links.Jan 27 2015, 11:52 PM
Jdforrester-WMF renamed this task from VisualEditor: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo to Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo.Jul 3 2015, 3:51 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF merged a task: T104604: Check if links on load are 'known' rather than 'exist' locally.
Jdforrester-WMF removed a project: Browser-Support-Firefox.
Jdforrester-WMF set Security to None.
Jdforrester-WMF added subscribers: Krenair, gerritbot, Steinsplitter and 2 others.
Jdforrester-WMF added a subtask: T104604: Check if links on load are 'known' rather than 'exist' locally.Jul 3 2015, 3:53 PM
Jdforrester-WMF mentioned this in T97830: betalabs: Existing pages for File internal links are displayed red in VE .Jul 3 2015, 4:30 PM
Jdforrester-WMF closed subtask T104604: Check if links on load are 'known' rather than 'exist' locally as Resolved.Jul 8 2015, 7:34 PM
Krenair added a comment.Jul 15 2015, 9:07 PM

See T72123

Jdforrester-WMF removed a parent task: T50789: VisualEditor: Improvements and behaviour changes to the link input widget (tracking).Sep 10 2015, 6:56 PM
Jdforrester-WMF removed Esanders as the assignee of this task.Sep 16 2015, 11:37 PM
Jdforrester-WMF edited a custom field.
• Whatamidoing-WMF added a comment.Jan 4 2016, 8:06 PM

I found an unusual example of this in an infobox today:

Screen Shot 2016-01-04 at 12.04.31 PM.png (227×311 px, 23 KB)

This is easily reproduced at https://en.wikipedia.org/w/index.php?title=Tetulomab&oldid=698223500&veaction=edit

The red "Type" item is actually a link to https://commons.wikimedia.org/wiki/File:Engineered_monoclonal_antibodies.svg

• Quiddity merged tasks: T97830: betalabs: Existing pages for File internal links are displayed red in VE , T112862: A link to a Commons file is red colored on edit mode on Flow .Aug 2 2016, 11:42 PM
• Quiddity added subscribers: Etonkovidova, Trizek-WMF, Catrope.
• Quiddity subscribed.Aug 2 2016, 11:51 PM

These are probably also duplicates? (or merge-target)

See also, notes from Legoktm and Jdforrester-WMF in:

Krinkle closed this task as a duplicate of T72123: VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly).Aug 3 2016, 5:25 AM
Krinkle added a comment.Aug 3 2016, 5:28 AM
In T65355#2517538, @Quiddity wrote:

These are probably also duplicates? (or merge-target)

This task is a dupe of that indeed. Foreign files such as Commons is just one of many things that Title::isAlwaysKnown takes care of, in addition to Special pages, MediaWiki messages, and extension hooks such as for GlobalUserPages.

That's a similar issue indeed, but in Page curation. That will needs its own fix separate from VE.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits