Page MenuHomePhabricator

VisualEditorOverlay should be written as an OO.ui.ProcessDialog
Closed, DeclinedPublic8 Estimated Story Points


Hopefully subject is as clear as possible :-)

Related Objects

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task to Triaged but Future on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.

Change 203478 had a related patch set uploaded (by Jdlrobson):
WIP: Rewrite VisualEditorOverlay as a ProcessDialog

@bmansurov, @Esanders @matmarex, I spent a few hours on this today. There's a long way to go, but I learnt a lot about some subtle differences between MobileFrontend's architecture and VEs. They don't seem so incompatible. We're actually doing very similar things so this shouldn't be too hard.

After hacking away at this I still see this bug as the holy grail for MobileFrontend fully using oojs ui.
Rewrite VisualEditorOverlay as a Dialog, this will bring MobileFrontend's 3 core components inline with those in OO.ui:

  • OO.ui.ProcessDialog = mw.mobileFrontend.require( 'Overlay' )
  • OO.ui.WindowManager = mw.mobileFrontend.require( 'OverlayManager' )
  • OO.ui.Element + template support = mw.mobileFrontend.require( 'View' )

Once we have this I think it will be pretty straightforward to more quickly iterate on moving mobile to OooJS UI.

Jdlrobson renamed this task from VisualEditorOverlay should be written as an OO.ui.Dialog to VisualEditorOverlay should be written as an OO.ui.ProcessDialog.Apr 15 2015, 9:00 PM
Jdlrobson moved this task from Triaged but Future to 2016-17 Q1 on the Readers-Web-Backlog board.

Change 203478 abandoned by Jdlrobson:
WIP: Rewrite VisualEditorOverlay as a ProcessDialog

Not working on this. Someone should feel free to pick up.

Not sure this will necessarily be the best approach...

Deskana lowered the priority of this task from High to Low.Aug 31 2018, 10:32 AM
Deskana moved this task from Epics to Freezer on the VisualEditor board.

I think this would not be helpful at this point, especially given Jon's current plans for MobileFrontend's overlays (T212465, T214641#4907694).