VisualEditorOverlay should be written as an OO.ui.ProcessDialog
Closed, DeclinedPublic8 Estimated Story Points
Actions

Assigned To

None

Authored By

	Jdlrobson
	Feb 4 2015, 3:05 PM

Description

Hopefully subject is as clear as possible :-)

Details

	Subject	Repo	Branch	Lines +/-
	WIP: Rewrite VisualEditorOverlay as a ProcessDialog	mediawiki/extensions/MobileFrontend	master	+186 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Declined	None	T144571 Mobile Media Viewer violates user settings
Open	Jdlrobson	T65504 Consolidate code for MediaViewer across desktop and mobile
Declined	None	T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
Duplicate	Jdlrobson	T66316 [EPIC] Move Nearby code to more suitable extension
Open	None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
Open	None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
Declined	None	T96202 [EPIC] Rewrite MobileFrontend frontend code in OOUI
Duplicate	None	T101462 [EPIC] Merge OOJS UI library and Mobile unnamed library.
Open	None	T96186 [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor
Duplicate	None	T95952 [Epic] Merge OOJS UI and MobileFrontend View code
Declined	None	T88559 VisualEditorOverlay should be written as an OO.ui.ProcessDialog
Resolved	Esanders	T96187 Rewrite VisualEditorOverlay header using OOjs UI
Resolved	Esanders	T96188 Rewrite the edit summary screen of VisualEditorOverlay in OOjs UI

Event Timeline

Jdlrobson created this task.Feb 4 2015, 3:05 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2015, 3:05 PM

Jdlrobson mentioned this in T95490: Remove ButtonWithSpinner from MobileFrontend.Apr 8 2015, 9:58 PM

Jdlrobson added subscribers: • Moushira, • rmoen, kaldari, • JKatzWMF.Apr 9 2015, 1:50 AM

This comment was removed by Jdlrobson.

Change 203478 had a related patch set uploaded (by Jdlrobson):
WIP: Rewrite VisualEditorOverlay as a ProcessDialog

https://gerrit.wikimedia.org/r/203478

gerritbot added a project: Patch-For-Review.Apr 10 2015, 10:08 PM

@bmansurov, @Esanders @matmarex, I spent a few hours on this today. There's a long way to go, but I learnt a lot about some subtle differences between MobileFrontend's architecture and VEs. They don't seem so incompatible. We're actually doing very similar things so this shouldn't be too hard.

After hacking away at this I still see this bug as the holy grail for MobileFrontend fully using oojs ui.
Rewrite VisualEditorOverlay as a Dialog, this will bring MobileFrontend's 3 core components inline with those in OO.ui:

OO.ui.ProcessDialog = mw.mobileFrontend.require( 'Overlay' )
OO.ui.WindowManager = mw.mobileFrontend.require( 'OverlayManager' )
OO.ui.Element + template support = mw.mobileFrontend.require( 'View' )

Once we have this I think it will be pretty straightforward to more quickly iterate on moving mobile to OooJS UI.

Jdforrester-WMF triaged this task as High priority.Apr 12 2015, 12:47 PM

Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki-Mobile, VisualEditor 2014/15 Q4 blockers.

Jdforrester-WMF set Security to None.

Krenair subscribed.Apr 12 2015, 12:48 PM

Jdlrobson renamed this task from VisualEditorOverlay should be written as an OO.ui.Dialog to VisualEditorOverlay should be written as an OO.ui.ProcessDialog.Apr 15 2015, 9:00 PM

Jdlrobson moved this task from Triaged but Future to 2016-17 Q1 on the Web-Team-Backlog board.

Jdlrobson added a subtask: T96186: [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor.

Jdlrobson updated the task description. (Show Details)Apr 15 2015, 9:05 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson removed a subtask: T96186: [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor.

Jdlrobson added a parent task: T96186: [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor.Apr 15 2015, 9:07 PM

Jdlrobson added a parent task: T95952: [Epic] Merge OOJS UI and MobileFrontend View code.Apr 15 2015, 9:10 PM

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Apr 16 2015, 9:15 PM

Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 22 2015, 6:28 PM

Jdforrester-WMF added a project: Technical-Debt.Apr 29 2015, 7:32 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.May 6 2015, 10:16 PM

Jdlrobson removed a project: Patch-For-Review.May 12 2015, 11:20 AM

• bmansurov unsubscribed.May 12 2015, 4:02 PM

Change 203478 abandoned by Jdlrobson:
WIP: Rewrite VisualEditorOverlay as a ProcessDialog

Reason:
Not working on this. Someone should feel free to pick up.

https://gerrit.wikimedia.org/r/203478

Jdforrester-WMF added a project: VisualEditor 2015/16 Q1 blockers.Jul 1 2015, 3:52 PM

Jdforrester-WMF moved this task from Nominated to Doing on the VisualEditor 2015/16 Q1 blockers board.

Jdforrester-WMF removed a project: VisualEditor 2014/15 Q4 blockers.Jul 1 2015, 3:54 PM

Jdforrester-WMF moved this task from Freezer to Epics on the VisualEditor board.Jul 21 2015, 6:21 PM

Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM

Esanders closed subtask T96188: Rewrite the edit summary screen of VisualEditorOverlay in OOjs UI as Resolved.Aug 7 2015, 4:57 PM

Not sure this will necessarily be the best approach...

• Jhernandez edited projects, added MobileFrontend; removed Web-Team-Backlog.Aug 18 2015, 5:36 PM

Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Nov 4 2015, 5:28 PM

Jdlrobson moved this task from Team:Growth to team:other on the MobileFrontend board.Feb 18 2016, 6:43 PM

• AlexMonk-WMF subscribed.Feb 23 2016, 3:41 AM

• AlexMonk-WMF removed a subscriber: Krenair.Feb 23 2016, 3:44 AM

MBinder_WMF added a project: Web-Team-Backlog.May 17 2016, 6:34 PM

Jdlrobson moved this task from 2016-17 Q1 to Incoming on the Web-Team-Backlog board.May 18 2016, 3:39 PM

• Jhernandez edited projects, added Contributors-Team; removed Web-Team-Backlog.May 25 2016, 4:21 PM

Jdforrester-WMF closed subtask T96187: Rewrite VisualEditorOverlay header using OOjs UI as Resolved.Mar 3 2017, 12:49 AM

Liuxinyu970226 subscribed.Mar 3 2017, 1:59 PM

Jdlrobson moved this task from team:other to Team: web on the MobileFrontend board.Jul 13 2017, 5:41 PM

Jdlrobson moved this task from Team: web to team:other on the MobileFrontend board.

• Deskana lowered the priority of this task from High to Low.Aug 31 2018, 10:32 AM

• Deskana moved this task from Epics to Freezer on the VisualEditor board.

matmarex mentioned this in T202619: Get rid of tiny hogan templates in mobile.editor.ve.Sep 19 2018, 5:28 PM

I think this would not be helpful at this point, especially given Jon's current plans for MobileFrontend's overlays (T212465, T214641#4907694).

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptFeb 6 2019, 4:22 PM

VisualEditorOverlay should be written as an OO.ui.ProcessDialogClosed, DeclinedPublic8 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

VisualEditorOverlay should be written as an OO.ui.ProcessDialog
Closed, DeclinedPublic8 Estimated Story Points
Actions

Related Objects
Search...