Code Review Office Hours
ActivePublic
Actions

Hosted by • mmodell on Aug 10 2017, 7:00 PM - 8:00 PM.

Description

What's this all about

This is an initiative of Wikimedia Developer-Advocacy and Release-Engineering-Team intended to promote quality and timely code reviews on Wikimedia projects. See T128371: Set up Code Review office hours for related discussion and the overview on mediawiki.org Code_Review/Office_Hours

How does it work

If you have a patch that needs attention, please subscribe to this event and post a link to your patch in the comments, then show up on freenode IRC in the #wikimedia-codereview channel during the scheduled office hours. Developers with +2 should be on hand to review patches, provide feedback and merge any acceptable/deployable patches.

Nominated Patches

Suggested by	Task and/or Description of patch	Link to patch
@name	Tnnn	...

Other Patches "for-review"

To find other patches to review, try this maniphest query which will show you tasks with the Patch-For-Review tag.

Recurring Event
Next
Previous

Event Series: This event is an instance of E415: Code Review Office Hours, and repeats every week.

Details

Invitees

Kghbln
MarkAHershberger
Smalyshev
• bmansurov
• JGirault
TheDJ
greg
MGChecker
Danny_B
phuedx
Tgr
Catrope
Bawolff
Jdlrobson
• Nikerabbit
• ksmith
• brooke
Luke081515
Florian
• mmodell

Event Timeline

I'd like a code review on https://gerrit.wikimedia.org/r/#/c/370310/ before scheduling it for SWAT. The patch implements OAuth on foundationwiki (tables have been created already), so requesting to know if the config change is appropriate and if I'm missing something as well. I'm not sure if I will be around, but please leave any feedback or comments on the task and/or the Gerrit patchset. Thank you.

I'd also love to have https://gerrit.wikimedia.org/r/#/c/369869/ reviewed. This is meant to enhace 'hideuser' blocks, by deleting with suppression the user and user talk pages of the suppressed user to enhace privacy. This will be very useful for oversighters/stewards. Thanks.

https://gerrit.wikimedia.org/r/#/c/367679/ to know if we should care about composer.json or if we instead want to add such info in the extension.json file. Thanks.

https://gerrit.wikimedia.org/r/#/c/367667/ as well if possible.

• mmodell mentioned this in T114488: Automate the recurring management of wikitech:Deployments and phab:#train_deployments.Aug 30 2017, 1:27 PM

MarcoAurelio invited: MarcoAurelio; uninvited: • Mholloway.Jul 27 2018, 8:52 AM

MarcoAurelio uninvited: MarcoAurelio.

Code Review Office HoursActivePublicActions