Page MenuHomePhabricator
Create Task
Maniphest T177262

[subtask] Rewrite Page Previews browser tests in Node.js
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

While working on T160238, I propose we split into groups for maximum effectiveness.
This task deals with the Popups extension.

There are 2 scenarios to convert. The popups_settings.feature is unimplemented and should be removed.

Feature: Previews

  • Scenario: Dwelling on a valid link shows a preview # tests/browser/features/previews.feature:8
  • Scenario: Abandoning the link hides the preview # tests/browser/features/previews.feature:12

Notes

  1. Add the mw-wdio-nodepool experimental builder to the Popups item in integration-config/zuul/layout.yaml, which will make check experimental run the new WebdriverIO-based tests.
  1. Put your new tests in the tests/selenium/, following the example structure in RelatedArticles.

Acceptance criteria

  • Remove the settings tests which do not run (see T177310 for more details)
  • Rewrite browser tests for the 2 extensions in a new selenium folder
  • When tests are passing, switch to new job

See T179546.

Sign off notes

The setup of the daily builds will come afterwards (see T171847). Create a task to do this for the extension (or if you are tech lead make that happen).

See also comments on https://gerrit.wikimedia.org/r/#/c/384041

Details

SubjectRepoBranchLines +/-
Clean up ESLint configurationmediawiki/extensions/Popupsmaster+0 -3
Fix location of LocalSettings.phpmediawiki/extensions/Popupsmaster+1 -1
Port Popups browser tests to seleniummediawiki/extensions/Popupsmaster+139 -288
Running mediawiki-core-qunit-selenium-jessie for Popupsintegration/configmaster+1 -11
WIP Running mediawiki-core-qunit-selenium-jessie for Popupsintegration/configmaster+1 -1
WIP Run mediawiki-core-qunit-selenium-jessie for Popupsintegration/configmaster+4 -10
Created mediawiki-core-qunit-selenium-jessie templateintegration/configmaster+11 -10
Drop beta feature step testing in browser testsmediawiki/extensions/Popupsmaster+1 -35
Delete unimplemented browser testsmediawiki/extensions/Popupsmaster+0 -48
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdlrobsonT162936 Improve developer happiness in reading web maintained extensions
 DeclinedNoneT162256 [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions
 ResolvedzeljkofilipinT164024 Rewrite Related pages browser tests in Node.js
 DuplicateJdlrobsonT160238 Rewrite MobileFrontend and Page previews automated browser tests in Node.js
 DeclinedNoneT174018 Port Minerva's 7 Ruby-based browser tests to Selenium Node.js
 ResolvedJdlrobsonT190710 Minerva Ruby and Node.js browser tests running side by side
 ResolvedNoneT179190 Run Selenium Cucumber tests in CI
 ResolvedawightT199116 Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests
 DuplicateLegoktmT225330 Commit package-lock.json files everywhere
 ResolvedhasharT229033 wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10
 ResolvedzeljkofilipinT232495 selenium-daily-beta-CirrusSearch is broken
 ResolvedhasharT229065 Quibble extension selenium test fails with: gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable.
 OpenNoneT199939 Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature
 ResolvedPRODUCTION ERRORJdlrobsonT219920 CI tests disabled: Steps that require login are disabled and should be restored.
 ResolvedJdlrobsonT220658 Minerva browser tests must be configured to run on the mobile domain
 ResolvedJdrewniakT220659 Enable a MobileFrontend daily Selenium build
 OpenNoneT221579 Port "Page actions menu when anonymous.Receive notification message - Watchlist Icon" browser test to Node.js from Ruby
 OpenNoneT245250 Review MinervaNeue Selenium tests
 ResolvedNoneT246881 +2 for Edtadros for mediawiki/skins/MinervaNeue
 ResolvedzeljkofilipinT251543 MinervaNeue Selenium tests fail when targeting MediaWiki-Docker
 ResolvedEdtadrosT177261 Remove QuickSurveys browser tests written in Ruby
 DeclinedNoneT177260 Rewrite disabled MobileFrontend browser tests to phpunit tests and Node.js browser tests
 ResolvedJdlrobsonT181509 [Spike 8hrs] Document missing (?) features of the Node.js automated browser testing stack
 ResolvedzeljkofilipinT139740 Port Selenium tests from Ruby to Node.js
 ResolvedzeljkofilipinT158052 Set up Selenium tests in Node.js for RelatedArticles extension
 ResolvedJdlrobsonT177262 [subtask] Rewrite Page Previews browser tests in Node.js
 ResolvedzeljkofilipinT179546 Popups Selenium tests daily targeting beta cluster
 ResolvedzeljkofilipinT179406 Documentation for selenium-RelatedArticles-jessie

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson set the point value for this task to 3.Oct 3 2017, 4:35 PM
Jdlrobson mentioned this in T177310: Restore page previews browser tests for setting feature?.Oct 3 2017, 6:18 PM

@phuedx with respect to https://phabricator.wikimedia.org/T177262#3653199 I suggest we go ahead and remove these (https://gerrit.wikimedia.org/r/#/c/381899/) to keep scope low for this and I've opened T177310 to decide what to do with them long term.

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Oct 4 2017, 10:39 AM
Jdlrobson moved this task from Upcoming to 2017-18 Q1 on the Web-Team-Backlog board.Oct 4 2017, 4:42 PM
Jdlrobson updated the task description. (Show Details)Oct 4 2017, 4:48 PM
Jdlrobson moved this task from To Do to Blocked on Others on the Readers-Web-Kanbanana-Board-Old board.Oct 9 2017, 4:32 PM

Blocked on T176315

Jdlrobson removed Jdlrobson as the assignee of this task.Oct 9 2017, 4:33 PM
ovasileva moved this task from Blocked on Others to To Do on the Readers-Web-Kanbanana-Board-Old board.Oct 10 2017, 6:41 PM

Moving back to upcoming, to clear the blocked column for in-flight work, as we haven't started work on this yet.

MBinder_WMF moved this task from 2017-18 Q1 to 2017-18 Q2 on the Web-Team-Backlog board.Oct 10 2017, 7:00 PM
zeljkofilipin moved this task from Backlog 🪒 to Q4 👔 on the User-zeljkofilipin board.Oct 11 2017, 2:53 PM
Jdlrobson updated the task description. (Show Details)Oct 11 2017, 4:21 PM
Jdlrobson updated the task description. (Show Details)Oct 11 2017, 9:33 PM
Jdlrobson changed the task status from Open to Stalled.Oct 11 2017, 10:51 PM

on T176315

Jdlrobson updated the task description. (Show Details)Oct 11 2017, 11:12 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Oct 11 2017, 11:22 PM

Change 381899 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Delete unimplemented browser tests

https://gerrit.wikimedia.org/r/381899

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 12 2017, 12:00 AM
phuedx changed the task status from Stalled to Open.Oct 13 2017, 11:01 AM

Per T176315#3682246.

phuedx updated the task description. (Show Details)Oct 13 2017, 1:48 PM
Jdlrobson mentioned this in T177924: Run Popups Selenium tests daily targeting beta cluster.Oct 13 2017, 5:16 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
gerritbot added a comment.Oct 13 2017, 5:18 PM

Change 383934 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Drop beta feature step testing in browser tests

https://gerrit.wikimedia.org/r/383934

Jdlrobson added a comment.Oct 13 2017, 5:19 PM

^ Some prep work which will make this even more trivial.

gerritbot added a comment.Oct 16 2017, 9:16 PM

Change 375384 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Port Popups browser tests to selenium

https://gerrit.wikimedia.org/r/375384

Jdlrobson updated the task description. (Show Details)Oct 16 2017, 9:32 PM
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Oct 16 2017, 11:38 PM
Jdlrobson moved this task from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
phuedx assigned this task to Jdlrobson.Oct 17 2017, 10:20 AM
phuedx moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.

Over to you, @Jdlrobson! There's 1 test that's failing and I think it's due to a missing delay.

gerritbot added a comment.Oct 17 2017, 11:35 AM

Change 375384 had a related patch set uploaded (by Zfilipin; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Port Popups browser tests to selenium

https://gerrit.wikimedia.org/r/375384

zeljkofilipin moved this task from Q4 👔 to Watching 📺 on the User-zeljkofilipin board.Oct 17 2017, 12:36 PM
Jdlrobson moved this task from Needs More Work to Doing on the Readers-Web-Kanbanana-Board-Old board.Oct 17 2017, 5:13 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 17 2017, 6:32 PM

Tests are passing in experimental build for https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/8496/console but code is not mergeable until the necessary config changes are needed.

gerritbot added a comment.Oct 17 2017, 6:36 PM

Change 383934 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Drop beta feature step testing in browser tests

https://gerrit.wikimedia.org/r/383934

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)); removed MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)).Oct 17 2017, 7:00 PM
gerritbot added a comment.Oct 18 2017, 10:24 AM

Change 384961 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Created mediawiki-core-qunit-selenium-jessie template

https://gerrit.wikimedia.org/r/384961

gerritbot added a comment.Oct 18 2017, 10:53 AM

Change 384965 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Running mediawiki-core-qunit-selenium-jessie for Popups

https://gerrit.wikimedia.org/r/384965

gerritbot added a comment.Oct 18 2017, 11:03 AM

Change 384968 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Run mediawiki-core-qunit-selenium-jessie for Popups

https://gerrit.wikimedia.org/r/384968

zeljkofilipin added a subscriber: hashar.Oct 18 2017, 11:18 AM

I have created three patches, 384961, 384965 and 384968. Each of them is solving the problem in slightly different way. For each patch integration-zuul-layoutdiff has scared me, since the diff is big. I am not sure what am I doing wrong. I need @hashar's help.

zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.Oct 18 2017, 11:20 AM
Jdlrobson moved this task from Needs Code Review to Blocked on Others on the Readers-Web-Kanbanana-Board-Old board.Oct 18 2017, 4:57 PM
gerritbot added a comment.Oct 19 2017, 9:20 AM

Change 384961 merged by jenkins-bot:
[integration/config@master] Created mediawiki-core-qunit-selenium-jessie template

https://gerrit.wikimedia.org/r/384961

gerritbot added a comment.Oct 19 2017, 10:19 AM

Change 384968 abandoned by Zfilipin:
WIP Run mediawiki-core-qunit-selenium-jessie for Popups

Reason:
better implementation: https://gerrit.wikimedia.org/r/#/c/384965

https://gerrit.wikimedia.org/r/384968

gerritbot added a comment.Oct 19 2017, 11:05 AM

Change 385172 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] WIP Running mediawiki-core-qunit-selenium-jessie for Popups

https://gerrit.wikimedia.org/r/385172

gerritbot added a comment.Oct 19 2017, 11:14 AM

Change 385172 abandoned by Zfilipin:
WIP Running mediawiki-core-qunit-selenium-jessie for Popups

Reason:
better implementation in https://gerrit.wikimedia.org/r/#/c/384965/

https://gerrit.wikimedia.org/r/385172

phuedx added a comment.Oct 19 2017, 11:18 AM

For those not following along too closely (read: me), what're the changes for @zeljkofilipin?

gerritbot added a comment.Oct 19 2017, 11:19 AM

Change 384965 merged by jenkins-bot:
[integration/config@master] Running mediawiki-core-qunit-selenium-jessie for Popups

https://gerrit.wikimedia.org/r/384965

zeljkofilipin added a comment.Oct 19 2017, 11:30 AM

@phuedx I am not sure I have understood the question. If you are asking what is the status: I had some trouble enabling nodejs+selenium jobs for popups, but it should be working now. :)

zeljkofilipin moved this task from Deep work 🌊 to Watching 📺 on the User-zeljkofilipin board.Oct 19 2017, 11:35 AM
Jdlrobson moved this task from Blocked on Others to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.EditedOct 23 2017, 6:21 PM

I've rebased https://gerrit.wikimedia.org/r/#/c/375384/
I'm guessing that should pass now without check experimental so if that's true all that's needed is a plus two.
When that's done https://gerrit.wikimedia.org/r/#/c/384030/ can be merged which will setup a daily job against the beta cluster.

We are without browser test coverage (per commit) right now.

zeljkofilipin added a comment.Oct 24 2017, 1:20 PM

375384 fails with:

Timeout of 20000ms exceeded. Try to reduce the run time or increase your timeout for test specs (http://webdriver.io/guide/testrunner/timeouts.html); if returning a Promise, ensure it resolves.

384030 was related to T177924 and it was declined.

Jdlrobson added a comment.Oct 24 2017, 2:13 PM

The browser test passes locally.. I'm not sure why the timeout happens when run there.

zeljkofilipin added a comment.Oct 27 2017, 1:47 PM

The screen shot does not help?

https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/8768/artifact/log/Abandoning-link-hides-preview.png

Jdlrobson added a comment.Oct 27 2017, 1:52 PM

Nope. Need a video...

zeljkofilipin added a comment.Oct 27 2017, 1:58 PM

Hm, tests are working fine on my machine too.

~/Documents/gerrit/mediawiki/vagrant/mediawiki$ ./node_modules/.bin/wdio tests/selenium/wdio.conf.js --spec extensions/Popups/tests/selenium/specs/*.js
------------------------------------------------------------------
[chrome #0-0] Session ID: dfca0bbb02b49b6d2bb91901a6ae8850
[chrome #0-0] Spec: /Users/z/Documents/gerrit/mediawiki/vagrant/mediawiki/extensions/Popups/tests/selenium/specs/previews.js
[chrome #0-0] Running: chrome
[chrome #0-0]
[chrome #0-0]   Dwelling on a valid link
[chrome #0-0]
[chrome #0-0]   Dwelling on a valid link
[chrome #0-0]       ✓ I should see a preview
[chrome #0-0]       ✓ Abandoning link hides preview
[chrome #0-0]
[chrome #0-0]
[chrome #0-0] 2 passing (21s)
[chrome #0-0]
zeljkofilipin added a comment.Oct 27 2017, 2:18 PM
In T177262#3715955, @Jdlrobson wrote:

Nope. Need a video...

T179188: Video recording for Selenium tests in Node.js

zeljkofilipin mentioned this in T139740: Port Selenium tests from Ruby to Node.js.Oct 30 2017, 12:07 PM
zeljkofilipin added a parent task: T139740: Port Selenium tests from Ruby to Node.js.
Jdlrobson moved this task from Needs Code Review to Doing on the Readers-Web-Kanbanana-Board-Old board.Oct 31 2017, 12:28 AM
Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Oct 31 2017, 2:12 AM
Jdlrobson added a comment.Oct 31 2017, 7:54 PM

Should be passing now. I gave it a different node to focus which seems to have done the trick.
Can https://gerrit.wikimedia.org/r/#/c/375384/ be merged now..?

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.Nov 1 2017, 5:09 PM
Jdlrobson moved this task from Needs More Work to Doing on the Readers-Web-Kanbanana-Board-Old board.Nov 1 2017, 5:17 PM
gerritbot added a comment.Nov 1 2017, 8:56 PM

Change 375384 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Port Popups browser tests to selenium

https://gerrit.wikimedia.org/r/375384

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)); removed MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Nov 1 2017, 9:00 PM
Jdlrobson moved this task from Doing to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Nov 1 2017, 9:00 PM
Jdlrobson created subtask T179546: Popups Selenium tests daily targeting beta cluster.Nov 1 2017, 10:43 PM
phuedx updated the task description. (Show Details)Nov 6 2017, 2:42 PM
phuedx updated the task description. (Show Details)
phuedx closed this task as Resolved.Nov 6 2017, 2:55 PM

It looks like all of the AC are met 🎉🎉🎉

To be clear: T179546: Popups Selenium tests daily targeting beta cluster covers switching the daily build to the new job.

zeljkofilipin awarded a token.Nov 7 2017, 12:08 PM
zeljkofilipin closed subtask T179546: Popups Selenium tests daily targeting beta cluster as Resolved.Nov 8 2017, 3:21 PM
phuedx mentioned this in T162256: [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions.Nov 8 2017, 3:48 PM
gerritbot added a comment.Dec 19 2017, 12:36 PM

Change 399168 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/Popups@master] Fix location of LocalSettings.php

https://gerrit.wikimedia.org/r/399168

gerritbot added a comment.Dec 19 2017, 2:00 PM

Change 399168 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix location of LocalSettings.php

https://gerrit.wikimedia.org/r/399168

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)); removed MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Dec 19 2017, 3:00 PM
gerritbot added a comment.Dec 22 2017, 3:13 PM

Change 399822 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/Popups@master] Clean up ESLint configuration

https://gerrit.wikimedia.org/r/399822

gerritbot added a comment.Dec 28 2017, 9:52 AM

Change 399822 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Clean up ESLint configuration

https://gerrit.wikimedia.org/r/399822

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL