We should consider whether we want to implement a language picker, or whether user or content language makes more sense, but to start with we should have Kartographer pass the user language as the language code to Kartotherian once T187596: Kartotherian should accept (and propagate) a language parameter for tiles is done.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Send page language to Kartotherian from Kartographer | mediawiki/extensions/Kartographer | master | +28 -22 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T43307 Alow comparison with old revisions while editing an old version of a page | |||
| Resolved | TheDJ | T70008 PDF-related improvements needed at Wikivoyage, especially for dynamic maps | |||
| Declined | Feature | None | T64572 Media Viewer and location map overlays | ||
| Resolved | Etonkovidova | T52714 VisualEditor: Location map template does not display correctly | |||
| Declined | None | T32702 PDF export extension problem with <div style="position:> and any location templates | |||
| Declined | None | T92535 Exclude {{location map}} images from PageImages | |||
| Duplicate | None | T169507 Fix vector map visualisations once the user clicks them on an article (red dot and label missing) | |||
| Resolved | TheDJ | T120809 Generate location maps dynamically, producing actual images | |||
| Resolved | SBisson | T112948 All map location names should be in the user's language | |||
| Resolved | Mooeypoo | T187598 Pass MW user language to Kartotherian from Kartographer |
Event Timeline
Comment Actions
Change 419603 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/Kartographer@master] Send user language to Kartotherian from Kartographer
Comment Actions
Note: It's not possible to have user language in static maps (no user is available at parsing) so the code is using page language, and for consistency, the dynamic maps also use the same.
Comment Actions
@Mooeypoo are you sure about that? I was under the impression that the parser has user (or at least site) language, which means it could generate a proper language-dependent url for the static image.
Comment Actions
Yes, it has. But you will also have to vary parser cache by it, at which point performance ppl will open a hunt for ya:)
Comment Actions
@MaxSem I think static map should still be site-language based, which would prevent cache bloat, while still be useful to the readers (map in Japanese wiki will show in Japanese)
Comment Actions
We are delivering the site language (rather, the page language, in case of translations) in this commit -- just not the interface/user language. That part is not available during parsing.
Comment Actions
If a language picker is to be implemented, the only place where it should (by default) reside is probably on maps.wikimedia.org.
Comment Actions
I don't think we're going for a language picker for the moment (though it might be a good idea for a maps.wikimedia.org feature for the future) -- right now, we're concentrating on making sure that maps that are in wikis are rendering tiles using the wiki language.
Comment Actions
Change 419603 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Send page language to Kartotherian from Kartographer