Page MenuHomePhabricator
Create Task
Maniphest T225039

Add normalized tables to production
Closed, ResolvedPublicJun 18 2019
Actions

Description

To do:

  • run the sql script in production

Details

Due Date
Jun 18 2019, 9:00 PM

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAddshoreT208425 [EPIC] Kill the wb_terms table
 ResolvedArielGlennT226167 audit public tables and make sure we dump them all
 ResolvedAddshoreT219175 [Mega] - Migrate data from wb_terms to new schema
 ResolvedAddshoreT219120 [Checkpoint 1] Create Schema, Migration plan and Doctrine DBAL connection
Resolved• alaa_wmdeT219142 Send the schema to DBAs and follow up with their review
 Resolved• alaa_wmdeT219143 Write DDL sql files for creating the schema
 Resolved• alaa_wmdeT220210 Create a script to generate lots of Items/Properties with lots of Terms
 ResolvedNoneT220230 Tailor a migration plan
 DeclinedNoneT220231 Migration Plan 2
 Declined• alaa_wmdeT219145 Migration Plan 1
 ResolvedLadsgroupT220480 Migration Plan 3
 ResolvedAddshoreT219121 [Checkpoint 2] Refactor Write & Migration code for Properties
 ResolvedLadsgroupT219294 Create interface for writing and deleting entity terms
 ResolvedJeroenDeDauwT219295 Create service for writing property terms
 DeclinedNoneT220169 Optimize term updating
 ResolvedNoneT219297 Adjust current write logic to write property terms to new schema
 ResolvedNoneT219894 Create maintenance script for migrating property terms to new schema
 ResolvedLadsgroupT219296 Update TermSqlStore to comply with EntityTermStoreWriter interface
 ResolvedNoneT220150 [Story] Clean up unused records
 InvalidNoneT221699 Introduce appropriate abstraction for clean up invocation in wikibase-term-store
 DeclinedNoneT221700 implement clean up logic in doctrine-term-store
 ResolvedLucas_Werkmeister_WMDET221701 implement clean up logic in MW DBAL store
 InvalidNoneT221703 add a job to wikibase to invoke clean up logic
 DeclinedNoneT221704 Update wikibase logic to queue a deferred update for cleanup after updating/delete terms in terms store
 ResolvedLadsgroupT221615 Make a test instance in cloud VPS to test new term store
 DeclinedNoneT219805 Investigate Doctrine DBAL usage possibility
 ResolvedJeroenDeDauwT220155 Implement Doctrine DBAL Driver Connection wrapper for MW db connection
 DeclinedNoneT221568 Improve MW connection access
 Resolved• alaa_wmdeT224269 Handle race-conditions between storage and cleanup logic
 ResolvedLucas_Werkmeister_WMDET225050 Update DatabaseItemTermStore and DatabasePropertyTermStore to use callback logic in DatabaseTermIdsAcquirer
 ResolvedLucas_Werkmeister_WMDET224504 Implement database-based PropertyTermStore
 ResolvedLucas_Werkmeister_WMDET224541 Update Wikibase entity saving logic to use PropertyTermStore
 ResolvedAddshoreT219122 [Checkpoint 4] Refactor Write & Migration code for Items
 ResolvedNoneT221564 Create maintenance script for populating new item term persistence
 InvalidNoneT224542 Update Wikibase entity saving logic to use ItemTermStore
 Resolved• alaa_wmdeT224527 Implement database-based ItemTermStore
 ResolvedLadsgroupT219123 Migrate to and read from new store for item terms
 InvalidNoneT221715 Implement ItemTermStore in mediawiki dbal lib
 DuplicateLadsgroupT225055 Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_BOTH
 ResolvedLadsgroupT225056 Run Item Terms Rebuild script
 DuplicateLadsgroupT225057 Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_NEW
 ResolvedLadsgroupT234329 Investigate, fix and reimport failing item terms into new store
 ResolvedLadsgroupT232393 Find out why rebuilding some items in new term store failed
 ResolvedLadsgroupT234948 New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; try restarting transaction
 ResolvedAddshoreT235265 Slow query on SpecialMostLinked creating lag on wikidata slaves
 ResolvedAddshoreT239470 Check the success of the initial terms migration (does it have holes)
 ResolvedAddshoreT239471 Sqoop wikidata terms tables into hadoop
 ResolvedLadsgroupT240235 Alter rebuildItemTerms.php to allow passing of a a list of int item ids to process
 ResolvedAddshoreT245740 LUA getLabelWithLang calls result in many db queries to terms storage with spikey and unpredictable patterns
 ResolvedLadsgroupT246005 Wikibase client description API module results in 15k selected rows with new term storage
 ResolvedLadsgroupT246159 Setting on read new for items causes increased worst response time and number of open connections
 ResolvedLadsgroupT219301 Migrate to and read from new store for property terms
 ResolvedJun 17 2019• alaa_wmdeT224403 Update Labs replication and views to include new schema tables
 ResolvedJun 18 2019LadsgroupT225039 Add normalized tables to production

Event Timeline

• alaa_wmde created this task.Jun 4 2019, 11:49 PM
• alaa_wmde mentioned this in T225038: Add new schema tables as public views in labs.
• alaa_wmde set Due Date to Jun 11 2019, 9:00 PM.Jun 4 2019, 11:51 PM
• alaa_wmde updated the task description. (Show Details)
Restricted Application changed the subtype of this task from "Task" to "Deadline". · View Herald TranscriptJun 4 2019, 11:51 PM
• Marostegui added a comment.Jun 5 2019, 5:10 AM

Just a small note, the labs views are not necessary for replication, they are necessary for users to be able to query them.
If the tables are going to be fully public, there is no need to add anything to let replication work.

• alaa_wmde added a comment.Jun 5 2019, 5:51 AM

@Marostegui oh yeah thanks for pointing out the wrong description (never write a task description after 23:00 😆 ) .. will fix it

• alaa_wmde updated the task description. (Show Details)Jun 5 2019, 5:51 AM
• Marostegui added a comment.Jun 5 2019, 5:58 AM

Hehe - I just wanted to make sure it was clear that the views are not involved into the replication process at all (it can be confusing as there are many moving parts involved on the labs infra: replication filters, views, triggers, sanitization...) :-)

• alaa_wmde changed Due Date from Jun 11 2019, 9:00 PM to Jun 18 2019, 9:00 PM.Jun 11 2019, 1:45 PM
darthmon_wmde mentioned this in T224403: Update Labs replication and views to include new schema tables.Jun 18 2019, 1:01 PM
WMDE-leszek added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jun 18 2019, 1:06 PM
darthmon_wmde updated the task description. (Show Details)Jun 18 2019, 1:06 PM
Stashbot added a comment.Jun 18 2019, 1:56 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-18T13:56:01Z] <Amir1> ladsgroup@mwmaint1002:~$ mwscript sql.php --wiki=testwikidatawiki /srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/repo/sql/AddNormalizedTermsTablesDDL.sql (T225039)

Stashbot added a comment.Jun 18 2019, 1:56 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-18T13:56:21Z] <Amir1> ladsgroup@mwmaint1002:~$ mwscript sql.php --wiki=wikidatawiki /srv/mediawiki/php-1.34.0-wmf.8/extensions/Wikibase/repo/sql/AddNormalizedTermsTablesDDL.sql (T225039)

Ladsgroup claimed this task.Jun 18 2019, 1:56 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJun 18 2019, 1:56 PM
• alaa_wmde added a comment.Jun 19 2019, 9:44 PM

@Ladsgroup how is it done for beta btw? will those propagate as part of replication to beta as well somehow? or do we need to run that sql on beta manually too?

Ladsgroup added a comment.Jun 19 2019, 9:52 PM
In T225039#5269745, @alaa_wmde wrote:

@Ladsgroup how is it done for beta btw? will those propagate as part of replication to beta as well somehow? or do we need to run that sql on beta manually too?

If it was wired to update.php, it would have been done automatically but since it's not wired there yet, I needed to run it manually which I did yesterday :]

• alaa_wmde added a comment.Jun 19 2019, 9:58 PM
In T225039#5269754, @Ladsgroup wrote:
In T225039#5269745, @alaa_wmde wrote:

@Ladsgroup how is it done for beta btw? will those propagate as part of replication to beta as well somehow? or do we need to run that sql on beta manually too?

If it was wired to update.php, it would have been done automatically but since it's not wired there yet, I needed to run it manually which I did yesterday :]

that's great to hear :) thank you! (I assume that those aren't sent to SAL, that's why there isn't a comment for beta on this task right?)

• alaa_wmde closed this task as Resolved.Jun 19 2019, 10:02 PM
• alaa_wmde moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Ladsgroup added a comment.Jun 19 2019, 10:12 PM
In T225039#5269805, @alaa_wmde wrote:

that's great to hear :) thank you! (I assume that those aren't sent to SAL, that's why there isn't a comment for beta on this task right?)

Yeah, as you already know, I'm extremely lazy

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL