Waiting on T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource (Cleaning up To-Do column)

This is done right @alaa_wmde @Ladsgroup ?

Aaah, except this ticket also includes switching to read from the new store etc. my bad..

Mentioned in SAL (#wikimedia-operations) [2020-01-06T03:53:50Z] <Amir1> ladsgroup@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildItemTerms.php --wiki=wikidatawiki --batch-size=100 --sleep=2 --file=/tmp/100k.lines (T219301)

Mentioned in SAL (#wikimedia-operations) [2020-01-06T07:37:26Z] <Amir1> ladsgroup@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildItemTerms.php --wiki=wikidatawiki --batch-size=100 --sleep=2 --file=/tmp/1mio.lines (T219301)

As of 1.35.0-wmf.15 we believe we can stop writing to properties now.
Some notes about why we are ready for wikidata org can be found in P10163 (we cant change the default for wikibase until a few more things happen.

This will need a re announcement to stop writing to wb_terms for properties.

Mentioned in SAL (#wikimedia-releng) [2020-01-16T09:31:55Z] <Amir1> "delete from wikidatawiki.wb_terms where term_full_entity_id like 'P%'" (T219301 T225054)

Mentioned in SAL (#wikimedia-operations) [2020-01-16T12:19:32Z] <Amir1> "delete from testwikidatawiki.wb_terms where term_full_entity_id like 'P%'" (T219301 T225054)

T243944 identified more holes, and also more holes in properties, so this migration stage will also have to be run once more / have things manually fixed
I'll do that as @Ladsgroup is going on vacation!

Mentioned in SAL (#wikimedia-operations) [2020-01-31T09:18:16Z] <addshore> addshore@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildPropertyTerms.php --wiki=wikidatawiki --sleep 4 --batch-size=25 # In a screen for T219301

The property tables are once again complete...

mysql:research@dbstore1005.eqiad.wmnet [wikidatawiki]> SELECT   wbpt_property_id as id,   wby_name as type,   wbxl_language as language,   wbx_text as text FROM wbt_property_terms LEFT JOIN wbt_term_in_ lang ON wbpt_term_in_lang_id = wbtl_id LEFT JOIN wbt_type ON wbtl_type_id = wby_id LEFT JOIN wbt_text_in_lang ON wbtl_text_in_lang_id = wbxl_id LEFT JOIN wbt_text ON wbxl_text_id = wbx_id WHERE wbx_text  IS NULL;
Empty set (1.13 sec)

mysql:research@dbstore1005.eqiad.wmnet [wikidatawiki]> SELECT   wbpt_property_id as id,   wby_name as type,   wbxl_language as language,   wbx_text as text FROM wbt_property_terms LEFT JOIN wbt_term_in_ lang ON wbpt_term_in_lang_id = wbtl_id LEFT JOIN wbt_type ON wbtl_type_id = wby_id LEFT JOIN wbt_text_in_lang ON wbtl_text_in_lang_id = wbxl_id LEFT JOIN wbt_text ON wbxl_text_id = wbx_id WHERE wbx_text
  IS NULL;
+------+-------+----------+------+
| id   | type  | language | text |
+------+-------+----------+------+
| 7850 | alias | NULL     | NULL |
| 7786 | alias | NULL     | NULL |
| 7884 | alias | NULL     | NULL |
| 7885 | alias | NULL     | NULL |
| 1416 | alias | NULL     | NULL |
|  932 | alias | NULL     | NULL |
|  846 | alias | NULL     | NULL |
| 2326 | alias | NULL     | NULL |
|  590 | alias | NULL     | NULL |
| 1566 | alias | NULL     | NULL |
|  356 | alias | NULL     | NULL |
+------+-------+----------+------+
11 rows in set (6.33 sec)

Checking this again today it appears there might still be one situation that is causing issue that we should investigate.

Change 577218 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/mediawiki-config@master] Stop writing to the old term store for properties

https://gerrit.wikimedia.org/r/577218

Change 577218 merged by jenkins-bot:
[operations/mediawiki-config@master] Stop writing to the old term store for properties

https://gerrit.wikimedia.org/r/577218

Mentioned in SAL (#wikimedia-operations) [2020-03-05T11:42:17Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: [[gerrit:577218|Stop writing to the old term store for properties (T219301 T225054)]] (duration: 01m 04s)

Mentioned in SAL (#wikimedia-operations) [2020-03-05T11:43:35Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: [[gerrit:577218|Stop writing to the old term store for properties (T219301 T225054)]], take II (duration: 01m 04s)