Page MenuHomePhabricator
Create Task
Maniphest T225052

Run Property Terms Rebuild script
Closed, ResolvedPublicJun 25 2019
Actions

Description

  • script is under /repo/maintenance/rebuildPropertyTerms.php
  • maybe run it in batches, say 100 properties per batch
  • between batches sleeping for 2-5 seconds is advised, and also (additionally) using Mediawiki's "wait for replication lag" function, to ensure replicas have enough time to catch up with updates
  • migration of all property terms should finish by the due date, before switching migration stage to read from new

Details

Due Date
Jun 25 2019, 10:00 PM

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAddshoreT208425 [EPIC] Kill the wb_terms table
 ResolvedArielGlennT226167 audit public tables and make sure we dump them all
 ResolvedAddshoreT219175 [Mega] - Migrate data from wb_terms to new schema
 ResolvedAddshoreT219120 [Checkpoint 1] Create Schema, Migration plan and Doctrine DBAL connection
Resolved• alaa_wmdeT219142 Send the schema to DBAs and follow up with their review
 Resolved• alaa_wmdeT219143 Write DDL sql files for creating the schema
 Resolved• alaa_wmdeT220210 Create a script to generate lots of Items/Properties with lots of Terms
 ResolvedNoneT220230 Tailor a migration plan
 DeclinedNoneT220231 Migration Plan 2
 Declined• alaa_wmdeT219145 Migration Plan 1
 ResolvedLadsgroupT220480 Migration Plan 3
 ResolvedAddshoreT219121 [Checkpoint 2] Refactor Write & Migration code for Properties
 ResolvedLadsgroupT219294 Create interface for writing and deleting entity terms
 ResolvedJeroenDeDauwT219295 Create service for writing property terms
 DeclinedNoneT220169 Optimize term updating
 ResolvedNoneT219297 Adjust current write logic to write property terms to new schema
 ResolvedNoneT219894 Create maintenance script for migrating property terms to new schema
 ResolvedLadsgroupT219296 Update TermSqlStore to comply with EntityTermStoreWriter interface
 ResolvedNoneT220150 [Story] Clean up unused records
 InvalidNoneT221699 Introduce appropriate abstraction for clean up invocation in wikibase-term-store
 DeclinedNoneT221700 implement clean up logic in doctrine-term-store
 ResolvedLucas_Werkmeister_WMDET221701 implement clean up logic in MW DBAL store
 InvalidNoneT221703 add a job to wikibase to invoke clean up logic
 DeclinedNoneT221704 Update wikibase logic to queue a deferred update for cleanup after updating/delete terms in terms store
 ResolvedLadsgroupT221615 Make a test instance in cloud VPS to test new term store
 DeclinedNoneT219805 Investigate Doctrine DBAL usage possibility
 ResolvedJeroenDeDauwT220155 Implement Doctrine DBAL Driver Connection wrapper for MW db connection
 DeclinedNoneT221568 Improve MW connection access
 Resolved• alaa_wmdeT224269 Handle race-conditions between storage and cleanup logic
 ResolvedLucas_Werkmeister_WMDET225050 Update DatabaseItemTermStore and DatabasePropertyTermStore to use callback logic in DatabaseTermIdsAcquirer
 ResolvedLucas_Werkmeister_WMDET224504 Implement database-based PropertyTermStore
 ResolvedLucas_Werkmeister_WMDET224541 Update Wikibase entity saving logic to use PropertyTermStore
 ResolvedAddshoreT219122 [Checkpoint 4] Refactor Write & Migration code for Items
 ResolvedNoneT221564 Create maintenance script for populating new item term persistence
 InvalidNoneT224542 Update Wikibase entity saving logic to use ItemTermStore
 Resolved• alaa_wmdeT224527 Implement database-based ItemTermStore
 ResolvedLadsgroupT219123 Migrate to and read from new store for item terms
 InvalidNoneT221715 Implement ItemTermStore in mediawiki dbal lib
 DuplicateLadsgroupT225055 Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_BOTH
 ResolvedLadsgroupT225056 Run Item Terms Rebuild script
 DuplicateLadsgroupT225057 Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_NEW
 ResolvedLadsgroupT234329 Investigate, fix and reimport failing item terms into new store
 ResolvedLadsgroupT232393 Find out why rebuilding some items in new term store failed
 ResolvedLadsgroupT234948 New Wikibase deadlocks on Wikidata wiki since 2019-10-08T00:00:02: Wikibase\Lib\Store\Sql\Terms\{closure} Deadlock found when trying to get lock; try restarting transaction
 ResolvedAddshoreT235265 Slow query on SpecialMostLinked creating lag on wikidata slaves
 ResolvedAddshoreT239470 Check the success of the initial terms migration (does it have holes)
 ResolvedAddshoreT239471 Sqoop wikidata terms tables into hadoop
 ResolvedLadsgroupT240235 Alter rebuildItemTerms.php to allow passing of a a list of int item ids to process
 ResolvedAddshoreT245740 LUA getLabelWithLang calls result in many db queries to terms storage with spikey and unpredictable patterns
 ResolvedLadsgroupT246005 Wikibase client description API module results in 15k selected rows with new term storage
 ResolvedLadsgroupT246159 Setting on read new for items causes increased worst response time and number of open connections
 ResolvedLadsgroupT219301 Migrate to and read from new store for property terms
 ResolvedJun 25 2019LadsgroupT225052 Run Property Terms Rebuild script

Event Timeline

• alaa_wmde created this task.Jun 5 2019, 6:37 AM
• alaa_wmde set Due Date to Jun 17 2019, 10:00 PM.Jun 5 2019, 6:40 AM
• alaa_wmde updated the task description. (Show Details)
Restricted Application changed the subtype of this task from "Task" to "Deadline". · View Herald TranscriptJun 5 2019, 6:40 AM
• alaa_wmde changed Due Date from Jun 17 2019, 10:00 PM to Jun 26 2019, 10:00 PM.Jun 13 2019, 5:59 PM
• alaa_wmde changed Due Date from Jun 26 2019, 10:00 PM to Jun 25 2019, 10:00 PM.
WMDE-leszek updated the task description. (Show Details)Jun 18 2019, 12:56 PM
WMDE-leszek updated the task description. (Show Details)
WMDE-leszek updated the task description. (Show Details)
Stashbot added a comment.Jun 20 2019, 2:18 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-20T14:18:18Z] <Amir1> start of ladsgroup@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildPropertyTerms.php --wiki=testwikidatawiki --batch-size=100 --sleep=3 (T225052)

Stashbot added a comment.Jun 20 2019, 2:28 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-20T14:28:17Z] <Amir1> end of ladsgroup@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildPropertyTerms.php --wiki=testwikidatawiki --batch-size=100 --sleep=3 (T225052)

Addshore moved this task from incoming to in progress on the Wikidata board.Jun 21 2019, 11:37 PM
• alaa_wmde added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jun 26 2019, 6:26 AM
Ladsgroup claimed this task.Jun 26 2019, 11:15 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJun 26 2019, 11:15 AM
Stashbot added a comment.Jun 26 2019, 12:27 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-26T12:27:05Z] <Amir1> end of ladsgroup@mwmaint1002:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildPropertyTerms.php --wiki=wikidatawiki --batch-size=100 --sleep=3 (T225052)

Ladsgroup moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 26 2019, 12:27 PM
• alaa_wmde mentioned this in T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW.Jun 27 2019, 7:56 AM
Stashbot added a comment.Jun 27 2019, 12:01 PM

Mentioned in SAL (#wikimedia-operations) [2019-06-27T12:01:43Z] <Amir1> start of mwscript extensions/Wikibase/repo/maintenance/rebuildPropertyTerms.php --wiki=testwikidatawiki --batch-size=100 --sleep=3 (T225052)

• alaa_wmde moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 5 2019, 1:51 PM
Lydia_Pintscher closed this task as Resolved.Jul 15 2019, 11:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL