Page MenuHomePhabricator

FlaggedRevs: Automatic user promotion stopped working on some wikis on June 24
Open, Needs TriagePublic

Description

As you can see in the log, the automatic user promotion which gives users autoreview/review right has stopped working on June 24, 2019. The last automatic promotion was done shortly before 2400 local time.

Wikis where it stopped working

  • dewiki
  • plwiki
  • enwikibooks

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2019, 12:44 PM
Count_Count updated the task description. (Show Details)
Zache added a subscriber: Zache.Nov 3 2019, 12:51 PM

@Count_Count Just out of curiosity, what is the criteria for auto-promotion there? How many edits an user needs to get promoted to autochecked user and editor?

@Count_Count Just out of curiosity, what is the criteria for auto-promotion there? How many edits an user needs to get promoted to autochecked user and editor?

For autoreview:

  • 30 days since registration
  • 50 total edit count
  • 7 edits with at least 3 days between each other
  • 150 content edits or 50 edits leading to a stable version
  • 8 different content pages edited
  • 20 edits with manual edit summaries used
  • never blocked

For review:

  • 60 days since registration
  • 300 total edit count
  • 15 edits with at least 3 days between each other
  • 300 content edits or 200 edits leading to a stable version
  • 14 different content pages edited
  • 30 edits with manual edit summaries used
  • never blocked
  • at most 3% of edits reverted
  • 5 content edits in last 30 days
Krd added a subscriber: Krd.Nov 4 2019, 2:44 PM
Zache added a subscriber: Reedy.Nov 5 2019, 9:25 AM

@Reedy The date June 24, 2019 matches with your FlaggedRevs config rework but i didn't spot yet anything which would have broken the autopromote.

I tried testing the auto-promotion system on dewiki using my account. True, it is not working.

This task is from 2012 and clearly not related. Autopromotion is not working at all in dewiki since June 24, 2019.

MGChecker updated the task description. (Show Details)Nov 28 2019, 4:25 PM
MGChecker added a subscriber: MGChecker.
Tgr added a subscriber: Tgr.

Site configuration issue so adding responsible team.

poupou added a subscriber: poupou.Dec 13 2019, 6:44 AM
Masumrezarock100 renamed this task from FlaggedRevs: Automatic user promotion stopped working in dewiki on June 24 to FlaggedRevs: Automatic user promotion stopped working on some wikis on June 24.Dec 14 2019, 2:09 AM
Masumrezarock100 added a comment.EditedDec 14 2019, 2:12 AM

Obviously not a single wiki issue. Auto-promotion stopped working on enwikibooks and some other wikis as well. On English Wikibooks, the last auto-promotion occurred on 20 June 2019, two days before it stopped working on dewiki. I am inclined to believe it's an issue with the extension itself rather than a site configuration regression. I do not know about other wikis. Could anyone reach out to wikis where this extension is deployed/enabled to see if they are facing the same problem?

Masumrezarock100 added a comment.EditedDec 14 2019, 2:35 AM

@Zache Could you confirm that auto-promotion stopped working on Finnish Wikipedia?

Zache added a comment.Dec 14 2019, 2:52 AM

@Zache Could you confirm that auto-promotion stopped working on Finnish Wikipedia?

Finnish Wikipedia is using manual promotion for autoreview and editor user groups, so this cannot be tested with fiwiki.

Zache added a comment.EditedDec 14 2019, 3:40 AM

In plwiki it stopped working also at 23:17, 24 June 2019 ( log )

Zache updated the task description. (Show Details)Dec 14 2019, 10:17 AM

Obviously not a single wiki issue. Auto-promotion stopped working on enwikibooks and some other wikis as well. On English Wikibooks, the last auto-promotion occurred on 20 June 2019, two days before it stopped working on dewiki. I am inclined to believe it's an issue with the extension itself rather than a site configuration regression. I do not know about other wikis. Could anyone reach out to wikis where this extension is deployed/enabled to see if they are facing the same problem?

Around this date, the Wikimedia global FlaggedRevs configuration has been reorganiszed. So it is much more probable to actually be a site configuration issue.

Masumrezarock100 added a comment.EditedDec 15 2019, 11:23 PM

Around this date, the Wikimedia global FlaggedRevs configuration has been reorganiszed. So it is much more probable to actually be a site configuration issue.

Hmm. So when the person who caused this regression is going to fix it? Does it really take over 6 months to fix it?

Zache added a comment.EditedDec 17 2019, 8:13 AM

Tested that flaggedrevs_promote is still updated

MariaDB [dewiki_p]> select * from flaggedrevs_promote where frp_user_id=1374006;

+-------------+------------------------------------------------------------------------------------------------+
| frp_user_id | frp_user_params                                                                                |
+-------------+------------------------------------------------------------------------------------------------+
|     1374006 | uniqueContentPages=3083097,6296562,1386366
totalContentEdits=3
editComments=15
revertedEdits=1 |
+-------------+------------------------------------------------------------------------------------------------+
1 row in set (1.58 sec)

And after edit: https://de.wikipedia.org/w/index.php?title=Kabinett_Marin&diff=prev&oldid=194975694

MariaDB [dewiki_p]> select * from flaggedrevs_promote where frp_user_id=1374006;
+-------------+---------------------------------------------------------------------------------------------------------+
| frp_user_id | frp_user_params                                                                                         |
+-------------+---------------------------------------------------------------------------------------------------------+
| 1374006 | uniqueContentPages=3083097,6296562,1386366,11066484
totalContentEdits=4
editComments=16
revertedEdits=1 |
+-------------+---------------------------------------------------------------------------------------------------------+

This means that either wgFlaggedRevsAutopromote OR wgFlaggedRevsAutoconfirm
is defined when FlaggedRevsHooks.php : onPageContentSaveComplete() is called.

Hi @DannyS712 Question: can abuse filter be used for autopromotion? If so this could be a temporary solution.

Hi @DannyS712 Question: can abuse filter be used for autopromotion? If so this could be a temporary solution.

No, it cannot be, sorry

Hi @DannyS712 Question: can abuse filter be used for autopromotion? If so this could be a temporary solution.

No, it cannot be, sorry

Too bad. Only demotion of existing autoconfirmed accounts/restoring autoconfirmed starus are allowed, it seems.

Zache added a comment.Dec 24 2019, 9:32 AM

If we just want quickfix for autopromote with some features missing then it editor/autoreview/reviewer groups could just added via wmgAutopromoteExtraGroups or wmgAutopromoteOnceonEdit in InitialiseSettings.php

Some notes.

If I looked correctly dewiki's $wgFlaggedRevsAutoconfirm variable wasn't changed in 24 June 2019 in config rewrite. It was also already set to false at extension.jsonbefore the config change. Based on deployment calendar the mediawiki software update was 27.6 so it is not explanation either. Only bigger change was wrapping wmf-config/flaggedrevs.php was to function which was called from wgExtensionFunctions.