Other parts of MediaWiki besides MobileFrontend need the ability to detect device type, for example, for logging or skinning or enabling certain UI interactions. Let's move the DeviceDetection class from MobileFrontend into core so that we don't have to reinvent the wheel.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T29292 Skinning system improvement (tracking) | |||
| Resolved | None | T97968 Discuss mobile support in the mw skinning system for responsive skins | |||
| Declined | None | T162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking) | |||
| Open | None | T100402 Core should have support for mobile detection and customization | |||
| Open | None | T284512 [EPIC] Empower others to develop new, and extend existing, editing experiences | |||
| Open | None | T249944 WikiEditor records all edits as platform = desktop in EventLogging | |||
| Open | None | T263501 Move DeviceDetection.php from MobileFrontend to core |
Event Timeline
Comment Actions
What, again? :P It was in the core at some point, was moved back because only MF used it anyway.
Comment Actions
Hey @MaxSem, nice to see you! Yes, it was in core originally, and there is a bit of a chicken and egg problem, as I mentioned in T100402#6057011. In order to fix T249944, we need to move it back to core though. It would also be useful for other cases (see T100402). What do you think?
Comment Actions
Change 680460 had a related patch set uploaded (by Mholloway; author: Michael Holloway):
[mediawiki/core@master] Move device detection from MobileFrontend into core
Comment Actions
This would also be useful for some of the work we're doing to improve product analytics instrumentation. Reviews welcome on the change above from anyone interested in seeing this get done. I'll follow up with a change to MobileFrontend to use the functionality from core.
Comment Actions
Change 680461 had a related patch set uploaded (by Mholloway; author: Michael Holloway):
[mediawiki/extensions/MobileFrontend@master] Use device detection from MediaWiki core
Comment Actions
Change 680460 abandoned by Mholloway:
[mediawiki/core@master] Move device detection from MobileFrontend into core
Reason:
Thanks Krinkle for the thoughts and DannyS712 for the review. I'm convinced we don't want this as is for the reasons mentioned, so I think I'll abandon this for the time being and put some thought into a more focused approach for EL based on the ua-parser library, as suggested.
Comment Actions
Change 680461 abandoned by Mholloway:
[mediawiki/extensions/MobileFrontend@master] Use device detection from MediaWiki core
Reason:
See discussion on parent.