Page MenuHomePhabricator

Move DeviceDetection.php from MobileFrontend to core
Open, Needs TriagePublic

Description

Other parts of MediaWiki besides MobileFrontend need the ability to detect device type, for example, for logging or skinning or enabling certain UI interactions. Let's move the DeviceDetection class from MobileFrontend into core so that we don't have to reinvent the wheel.

Event Timeline

kaldari created this task.Sep 21 2020, 9:56 PM

What, again? :P It was in the core at some point, was moved back because only MF used it anyway.

Hey @MaxSem, nice to see you! Yes, it was in core originally, and there is a bit of a chicken and egg problem, as I mentioned in T100402#6057011. In order to fix T249944, we need to move it back to core though. It would also be useful for other cases (see T100402). What do you think?