Page MenuHomePhabricator

FileImporter constructs EditPage for a special page
Closed, ResolvedPublic

Description

FileImporter extension has this code:

https://github.com/wikimedia/mediawiki-extensions-FileImporter/blob/master/src/Html/WikitextEditor.php#L40-L52

it constructs an EditPage just to pass it into a EditPage::showEditForm:initial hook to generate the editing sidebar or something and so needs to construct Article, WikiPage, Title on a special page. This is now deprecated and will definitely break.

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
StalledNone
DuplicateNone
OpenNone
ResolvedNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedKrinkle
OpenNone
ResolvedNone
ResolvedNone
StalledNone
OpenNone
OpenNone
Opendaniel
OpenNone
OpenNone
OpenNone
OpenNone
Resolveddaniel
Opendaniel
Resolveddaniel
Resolveddaniel

Event Timeline

Change 663038 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FileImporter@master] Don't construct Article on a SpecialPage

https://gerrit.wikimedia.org/r/663038

Change 663038 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Fix wrong context title in WikitextEditor

https://gerrit.wikimedia.org/r/663038