CirrusSearch: access to WikiPage that not represents a page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pchelolo
	Feb 9 2021, 11:29 PM

Description

Error:
Accessing WikiPage that cannot exist as a page: Special:Badtitle/NS90:Help talk:SSH/What to do with private key?. [Called from WikiPage::exists]

Stack:

#4 /srv/mediawiki/php-1.36.0-wmf.29/includes/page/WikiPage.php(451): wfDeprecatedMsg(string, string)
#5 /srv/mediawiki/php-1.36.0-wmf.29/includes/page/WikiPage.php(579): WikiPage->loadPageData()
#6 /srv/mediawiki/php-1.36.0-wmf.29/extensions/CirrusSearch/includes/Updater.php(126): WikiPage->exists()
#7 /srv/mediawiki/php-1.36.0-wmf.29/extensions/CirrusSearch/includes/Updater.php(74): CirrusSearch\Updater->traceRedirects(Title)
#8 /srv/mediawiki/php-1.36.0-wmf.29/extensions/CirrusSearch/includes/Job/LinksUpdate.php(51): CirrusSearch\Updater->updateFromTitle(Title)
#9 /srv/mediawiki/php-1.36.0-wmf.29/extensions/CirrusSearch/includes/Job/JobTraits.php(136): CirrusSearch\Job\LinksUpdate->doJob()
#10 /srv/mediawiki/php-1.36.0-wmf.29/includes/jobqueue/JobRunner.php(375): CirrusSearch\Job\CirrusTitleJob->run()
#11 /srv/mediawiki/php-1.36.0-wmf.29/includes/jobqueue/JobRunner.php(336): JobRunner->doExecuteJob(CirrusSearch\Job\LinksUpdate)
#12 /srv/mediawiki/php-1.36.0-wmf.29/includes/jobqueue/JobRunner.php(247): JobRunner->executeJob(CirrusSearch\Job\LinksUpdate)
#13 /srv/mediawiki/php-1.36.0-wmf.29/maintenance/runJobs.php(93): JobRunner->run(array)
#14 /srv/mediawiki/php-1.36.0-wmf.29/maintenance/doMaintenance.php(106): RunJobs->execute()
#15 /srv/mediawiki/php-1.36.0-wmf.29/maintenance/runJobs.php(130): require_once(string)
#16 /srv/mediawiki/multiversion/MWScript.php(101): require_once(string)

https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-2021.02.09?id=gj1wiHcB3WpTGKOO20wf

Details

	Subject	Repo	Branch	Lines +/-
	Test for handling of invalid Titles	mediawiki/core	master	+18 -0
	Don't try to index pages that can't exist.	mediawiki/extensions/CirrusSearch	master	+4 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		daniel	T196087 Refactored implementation of MCR page update interface
Open		pmiazga	T302623 FY2022-2023: Improve Backend Pageview Timing
Resolved		None	T206498 MediaWiki needlessly queries page data twice on page views
Invalid		None	T273514 MW expedition work [high effort]
Open		None	T273542 Migrate ZObjectStore from WikiPage to PageStore when it exists
Resolved		None	T195069 Factor PageStore and PageRecord out of WikiPage
Resolved		daniel	T272421 Make WikiPage a PageRecord
Resolved		daniel	T272424 Make WikiPage a ProperPageIdentity
Resolved		daniel	T272518 Watch for extensions broken by WikiPage now deprecating construction on bad titles
Resolved		daniel	T274317 CirrusSearch: access to WikiPage that not represents a page

Event Timeline

• Pchelolo renamed this task from CirrusSearch builds invalid WikiPage to CirrusSearch: access to WikiPage that not represents a page.Feb 9 2021, 11:29 PM

• Pchelolo created this task.

daniel triaged this task as High priority.Feb 10 2021, 12:20 PM

daniel moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.

Ah, this is a nasty edge case. The code has this check:

// Never. Ever. Index. Negative. Namespaces.
if ( $title->getNamespace() < 0 ) {
	return [ null, $redirects ];
}

Which should prevent the issue at hand. But the title actually has a positive namespace (with index 90). This namespace however is invalid (undefined), so the namespace prefix is turned into "Special:Badtitle/NS90". When this is parsed again, we get back a special page.

Perhaps we could simply check $title->exists()? That would fix it, I think.

Change 663228 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/CirrusSearch@master] Don't try to index pages that can't exist.

https://gerrit.wikimedia.org/r/663228

Change 663227 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Test for handling of invalid Titles

https://gerrit.wikimedia.org/r/663227

gerritbot added a project: Patch-For-Review.Feb 10 2021, 3:49 PM

daniel moved this task from PageStore pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Feb 10 2021, 3:49 PM

Change 663228 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Don't try to index pages that can't exist.

https://gerrit.wikimedia.org/r/663228

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 10 2021, 5:00 PM

• Pchelolo moved this task from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.Feb 22 2021, 8:07 PM

• Pchelolo closed this task as Resolved.Feb 23 2021, 9:01 PM