Change 737402 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Implement dailyLimit quality gate for add link

https://gerrit.wikimedia.org/r/737402

Change 737489 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[schemas/event/secondary@master] LinkSuggestionInteraction: Add qualitygate_dialog

https://gerrit.wikimedia.org/r/737489

@RHo @MMiller_WMF this doesn't need urgent attention, but if you want, the same daily limit quality gate from image recommendation could be added for link recommendation tasks. Like the image recommendation quality gate, it will be configurable via Special:EditGrowthConfig once T294518: Add Image: Allow disabling feature via community configuration is done -- both to enable/disable the quality gate, as well as to specify the maximum number of tasks per day per user.

Functionally, it's the exact same behavior as T293316: Add an image: minimal quality gate except applied to link-recommendation tasks. The only differences are:

• how many link recommendation tasks a user should be allowed to perform per day. 25 (used for image recommendations) seemed high; perhaps a value like 10 is more appropriate? Perhaps we have some data to support a good number here.
• the copy is identical to the minimal quality gate for image recommendations, except that "link" has been substituted for "image". The new strings are at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/737402/9/i18n/help/en.json and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/737402/9/i18n/homepage/en.json

@kostajh -- we're so glad you did this. It's one of the top requests about "add a link", so if we're able to just implement, let's do it! We would want to implement with the same 25 task limit that we used for images. 25 is a number that communities proposed to us for this, so we want to start there.

And the copy as you altered it looks good to us.

My only question is whether the two quality gates will work well with each other. Like if someone completes all their image tasks, then switches over to links and completes all their link tasks, will both the gates function fine together and stop the user for both task types as they navigate their feed?

If all good, then please go ahead and deploy!

In T274325#7493746, @MMiller_WMF wrote:

@kostajh -- we're so glad you did this. It's one of the top requests about "add a link", so if we're able to just implement, let's do it! We would want to implement with the same 25 task limit that we used for images. 25 is a number that communities proposed to us for this, so we want to start there.

And the copy as you altered it looks good to us.

sounds good! Updated the patch to use the 25 limit.

My only question is whether the two quality gates will work well with each other. Like if someone completes all their image tasks, then switches over to links and completes all their link tasks, will both the gates function fine together and stop the user for both task types as they navigate their feed?

If all good, then please go ahead and deploy!

Yeah, no problems there. If the user does 25 for each task type, they'll be stopped from both until the next day.

Change 737489 merged by jenkins-bot:

[schemas/event/secondary@master] LinkSuggestionInteraction: Add qualitygate_dialog

https://gerrit.wikimedia.org/r/737489

Change 737402 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Implement dailyLimit quality gate for add link

https://gerrit.wikimedia.org/r/737402

@mewoph @Etonkovidova -- from this task, it seems like the quality gate for "add a link" should be in production by now, so I went to go double-check. It doesn't look like it's in production, because I found this user from nlwiki who is doing many more than 25 link edits per day: https://nl.wikipedia.org/wiki/Speciaal:Bijdragen/MvdH96

Could you please let me know the status here?

Hi @MMiller_WMF, this was merged on Nov 24, but there hasn't been a train since. The next one is this week (1.38.0-wmf.12).

Thanks, @mewoph -- so we should expect to see it in production on Thursday.

While working on T294674, I decided to poke the Add a Link event data as well and found conflicting results. Event data in mediawiki_structured_task_article_link_suggestion_interaction show that the quality gate dialog starts showing up on 2021-12-09. When checking the number of edits tagged with newcomer task add link in mediawiki_revision_tags_change, I find many users who have made more than 25 edits in a day. Example user from plwiki making 151 tagged edits on 2021-12-20 (they also made 98 edits on 2020-12-18).

Thanks, @nettrom_WMF. @Etonkovidova could you please look into this? It sounds like the quality gate may not be working right.

I don't know if this explains what we see in the data, but right clicking on a task card and opening in a new tab will bypass the gate, since it's only validated on the client-side. We can enforce it on the server-side too.

Change 752152 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] QualityGates: Enforce daily limit on server-side

https://gerrit.wikimedia.org/r/752152

In T274325#7604358, @kostajh wrote:

I don't know if this explains what we see in the data, but right clicking on a task card and opening in a new tab will bypass the gate, since it's only validated on the client-side. We can enforce it on the server-side too.

Confirmed. The same behavior (bypassing the quality gate is true) for Add image tasks.

I'd guess this is mostly happening to users who keep the homepage open and launch tasks in new tabs, which is what I'd do if I wanted to do dozens of tasks in a go. The limit won't take effect until you refresh the homepage. (Could be verified by comparing the homepage token on those events, probably not worth the effort though.)

In T274325#7605959, @Tgr wrote:

I'd guess this is mostly happening to users who keep the homepage open and launch tasks in new tabs, which is what I'd do if I wanted to do dozens of tasks in a go. The limit won't take effect until you refresh the homepage. (Could be verified by comparing the homepage token on those events, probably not worth the effort though.)

For Add image quality gate T293316: Add an image: minimal quality gate such limitation was specifically mentioned.

We know these specification are somewhat leaky, and that users might be able to do more than 25 image suggestions a day by opening many in multiple tabs or by changing their timezone around. These are described in more detail in T290788: Add an image: quality gates and we accept these leaks for Iteration 1.

For the Add link quality gate the above limitation is, de facto, in place too.

Change 752152 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] QualityGates: Enforce daily limit on server-side

https://gerrit.wikimedia.org/r/752152