Page MenuHomePhabricator
Create Task
Maniphest T308074

1.39.0-wmf.21 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.39.0-wmf.21
Release Date
Jul 18 2022, 12:00 AM

2022 week 29 1.39-wmf.21 Changes wmf/1.39.0-wmf.21

This MediaWiki Train Deployment is scheduled for the week of Monday, July 18th:

Monday July 18thTuesday, July 19thWednesday, July 20thThursday, July 21stFriday
Backports only.Branch wmf.21 and deploy to Group 0 Wikis.Deploy wmf.21 to Group 1 Wikis.Deploy wmf.21 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.21 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.39.0-wmf.20
Next: 1.39.0-wmf.22
SubjectRepoBranchLines +/-
all wikis to 1.39.0-wmf.21operations/mediawiki-configmaster+324 -324
group1 wikis to 1.39.0-wmf.21operations/mediawiki-configmaster+529 -529
Revert "group1 wikis to 1.39.0-wmf.19"operations/mediawiki-configmaster+529 -529
group1 wikis to 1.39.0-wmf.21operations/mediawiki-configmaster+529 -529
group0 wikis to 1.39.0-wmf.21operations/mediawiki-configmaster+128 -128
testwikis wikis to 1.39.0-wmf.21operations/mediawiki-configmaster+4 -4
Revert "group0 wikis to 1.39.0-wmf.21"operations/mediawiki-configmaster+128 -128
testwikis wikis to 1.39.0-wmf.21operations/mediawiki-configmaster+4 -4
group0 wikis to 1.39.0-wmf.21operations/mediawiki-configmaster+128 -128
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.May 10 2022, 9:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2022, 9:53 PM
thcipriani assigned this task to jeena.May 10 2022, 10:11 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: dancy.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Jdlrobson added a subtask: T312145: MassMessage using deprecated hook to add link to EditMassMessageList in sidebar.Jul 5 2022, 6:04 PM
matmarex closed subtask T312145: MassMessage using deprecated hook to add link to EditMassMessageList in sidebar as Resolved.Jul 5 2022, 9:34 PM
Dreamy_Jazz subscribed.EditedJul 7 2022, 9:53 PM

See T305093#8063451 - autogenerated LocalSettings.php included a empty string for $wgLocaltimezone by default. With https://gerrit.wikimedia.org/r/c/mediawiki/core/+/785387 it throws a PHP error if set to the empty string.

Krinkle subscribed.Jul 7 2022, 10:46 PM

@Dreamy_Jazz This task represents the current weekly production deployment of MediaWiki to Wikipedia.org and other WMF wikis. Afaik this does not relate to WMF deployments, does it?

For example, in wmf-config we set:

'wgLocaltimezone' => [
	'default' => 'UTC',
Dreamy_Jazz added a comment.EditedJul 7 2022, 10:47 PM

I wasn't sure if $wgLocaltimezone was always set on WMF wikis, but if it is then that shouldn't be an issue here.

RhinosF1 mentioned this in T312689: "Service Temporarily Unavailable" shows up when trying to add a new section/topic to a talk page on Beta cluster.Jul 9 2022, 7:23 AM
hashar added a subtask: T312689: "Service Temporarily Unavailable" shows up when trying to add a new section/topic to a talk page on Beta cluster.Jul 9 2022, 8:16 AM
taavi closed subtask T312689: "Service Temporarily Unavailable" shows up when trying to add a new section/topic to a talk page on Beta cluster as Resolved.Jul 9 2022, 1:22 PM
thcipriani updated Other Assignee, added: jnuche; removed: dancy.Jul 14 2022, 9:03 PM
daniel subscribed.EditedJul 16 2022, 11:54 AM
Risky Patch! 🚂🔥
Ladsgroup subscribed.Jul 17 2022, 12:19 AM
Dreamy_Jazz added a subtask: T313193: /wiki/Special:Contributions/172.18.0.1 Error: Call to a member function isRegistered() on null.Jul 17 2022, 10:30 PM
Dreamy_Jazz added a comment.Jul 17 2022, 10:40 PM

The above task has a patch and I've coordinated on IRC to get the fix deployed for this within the next few mins (just waiting for jenkins to run tests).

Dreamy_Jazz closed subtask T313193: /wiki/Special:Contributions/172.18.0.1 Error: Call to a member function isRegistered() on null as Resolved.Jul 17 2022, 11:08 PM
dom_walden added a subtask: T313220: Argument 1 passed to ManualLogEntry::setComment() must be of the type string, null given.Jul 18 2022, 12:57 PM
dom_walden subscribed.

I have raised T313220 as a blocking task. It could lead to more exceptions on production and it will prevent users from importing article.

Zabe subscribed.Jul 18 2022, 2:09 PM
TK-999 subscribed.Jul 18 2022, 8:34 PM
Urbanecm closed subtask T313220: Argument 1 passed to ManualLogEntry::setComment() must be of the type string, null given as Resolved.Jul 19 2022, 10:03 AM
Stashbot added a comment.Jul 19 2022, 4:14 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T16:14:56Z] <jhuneidi@deploy1002> Started scap: testwikis wikis to 1.39.0-wmf.21 refs T308074

Stashbot added a comment.Jul 19 2022, 4:23 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T16:23:24Z] <jhuneidi@deploy1002> Started scap: testwikis wikis to 1.39.0-wmf.21 refs T308074

gerritbot added a comment.Jul 19 2022, 4:25 PM

Change 815326 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815326

gerritbot added a project: Patch-For-Review.Jul 19 2022, 4:25 PM

Change 815326 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815326

Stashbot added a comment.Jul 19 2022, 4:28 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T16:28:22Z] <jhuneidi@deploy1002> Started scap: testwikis wikis to 1.39.0-wmf.21 refs T308074

Stashbot added a comment.Jul 19 2022, 5:46 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T17:46:54Z] <jhuneidi@deploy1002> Started scap: testwikis wikis to 1.39.0-wmf.21 refs T308074

Jdlrobson subscribed.EditedJul 19 2022, 5:49 PM

Vector 2022 layout changes (T312241)

Just a note to the train conductor for this week: We will be making some technical changes to Vector 2022 skin which impact layout. Will not impact any other skin. These are being done by config change, so this will not need to block or stop the train in any circumstance.

Stashbot added a comment.Jul 19 2022, 5:51 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T17:51:19Z] <jhuneidi@deploy1002> Finished scap: testwikis wikis to 1.39.0-wmf.21 refs T308074 (duration: 04m 24s)

Stashbot added a comment.Jul 19 2022, 6:08 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T18:08:27Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.39.0-wmf.21 refs T308074

gerritbot added a comment.Jul 19 2022, 6:11 PM

Change 815344 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815344

gerritbot added a comment.Jul 19 2022, 6:13 PM

Change 815344 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815344

jeena added a subtask: T313341: PHP Notice: Undefined property: Wikimedia\PSquare::$increments.Jul 19 2022, 6:25 PM
gerritbot added a comment.Jul 19 2022, 7:53 PM

Change 815372 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] Revert "group0 wikis to 1.39.0-wmf.21"

https://gerrit.wikimedia.org/r/815372

gerritbot added a comment.Jul 19 2022, 7:54 PM

Change 815372 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "group0 wikis to 1.39.0-wmf.21"

https://gerrit.wikimedia.org/r/815372

jeena added a comment.Jul 19 2022, 8:12 PM

https://gerrit.wikimedia.org/r/815277
Rolled back all wikis to wmf.19

Jdforrester-WMF closed subtask T313341: PHP Notice: Undefined property: Wikimedia\PSquare::$increments as Resolved.Jul 19 2022, 9:18 PM
gerritbot added a comment.Jul 19 2022, 9:30 PM

Change 815383 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] testwikis wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815383

gerritbot added a comment.Jul 19 2022, 9:31 PM

Change 815383 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815383

Stashbot added a comment.Jul 19 2022, 9:32 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T21:32:12Z] <jhuneidi@deploy1002> Started scap: testwikis wikis to 1.39.0-wmf.21 refs T308074

Stashbot added a comment.Jul 19 2022, 9:36 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T21:36:14Z] <jhuneidi@deploy1002> Finished scap: testwikis wikis to 1.39.0-wmf.21 refs T308074 (duration: 04m 02s)

gerritbot added a comment.Jul 19 2022, 9:40 PM

Change 815384 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815384

gerritbot added a comment.Jul 19 2022, 9:41 PM

Change 815384 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815384

Stashbot added a comment.Jul 19 2022, 9:45 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-19T21:45:36Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.39.0-wmf.21 refs T308074

colewhite subscribed.Jul 19 2022, 10:51 PM

Seeing an increased rate of warnings on the "session" channel since deployment:

Metadata merge failed: MediaWiki\\Session\\MetadataMergeException: Key \"rights\" changed in /srv/mediawiki/php-1.39.0-wmf.21/includes/session/SessionProvider.php:331
Stack trace:
#0 /srv/mediawiki/php-1.39.0-wmf.21/includes/session/SessionManager.php(678): MediaWiki\\Session\\SessionProvider->mergeMetadata(Array, Array)
#1 /srv/mediawiki/php-1.39.0-wmf.21/includes/session/SessionManager.php(546): MediaWiki\\Session\\SessionManager->loadSessionInfoFromStore(Object(MediaWiki\\Session\\SessionInfo), Object(WebRequest))
#2 /srv/mediawiki/php-1.39.0-wmf.21/includes/session/SessionManager.php(248): MediaWiki\\Session\\SessionManager->getSessionInfoForRequest(Object(WebRequest))
#3 /srv/mediawiki/php-1.39.0-wmf.21/includes/WebRequest.php(842): MediaWiki\\Session\\SessionManager->getSessionForRequest(Object(WebRequest))
#4 /srv/mediawiki/php-1.39.0-wmf.21/includes/session/SessionManager.php(169): WebRequest->getSession()
#5 /srv/mediawiki/php-1.39.0-wmf.21/includes/Setup.php(448): MediaWiki\\Session\\SessionManager::getGlobalSession()
#6 /srv/mediawiki/php-1.39.0-wmf.21/includes/WebStart.php(86): require_once('/srv/mediawiki/...')
#7 /srv/mediawiki/php-1.39.0-wmf.21/api.php(43): require('/srv/mediawiki/...')
#8 /srv/mediawiki/w/api.php(3): require('/srv/mediawiki/...')
#9 {main}

Note: these warnings are in the dlq-* indexes will not show up in the default logstash-* indexes. There is a type conflict with CentralAuth over the new_value key.

jeena mentioned this in T313426: Increased rate of warnings from MediaWiki\\Session\\MetadataMergeException.Jul 20 2022, 5:24 PM
gerritbot added a comment.Jul 20 2022, 6:08 PM

Change 815775 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815775

gerritbot added a comment.Jul 20 2022, 6:09 PM

Change 815775 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815775

Stashbot added a comment.Jul 20 2022, 6:12 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-20T18:12:57Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.39.0-wmf.21 refs T308074

Stashbot added a comment.Jul 20 2022, 6:16 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-20T18:16:05Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.39.0-wmf.21 refs T308074 (duration: 03m 07s)

jeena added a subtask: T313432: Error: Call to a member function getConfig() on null.Jul 20 2022, 6:41 PM
gerritbot added a comment.Jul 20 2022, 7:20 PM

Change 815792 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] Revert "group1 wikis to 1.39.0-wmf.21"

https://gerrit.wikimedia.org/r/815792

gerritbot added a comment.Jul 20 2022, 7:23 PM

Change 815792 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "group1 wikis to 1.39.0-wmf.19"

https://gerrit.wikimedia.org/r/815792

gerritbot added a comment.Jul 20 2022, 7:36 PM

Change 815793 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815793

gerritbot added a comment.Jul 20 2022, 7:38 PM

Change 815793 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/815793

taavi closed subtask T313432: Error: Call to a member function getConfig() on null as Resolved.Jul 20 2022, 7:41 PM
Stashbot added a comment.Jul 20 2022, 7:42 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-20T19:42:07Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.39.0-wmf.21 refs T308074

Stashbot added a comment.Jul 20 2022, 7:45 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-20T19:45:00Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.39.0-wmf.21 refs T308074 (duration: 02m 53s)

gerritbot added a comment.Jul 21 2022, 6:01 PM

Change 816024 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] all wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/816024

gerritbot added a comment.Jul 21 2022, 6:03 PM

Change 816024 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.39.0-wmf.21

https://gerrit.wikimedia.org/r/816024

Stashbot added a comment.Jul 21 2022, 6:07 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-21T18:07:12Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.39.0-wmf.21 refs T308074

brennen mentioned this in T313770: scap no longer restarts php-fpm on canary servers.Jul 25 2022, 9:06 PM
Stashbot added a comment.Jul 25 2022, 9:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-07-25T21:20:50Z] <brennen> running a no-op sync-world for T313770 to hopefully get 1.39.0-wmf.21 (T308074) to all servers.

dancy closed this task as Resolved.Aug 3 2022, 3:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL