Page MenuHomePhabricator
Create Task
Maniphest T332433

Update page editing features in MobileFrontend for IP masking
Closed, ResolvedPublic
Actions

Description

Required changes identified in our review on T327570:

And identified in Tim's initial review on T307054:

Details

SubjectRepoBranchLines +/-
editor: Update warning about logged-out editing for temp user creationmediawiki/extensions/MobileFrontendmaster+75 -25
editor: Handle temporary users when dealing with user preferencesmediawiki/extensions/MobileFrontendmaster+3 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 In ProgressNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 [Epic] Update features for temporary accounts
 ResolvedppelbergT326876 Update Editing Team-owned products that may be affected by temporary users
 ResolvedmatmarexT332433 Update page editing features in MobileFrontend for IP masking
 ResolvedmatmarexT332437 Change EditAttemptStep and other schemas and logging to support temp users
 ResolvedmatmarexT332438 Centralize EditAttemptStep logging code in WikimediaEvents
 ResolvedmatmarexT330338 [SPIKE] Determine what – if any – changes need to be made to editing-related schemas to handle temporary accounts
 DuplicateNoneT307054 [IP Masking] Temporary account mobile web support in editing workflow
 ResolvedmatmarexT335532 Expose IP masking (temporary user creation) configuration in the API
 ResolvedmatmarexT335530 New messages are needed for warnings about logged-out editing for IP masking
 ResolvedmatmarexT336001 Mobile post-edit notifications have two versions
 ResolvedmatmarexT338002 Let action=edit API instruct the client to redirect to another location after saving the edit
 ResolvedmatmarexT338003 Expose a method to display post-edit notification after reloading the page
 ResolvedBUG REPORTmatmarexT331397 Live preview returns IP address as signature
 ResolvedmatmarexT344879 Show the "Temporary user" popup with the post-edit notification if needed

Event Timeline

matmarex created this task.Mar 17 2023, 6:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2023, 6:56 PM
matmarex added a parent task: T326876: Update Editing Team-owned products that may be affected by temporary users.Mar 17 2023, 6:59 PM
matmarex mentioned this in T327570: [SPIKE] Document the changes IP Masking will require the Editing Team to make.
matmarex added a subtask: T332437: Change EditAttemptStep and other schemas and logging to support temp users.Mar 17 2023, 7:09 PM
matmarex added a subtask: T307054: [IP Masking] Temporary account mobile web support in editing workflow.Mar 17 2023, 7:14 PM
matmarex added a project: Temporary accounts.Mar 23 2023, 3:21 PM
matmarex updated the task description. (Show Details)Apr 11 2023, 8:19 PM
matmarex closed subtask T332437: Change EditAttemptStep and other schemas and logging to support temp users as Resolved.Apr 18 2023, 7:31 PM
matmarex mentioned this in T335530: New messages are needed for warnings about logged-out editing for IP masking.Apr 27 2023, 7:17 PM
gerritbot added a comment.Apr 27 2023, 11:45 PM

Change 913001 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Update warning about logged-out editing for temp user creation

https://gerrit.wikimedia.org/r/913001

gerritbot added a project: Patch-For-Review.Apr 27 2023, 11:45 PM
matmarex claimed this task.Apr 27 2023, 11:51 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.
matmarex moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.
matmarex added a subtask: T335532: Expose IP masking (temporary user creation) configuration in the API.Apr 28 2023, 1:56 AM
matmarex updated the task description. (Show Details)Apr 28 2023, 1:58 AM
matmarex updated the task description. (Show Details)Apr 28 2023, 2:07 PM
matmarex mentioned this in T307054: [IP Masking] Temporary account mobile web support in editing workflow.Apr 28 2023, 2:25 PM
matmarex merged a task: T307054: [IP Masking] Temporary account mobile web support in editing workflow.
matmarex updated the task description. (Show Details)
matmarex added subscribers: tstarling, ovasileva, Masumrezarock100 and 12 others.
gerritbot added a comment.Apr 28 2023, 3:15 PM

Change 913201 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] editor: Handle temporary users when dealing with user preferences

https://gerrit.wikimedia.org/r/913201

matmarex updated the task description. (Show Details)Apr 28 2023, 3:15 PM
matmarex updated the task description. (Show Details)Apr 28 2023, 3:46 PM
matmarex added a subtask: T335530: New messages are needed for warnings about logged-out editing for IP masking.Apr 28 2023, 6:25 PM
matmarex moved this task from Backlog to Team:Editing on the MobileFrontend board.
matmarex updated the task description. (Show Details)Apr 28 2023, 6:27 PM
matmarex closed subtask T335532: Expose IP masking (temporary user creation) configuration in the API as Resolved.May 2 2023, 8:28 PM
matmarex added a subtask: T336001: Mobile post-edit notifications have two versions.May 4 2023, 7:59 PM
matmarex updated the task description. (Show Details)May 4 2023, 8:32 PM
gerritbot added a comment.May 5 2023, 11:09 PM

Change 913201 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] editor: Handle temporary users when dealing with user preferences

https://gerrit.wikimedia.org/r/913201

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 1:02 PM
matmarex closed subtask T336001: Mobile post-edit notifications have two versions as Resolved.May 17 2023, 4:11 PM
gerritbot added a comment.May 19 2023, 2:51 PM

Change 913001 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] editor: Update warning about logged-out editing for temp user creation

https://gerrit.wikimedia.org/r/913001

Maintenance_bot removed a project: Patch-For-Review.May 19 2023, 3:10 PM
matmarex added subtasks: T338002: Let action=edit API instruct the client to redirect to another location after saving the edit, T338003: Expose a method to display post-edit notification after reloading the page.Jun 2 2023, 12:01 AM
matmarex closed subtask T335530: New messages are needed for warnings about logged-out editing for IP masking as Resolved.Jun 5 2023, 5:34 PM
ppelberg closed subtask T338003: Expose a method to display post-edit notification after reloading the page as Resolved.Jul 7 2023, 11:33 PM
matmarex added a subtask: T331397: Live preview returns IP address as signature.Jul 10 2023, 10:43 PM
matmarex updated the task description. (Show Details)Aug 1 2023, 6:17 PM
ppelberg mentioned this in T344468: QA Editing-related IP Masking changes.Aug 17 2023, 10:23 PM
ppelberg closed subtask T338002: Let action=edit API instruct the client to redirect to another location after saving the edit as Resolved.
ppelberg added a project: Goal.Aug 22 2023, 7:48 PM
matmarex added a subtask: T344879: Show the "Temporary user" popup with the post-edit notification if needed.Aug 24 2023, 2:20 AM
matmarex moved this task from Doing to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 30 2023, 2:43 PM
matmarex added a project: Skipped QA.Sep 9 2023, 11:53 PM
ppelberg closed subtask T344879: Show the "Temporary user" popup with the post-edit notification if needed as Resolved.Sep 15 2023, 5:40 AM
Ryasmeen edited projects, added Verified; removed Skipped QA.Nov 8 2023, 2:41 AM
VPuffetMichel closed this task as Resolved.Dec 4 2023, 6:57 PM
VPuffetMichel closed subtask T331397: Live preview returns IP address as signature as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits