• Per input from @JTannerWMF and @SNowick_WMF – I added the "Save changes?" dialog in step 9
• Per @Dbrant’s input, I updated step 10 to reflect that we’re showing a WebView instead of a native preview

Moving this task to "Ready for dev" now ✅

CC @HNordeenWMF

@scblr for #9, since the user started the message from scratch, shouldn't the save dialog only have one option? (Save as new message)

@HNordeenWMF I took the liberty of splitting off a task (T358898) specifically for building the "preview" portion of this workflow. That will be a substantial amount of work on its own, and is pretty independent of the Template-addition workflow.

@Dbrant sounds good, thank you!

In T355141#9581858, @HNordeenWMF wrote:

@scblr for #9, since the user started the message from scratch, shouldn't the save dialog only have one option? (Save as new message)

Exactly, I added it to the task’s description 👍

thanks @scblr !
@Dbrant I'll try to repeat a question I received: If a user creates a custom saved message that references a template, and saves it into their list of saved messages, the next time they use that saved message, will the template populate as the most recent version of itself?

In T355141#9603215, @HNordeenWMF wrote:

@Dbrant I'll try to repeat a question I received: If a user creates a custom saved message that references a template, and saves it into their list of saved messages, the next time they use that saved message, will the template populate as the most recent version of itself?

Yes; saved messages are just wikitext, so any templates that are in the message will be unparsed {{template}} references, and will only be parsed when actually posting to a talk page.

Hi @scblr

In the #6 design, all the input fields seem to be required (or optional), do you think we should have a design that indicates different types of parameter?

For example:

{{Template: Blockquote}} has three different types of parameters: required, suggested, and optional

Good catch, @cooltey, and yes, please! Can you indicate optional fields in the same way as in the "Create an account" screen?

Thanks!

Hi @scblr

The implementation is completed. Please download the APK from the ticket description, thanks!

Thanks @cooltey. This looks polished already – great work! 👏

1) Can we display the same information as on the web when there’s no template data?

Implementation	vs	Web

• For the text in italics, please use the existing text design from #6 in the task description (Figma)
• For the contents in the orange box, please reuse the designs for the talk page coffee rolls (T310801 | Figma)

2) Same goes for templates that have template data. Any chance of fetching this information?

Implementation	vs	Design	vs	Web

3) Please remove this border/line:

4) Save changes dialog:

Implementation	vs	Design

• Please make sure to use all updated labels and placeholders from Figma
• Save as message and Update existing message (radios) use h3-button not h3 (maybe it’s faux bold?)

5) Can this link open in-app instead of the browser (as a web view)?

{F42723578}

Hi @scblr

Please download the APK to see the changes, thanks!

In T355141#9637250, @scblr wrote:

Thanks @cooltey. This looks polished already – great work! 👏

1) Can we display the same information as on the web when there’s no template data?

Sure!

2) Same goes for templates that have template data. Any chance of fetching this information?

Fixed.

3) Please remove this border/line:

Done.

4) Save changes dialog:

Talked to @Sharvaniharan and this will be included in her PR. If not, I can help to do it.

5) Can this link open in-app instead of the browser (as a web view)?

If we use the CustomTab (open in-app) to open the Template:[name] page, it will open it in another variant of the app. For example, if you installed Beta and Production on your device, you will open the Template:[name] page in the beta app when you tap on the link in the production app.

I would recommend to open the link in an external browser.

@cooltey, this all looks good!

I will add a comment for this 👇

4) Save changes dialog:

Implementation	vs	Design

• Please make sure to use all updated labels and placeholders from Figma
• Save as message and Update existing message (radios) use h3-button not h3 (maybe it’s faux bold?)

... to T356774 👍

dbrant closed https://github.com/wikimedia/apps-android-wikipedia/pull/4521

dbrant closed https://github.com/wikimedia/apps-android-wikipedia/pull/4521

dbrant opened https://github.com/wikimedia/apps-android-wikipedia/pull/4546

dbrant opened https://github.com/wikimedia/apps-android-wikipedia/pull/4547

cooltey closed https://github.com/wikimedia/apps-android-wikipedia/pull/4547

cooltey closed https://github.com/wikimedia/apps-android-wikipedia/pull/4546

Testing on 2.7.50480-beta-2024-03-27 on test.wiki

After tapping publish, the user is returned to the messages pages and not the edit page.

Steps to Reproduce:
Navigate to edit patrol

1. Choose an edit
2. Tap on Talk (Note - on Test.wiki, using an anon account, I do not see a warn icon, only a talk icon)
3. Tap examples tab
4. Tap an example message
5. Tap Next
6. Tap Publish

Expected Result:
After tapping publish, the initial edit page appears

Actual:
After tapping publish, the list of example messages appears

@scblr I was a little confused about the text on this dialog. I was not sure if selecting the bottom radio would mean that the example message would be updated and saved. After publishing the message, I understood that my changes were sent in a one-time message. I'm not sure if the text "update existing message" makes sense in this context. Perhaps something like "send this message with your changes" might be better, but that is a lot of text. Perhaps even reworking the dialog to just say: Save as new message or send as is or cancel

@ABorbaWMF, great catch!

The behavior should be as follows after tapping 'Talk' (previously 'Warn') on the main Edit Patrol screen:

1) Both custom and example messages:

• If no changes are made to a custom or example message, no dialog at all should be shown. The user is taken to the preview step.

2) Example messages:

• If changes are made to an example message, the following dialog is shown:

Since the radio contains only one option now, we could further simplify it to:

3) Custom messages:

• If changes are made to a custom message, the following dialog should be shown:

Tagging @HNordeenWMF for transparency, as she contacted me yesterday with a similar question.

@Dbrant, could you make sure the behavior described is implemented? Thanks!

dbrant opened https://github.com/wikimedia/apps-android-wikipedia/pull/4566

cooltey closed https://github.com/wikimedia/apps-android-wikipedia/pull/4566

In T355141#9671572, @ABorbaWMF wrote:

Testing on 2.7.50480-beta-2024-03-27 on test.wiki
Expected Result:
After tapping publish, the initial edit page appears

Actual:
After tapping publish, the list of example messages appears

fixed!

I was a little confused about the text on this dialog.

done!

Looking good on 2.7.50481-beta-2024-04-01

Such a cool addition!