7. Preview

Does this screenshot mean that the links will be autonumbered external links? These should be avoided if possible: they look ugly and has accessibility issues. I’d write

Hello Cooltey, I want to let you know I’ve reverted [https://en.wikipedia.org/w/index.php?title=Types_of_volcanic_eruptions&diff=1198780028&oldid=1195211737 one or more of your recent contributions] because they do not seem constructive. If you think I made a mistake, or have questions, you can leave a message on my talk page: [[User talk:Sclbr]]. Please note that continued vandalism may lead to restrictions.

Hi @Tacsipacsi, great suggestion - thank you!
@scblr is planning to ensure that the linked text is used instead of the full url, and update the mockup.

Hi @scblr

I have a few questions as I started implementing:

a) On screen 2, I see on figma that the title style is h3-button but when I implement it looks more like h3. Could you please confirm.
b) Looks like, from the designs, that we have removed the title from messages. Every message has a subject and message, but no longer, the title. This is a very welcome change and easier to manage. However, that means we will need to remove the need to add a title on 6. Please confirm this, so I can remove titles.
c) Need the Learn about message placeholders url
d) Minor: Noting that we upgraded license text on 7 to CC-BY-SA 4.0 license and not 3.0

Thank you :)

Just a note that the job of building the Preview screen was broken out into its own task (T358898), and it's been agreed that it will be a WebView-based preview, that need not match the native presentation that we show in our Talk activities. (T355141#9571761)

@Sharvaniharan

a) On screen 2, I see on figma that the title style is h3-button but when I implement it looks more like h3. Could you please confirm.

Please go with h3-button button here

b) Looks like, from the designs, that we have removed the title from messages. Every message has a subject and message, but no longer, the title. This is a very welcome change and easier to manage. However, that means we will need to remove the need to add a title on 6. Please confirm this, so I can remove titles.

Yes, exactly; we removed this to make it more straightforward. Any ideas on how we could migrate users that have a title and a subject? I suggest to simply remove titles as the subject will be self-explanatory. Thoughts?

c) Need the Learn about message placeholders URL

There’s none yet, @HNordeenWMF any chance you could create an FAQ page (or section of an FAQ) on MediaWiki for this? Content to be defined.

d) Minor: Noting that we upgraded license text on 7 to CC-BY-SA 4.0 license and not 3.0

Good catch! Thanks

We can plan to add the Message Placeholder information here: https://www.mediawiki.org/wiki/Wikimedia_Apps/Android_Suggested_edits#Message_placeholders

In T356774#9601444, @HNordeenWMF wrote:

We can plan to add the Message Placeholder information here: https://www.mediawiki.org/wiki/Wikimedia_Apps/Android_Suggested_edits#Message_placeholders

@Sharvaniharan here’s the URL for c)

b) Looks like, from the designs, that we have removed the title from messages. Every message has a subject and message, but no longer, the title. This is a very welcome change and easier to manage. However, that means we will need to remove the need to add a title on 6. Please confirm this, so I can remove titles.

Yes, exactly; we removed this to make it more straightforward. Any ideas on how we could migrate users that have a title and a subject? I suggest to simply remove titles as the subject will be self-explanatory. Thoughts?

I completely agree @scblr. Let us remove the necessity for title on that screen and any other prompts or displays of a title for the messages. When you review the final version, if you feel otherwise we can always add it back. My instinct is that we will not miss it :-)

To answer the how to migrate users aspect of it, we do not need to do much there, behind the scenes existing messages will have titles that were given to them, and newly created ones will just have an empty message, and since we will never use it, it will not matter. We will just let that unused column just exist on the db.

Hi @scblr

Minor question:

In this screen : https://www.figma.com/file/cJmB34iJE5p8qbqrQWnE50/Android-%E2%86%92-Edit-Patrol-%E2%86%92-T322083?type=design&node-id=3988-320916&mode=design&t=hDu4x3G0BXDeEE94-0

Is the Use an example message below to customize, send and save to your messages. textview part of the list? As-in, does it scroll up when the user scrolls the list, or is it fixed?
Thank you.

Good question @Sharvaniharan — but I think it should be part of the list, therefore not fixed.

@Sharvaniharan here are the UI translations for the new changes to the flow via Robin & design research.

Hi @scblr ,
This is ready for review. However few things I wanted to highlight:

• The swipe and delete is showing up on the example messages tab, which I need to discuss with other engineers about the best way to remove. So please ignore this during review. Resolved in latest build. please update before testing.
• When we enter the saved messages from the menu [Template management mode] - When user clicks on an Example message, if they click save, it gets saved as a new message in the Your messages list.. I feel like other than back-press, there is no choice for them to not save that message. Also related to this is that they can save the same message many times. Should we prevent duplicates based on subject?
• When the user enters from More menu -> Talk - since we have intriduces the preview screen through the saved messages work, we show license text in preview mode just before publish, but I have hidden Learn about message placeholders link below the compose area, since this is not in the patrolling mode. - Just wanted to flag it so you can okay the new look to talk response screen.

APK: https://github.com/wikimedia/apps-android-wikipedia/pull/4483/checks

Thank you :-)

In T356774#9636570, @Sharvaniharan wrote:

Should we prevent duplicates based on subject?

Someone may want to have several messages with the same subject but different bodies (e.g. differently detailed explanation for users with different experience levels, or formal and informal addressing in languages that differentiate between them). Maybe it wasn’t that great idea to remove titles…

@Sharvaniharan – great work so far! 👏

1) Should we prevent duplicates based on the subject?

Yes, I think so. I suggest the Material 3 way of error handling with an icon and this supporting text: Subject name already exists. Try a different one.

Let’s also discuss @Tacsipacsi’s input in our check-in tonight with the team (thanks for that!).

2) If no changes are made to the subject and the message, the 'Save changes' dialog should not be shown, and users should be taken directly to the 'Preview' step.

3) The Preview step is currently showing me this, e.g. when the 'Vandalism warning' message has been chosen:

4) The letter spacing in the Subject text field is off, and different from Compose message. I’m unsure what type settings are applied there, could you investigate? It should be using the p type variable without any modifications (cc @cooltey).

5)

but I have hidden Learn about message placeholders link below the compose area, since this is not in the patrolling mode

Great catch, and it looks good to me.

6) From T355141, please fix this (cc @cooltey):

Save changes dialog:

Implementation	vs	Design

• Please make sure to use all updated labels and placeholders from Figma
• Save as message and Update existing message (radios) use h3-button not h3 (maybe it’s faux bold?)

Hi @scblr

I have fixed 1), 2) and 4)

For 1) :
Also updated one other scenario in which the error text should be shown. When a user taps warm and taps on an existing message and changes the message text, which takes them to the save dialog, if they choose Save as a new message, we need to ask them to change the title. So I have added logic to carry over the title from reply screen to the dialog and show error message so user can change the title. If they then happen to choose Update existing message then, error text will be removed.

3. The Preview step is currently showing me this, e.g. when the 'Vandalism warning' message has been chosen:

I am able to see the preview correctly. Could you please check this again on the latest version, and meanwhile I will look closer if this can happen on an edge case.

6. From T355141, please fix this (cc @cooltey):

I have changed the style to h3-button and re-introduced the Subject input field.

Looks good @Sharvaniharan. Question regarding updates to the view. I noticed that when you save a new message and go back, the message does not appear in the "Your message" list immediately. Can we make sure the view updates once users tap "Save" ? Here’s a video that shows it:

https://www.dropbox.com/scl/fi/d386ohi5xtn2559nlqf23/screen-20240320-183431.mp4?rlkey=0vgnm8oe464ewrbcoorr8r6i3&dl=0

Good catch @scblr ! :-)
Here is the fix:
https://youtube.com/shorts/I9kCzTe-DXA

Thank you!

In T356774#9636955, @Tacsipacsi wrote:

In T356774#9636570, @Sharvaniharan wrote:

Should we prevent duplicates based on subject?

Someone may want to have several messages with the same subject but different bodies (e.g. differently detailed explanation for users with different experience levels, or formal and informal addressing in languages that differentiate between them). Maybe it wasn’t that great idea to remove titles…

Thanks for raising this @Tacsipacsi! I wrote up a ticket addressing this, using your examples as user stories T360481. It's a "nice-to-have" for the upcoming release, but if we hear more feedback/requests for this functionality as more people begin to use the tool, we will prioritize it accordingly.

In T356774#9647524, @Sharvaniharan wrote:

Good catch @scblr ! :-)
Here is the fix:
https://youtube.com/shorts/I9kCzTe-DXA

Thank you!

Cool, it looks good to me now – moving it to the next column. I’d appreciate @ABorbaWMF’s eye and skills to test a few more "new message and save" scenarios! 🙌

dbrant opened https://github.com/wikimedia/apps-android-wikipedia/pull/4551

cooltey closed https://github.com/wikimedia/apps-android-wikipedia/pull/4551

Hi @Dbrant and @ABorbaWMF, I came across a few issues with Saving while using the feature today:

• If you start a completely new message, you are prompted with both "Save as a new message" and "Update existing message". We should only be displaying the options for "Save as a new message" / "Don't save"
• If you start from an example message and make an edit, similarly you see both "Save as new message" and "Update existing message", but you cannot update the example message. We should only display the options for "Save as new message" / "Don't save" in this case.

Apologies, this was detailed in the task at some point but was removed, I'll add it back in.

dbrant opened https://github.com/wikimedia/apps-android-wikipedia/pull/4564

Another quick note on this one. I believe there is an issue with the example message flow as well. Steps below:

Steps to Reproduce:

1. Navigate to edit patrol
2. Choose an edit
3. Tap on Talk (Note - on Test.wiki, using an anon account, I do not see a warn icon, only a talk icon)
4. Tap examples tab
5. Tap an example message
6. Tap Next
7. Tap Publish

Expected Result:
After tapping publish, the initial edit page appears

Actual:
After tapping publish, the list of example messages appears

dbrant opened https://github.com/wikimedia/apps-android-wikipedia/pull/4566

cooltey closed https://github.com/wikimedia/apps-android-wikipedia/pull/4566

cooltey closed https://github.com/wikimedia/apps-android-wikipedia/pull/4564

In T356774#9671554, @ABorbaWMF wrote:

Expected Result:
After tapping publish, the initial edit page appears

Actual:
After tapping publish, the list of example messages appears

fixed!

Appears to be fixed on 2.7.50481-beta-2024-04-01

I've filed a nice-to-have task separately to improve the positioning of the snackbars to match designs, as I noticed that slowed me down a bit while trying to take multiple actions on an edit: T361646.