Page MenuHomePhabricator

dir attribution on <references/> is ignored.
Open, NormalPublic

Description

http://parsoid-lb.eqiad.wikimedia.org/fawiki/%DA%A9%D8%A7%D8%B1%D8%A8%D8%B1%3AEbraminio%2Fpdf?oldid=13406924

The <references /> block at the end is left to right when it should be right to left as the page content. On fa.wiki they worked around it by manually specifying the directionality.

This also affects PDF rendering


Version: unspecified
Severity: major

Details

Reference
bz71804

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz71804.
bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Oct 8 2014, 3:23 PM
cscott added a comment.Oct 8 2014, 3:25 PM

Does the PHP citation extension emit a dir attribute?

cscott added a comment.Oct 8 2014, 3:33 PM

Parsoid and PHP both emit 'dir=LTR' around the references, which is correct. But the PDF renderer seems to lose this.

Per comment 2, bug 43235 is not a blocker; moreover, I think it was meant as blocker of bug 71805.

Amire80 triaged this task as Normal priority.Jul 16 2015, 4:30 PM
Amire80 set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2015, 4:30 PM
Huji added a subscriber: Huji.Jul 17 2015, 1:52 AM

I'm sorry but I don't see what the problem is here. The bug states that the references section should be RTL; but when you check the source of the page at https://fa.wikipedia.org/wiki/%DA%A9%D8%A7%D8%B1%D8%A8%D8%B1:Ebraminio/pdf you will notice that it actually requires to be LTR, per the parameters used in this template:

{{پانویس|چپ‌چین=بله}}

So what is the problem?

Ebraminio added a comment.EditedJul 17 2015, 9:48 AM

<reference /> doesn't support dir attribute so we do local workaround for it but PDF output can't understand it. So <reference /> should understand dir="" or PDF creator should detect the effectively direction with some more sophisticated solution.

Ebraminio moved this task from Backlog to PDF on the RTL board.Aug 9 2015, 11:23 AM

As already announced in Tech News, OfflineContentGenerator (OCG) will not be used anymore after October 1st, 2017 on Wikimedia sites. OCG will be replaced by Electron. You can read more on mediawiki.org.

Amire80 moved this task from Untriaged to RTL on the I18n board.Feb 28 2018, 12:29 PM