Page MenuHomePhabricator

Add watchlist to app
Open, LowPublic

Description

Currently, a user can't access the watchlist out of the app. This should be fixed so users can save and revisit a page they saved on another device.

Please see the mobile apps page for the hackathon for more details in general in case you're interested in working this at the hackathon.

Details

Related Gerrit Patches:
apps/android/wikipedia : masterAdd watchlist functionality.

Event Timeline

Florian created this task.Dec 6 2014, 10:43 PM
Florian assigned this task to Deskana.
Florian raised the priority of this task from to Normal.
Florian updated the task description. (Show Details)
Florian changed Security from none to None.
Florian added a subscriber: Florian.

Change 166274 had a related patch set uploaded (by Florianschmidtwelzow):
Add watchlist functionality.

https://gerrit.wikimedia.org/r/166274

Patch-For-Review

Krenair renamed this task from Add watchlist to Android App to Add watchlist to app.Dec 6 2014, 11:05 PM

Change 166274 abandoned by Deskana:
Add watchlist functionality.

Reason:
It's going to take a lot of work to get this to the stage where it's really a useful product. Abandoning for now.

https://gerrit.wikimedia.org/r/166274

Deskana added a comment.EditedFeb 25 2015, 5:59 AM

The above patch got this to the state where it could fetch the most recent changes from a user's watchlist and display it as a list of pages to the user. The main problem is that the app doesn't have any kind of diff viewing framework, so it would just dump the user onto the page in question.

That's the major bit of outstanding work here; either a diff-viewing framework needs to be made from scratch, or an open source library found that provides that functionality.

There was also some under the hood and technical work remaining to be done. First the patch needs to be unabandoned and rebased. Then we should make the WatchlistFragment implement an onSaveInstanceState method that writes out the state to a bundle. That way, if the activity is paused or stopped by the OS, it could be resumed sensibly from the savedInstanceState bundle without having to actually restart the activity from scratch and double the network requests. This would also increase the user consistency, since the user wouldn't randomly get different results just because they minimised the app and opened it again.

Qgil added a subscriber: Qgil.
KLans_WMF lowered the priority of this task from Normal to Low.Apr 27 2015, 9:52 PM
dr0ptp4kt updated the task description. (Show Details)May 7 2015, 5:27 PM
Qgil added a comment.May 24 2015, 9:04 PM

Just checking, is this task being worked in Lyon and is @Deskana its owner?

No answer, so I assume no work was done on this task during the hackathon. If this is wrong, please update accordingly.

Deskana removed Deskana as the assignee of this task.Jul 27 2015, 6:07 PM

Hi @Florian , @Deskana

I am willing to take this up in the upcoming hackathon (provided I get through the scholarship grant :) ).

It'd be great if you could provide me some pointers to how to get started on this, so that I have enough context before the event starts.

I see that a changeset is already here but has been abaondoned. Is it in a ready-to-patch state?

Hey @yashasvi! I've not been involved with the mobile apps for a few years now, so you should probably ask @Charlotte and @Dbrant for their input.

In terms of the code that I wrote three years ago, I highly doubt it's useful any more since the app will have changed a lot in those years. Starting from scratch would probably better. :-)

Qgil removed a subscriber: Qgil.Feb 27 2018, 12:29 PM

Hey @yashasvi! I've not been involved with the mobile apps for a few years now, so you should probably ask @Charlotte and @Dbrant for their input.
In terms of the code that I wrote three years ago, I highly doubt it's useful any more since the app will have changed a lot in those years. Starting from scratch would probably better. :-)

Hi @Deskana ,

Thanks for the quick turnaround. I understand your point on starting from scratch :) .

@Dbrant ,

it'd be great if you could point me in right direction here.

Dbrant added a comment.Mar 2 2018, 3:51 PM

@yashasvi Since you've claimed T166903, let's make sure it's completed before delving into this.

@yashasvi Since you've claimed T166903, let's make sure it's completed before delving into this.

Sure @Dbrant , that seems like a good approach.

JMinor added a subscriber: JMinor.May 31 2019, 6:20 PM

Related to reading list update/freshness, design here: T76953