| Krinkle | |
| Feb 13 2015, 8:07 AM |
| F29316124: Screenshot 2019-06-02 at 15.18.54.png | |
| Jun 2 2019, 1:24 PM |
This is a medium to long term perspective. Our unit tests should not require MediaWiki to be installed.
It may or may not need a database to connect to (though to a large degree that should be mocked). But that can be passed as command line arguments. Anything else should be constructed/injected by the test or mocked.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | kostajh | T89432 Make PHPUnit tests run without installing MediaWiki | |||
| Open | None | T87781 Split mediawiki tests into unit and integration tests | |||
| Duplicate | None | T223968 Split Wikibase tests into unit and integration tests | |||
| Resolved | kostajh | T226911 Support running unit tests and extending MediaWikiUnitTestCase in skins and extensions | |||
| Declined | BUG REPORT | None | T229220 Unit tests are not being run for extensions under PHPUnit 4.x (HHVM) | ||
| Declined | None | T234721 Provide an alternative way to use MediaWikiUnitTestCase for tests not in unit/ |
I have raised the subject to the MediaWiki core team list at https://lists.wikimedia.org/pipermail/mediawiki-core/2015-February/000147.html and filled T87781 now a blocker.
I think there's work that could be learned from in https://github.com/drupal/drupal/blob/8.8.x/core/tests/TestSuites/TestSuiteBase.php#L39 and https://github.com/drupal/drupal/blob/8.8.x/core/tests/bootstrap.php
Not sure how much of help I could be personally, but I could at least provide some cheering on this one!
dumping a reference here so I am able to find in the future
https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/511074/ (and the related commit in Wikibase https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/511076/ ) is some result of my lame attempt at the Prague Hackathon to get some PHPUnit tests of Wikibase running without loading MediaWiki. I've been doing this with the intention to try out parallelizing the unit test run, hoping for some speed improvements on multi-CPU machines.
All really hacky and not fully functional, probably for really keen enthusiasts only.
Change 513106 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] [WIP/PoC]: Separate MediaWiki unit and integration tests
This should be ready to move forward. I've updated the branch to split proper unit tests into their dedicated suite. 5301 unit tests can now be run from your IDE in less than 5 seconds! :)
Here's what integration with Intellij's PHPUnit execution and coverage display looks like:
Change 513106 merged by Jforrester:
[mediawiki/core@master] Separate MediaWiki unit and integration tests
Change 517550 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] Introduce separate unit tests PHPUnit configuration
Change 517550 merged by jenkins-bot:
[mediawiki/core@master] Introduce separate unit tests PHPUnit configuration
Change 517701 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] Move trivially compatible tests to the unit tests suite
Change 519165 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] Unit tests: prevent access to global functions and variables
Change 519165 merged by jenkins-bot:
[mediawiki/core@master] Define unit and integration test suites
Change 517701 merged by jenkins-bot:
[mediawiki/core@master] Move trivially compatible tests to the unit tests suite