Page MenuHomePhabricator
Feed Advanced Search

Fri, Apr 12

Dreamy_Jazz merged task T362383: CkeckUser and/or WikimediaEvents block CI for unrelated codebases into T362325: HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait..
Fri, Apr 12, 8:42 AM · MediaWiki-extensions-WikimediaEvents, Move-Files-To-Commons, CheckUser, ci-test-error

Thu, Apr 11

Dreamy_Jazz added a subtask for T361139: Normalise the user agent column in CheckUser result tables: T361928: Update mediawiki.org pages for schema changes made by adding the cu_useragent table.
Thu, Apr 11, 7:08 PM · Epic, Trust and Safety Product Team, CheckUser
Dreamy_Jazz added a parent task for T361928: Update mediawiki.org pages for schema changes made by adding the cu_useragent table: T361139: Normalise the user agent column in CheckUser result tables.
Thu, Apr 11, 7:08 PM · Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Documentation, CheckUser
Dreamy_Jazz added a parent task for T359312: Create cu_useragent table: T361928: Update mediawiki.org pages for schema changes made by adding the cu_useragent table.
Thu, Apr 11, 7:07 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Schema-change, Data-Persistence (work done), Trust and Safety Product Team, CheckUser
Dreamy_Jazz added a subtask for T361928: Update mediawiki.org pages for schema changes made by adding the cu_useragent table: T359312: Create cu_useragent table.
Thu, Apr 11, 7:07 PM · Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Documentation, CheckUser
Dreamy_Jazz merged task T362342: LogicException: Either title and namespace, or page must be set in the row. into T362284: Logs without a defined title or page_id cause an exception in CheckUser.
Thu, Apr 11, 3:18 PM · CheckUser, Wikimedia-production-error
Dreamy_Jazz merged T362342: LogicException: Either title and namespace, or page must be set in the row. into T362284: Logs without a defined title or page_id cause an exception in CheckUser.
Thu, Apr 11, 3:18 PM · Wikimedia-production-error, MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, MW-1.42-release
Dreamy_Jazz moved T347102: Alias column names in Special:Investigate to not include the "cuc_" prefix from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Thu, Apr 11, 2:47 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Patch-For-Review, Trust and Safety Product Team, CheckUser
Dreamy_Jazz edited projects for T347102: Alias column names in Special:Investigate to not include the "cuc_" prefix, added: Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team; removed Anti-Harassment.
Thu, Apr 11, 2:46 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Patch-For-Review, Trust and Safety Product Team, CheckUser
Dreamy_Jazz renamed T346022: Remove wgCheckUserLogAdditionalRights from How does wgCheckUserLogAdditionalRights affect read new for event table migration to Remove wgCheckUserLogAdditionalRights.
Thu, Apr 11, 2:25 PM · Anti-Harassment, CheckUser
Dreamy_Jazz closed T362284: Logs without a defined title or page_id cause an exception in CheckUser as Resolved.
Thu, Apr 11, 2:12 PM · Wikimedia-production-error, MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, MW-1.42-release
Dreamy_Jazz closed T362284: Logs without a defined title or page_id cause an exception in CheckUser, a subtask of T360158: 1.42.0-wmf.26 deployment blockers, as Resolved.
Thu, Apr 11, 2:11 PM · Patch-For-Review, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
Dreamy_Jazz closed T362325: HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait. as Resolved.
Thu, Apr 11, 1:40 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, Patch-For-Review, MediaWiki-extensions-WikimediaEvents, CheckUser, ci-test-error (WMF-deployed Build Failure)
Dreamy_Jazz moved T362325: HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait. from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Thu, Apr 11, 1:28 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, Patch-For-Review, MediaWiki-extensions-WikimediaEvents, CheckUser, ci-test-error (WMF-deployed Build Failure)
Dreamy_Jazz added projects to T362325: HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait.: Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)).
Thu, Apr 11, 1:27 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, Patch-For-Review, MediaWiki-extensions-WikimediaEvents, CheckUser, ci-test-error (WMF-deployed Build Failure)
Dreamy_Jazz assigned T362325: HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait. to STran.
Thu, Apr 11, 1:27 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, Patch-For-Review, MediaWiki-extensions-WikimediaEvents, CheckUser, ci-test-error (WMF-deployed Build Failure)
Dreamy_Jazz updated the task description for T324907: Create separate tables for log events in CheckUser.
Thu, Apr 11, 1:14 PM · Trust and Safety Product Team, Epic, MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Patch-For-Review, Schema-change, CheckUser
Dreamy_Jazz updated the task description for T324907: Create separate tables for log events in CheckUser.
Thu, Apr 11, 1:13 PM · Trust and Safety Product Team, Epic, MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Patch-For-Review, Schema-change, CheckUser
Dreamy_Jazz added a comment to T362325: HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait..

Looks to be caused by:

  1. PopulateCheckUserTablesWithSimulatedDataTest calls createRegisteredUser to test it
  2. That method generates a registered username and causes an autocreation for that username
  3. That causes IPReputationHooks::onLocalUserCreated to be called
  4. That tries to make a request to the IPoid service (which does not exist in CI)
  5. That request fails because the request was tried using a NullHttpRequestFactory.
Thu, Apr 11, 12:55 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, Patch-For-Review, MediaWiki-extensions-WikimediaEvents, CheckUser, ci-test-error (WMF-deployed Build Failure)
Dreamy_Jazz updated the task description for T362325: HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait..
Thu, Apr 11, 12:44 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, Patch-For-Review, MediaWiki-extensions-WikimediaEvents, CheckUser, ci-test-error (WMF-deployed Build Failure)
Dreamy_Jazz added projects to T362325: HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait.: CheckUser, MediaWiki-extensions-WikimediaEvents.
Thu, Apr 11, 12:32 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, Patch-For-Review, MediaWiki-extensions-WikimediaEvents, CheckUser, ci-test-error (WMF-deployed Build Failure)
Dreamy_Jazz created T362325: HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait..
Thu, Apr 11, 12:32 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, Patch-For-Review, MediaWiki-extensions-WikimediaEvents, CheckUser, ci-test-error (WMF-deployed Build Failure)
Dreamy_Jazz updated the task description for T324907: Create separate tables for log events in CheckUser.
Thu, Apr 11, 12:27 PM · Trust and Safety Product Team, Epic, MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Patch-For-Review, Schema-change, CheckUser
Dreamy_Jazz updated the task description for T324907: Create separate tables for log events in CheckUser.
Thu, Apr 11, 12:27 PM · Trust and Safety Product Team, Epic, MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Patch-For-Review, Schema-change, CheckUser
Dreamy_Jazz added a comment to T362284: Logs without a defined title or page_id cause an exception in CheckUser.

Causing errors on wmf.26. Making a train blocker as this has been reported by CUs when trying to make range checks - Relevant errors are at https://logstash.wikimedia.org/goto/af8db930269e4a62ad5ef4e7e2214186

Thu, Apr 11, 12:12 PM · Wikimedia-production-error, MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, MW-1.42-release
Dreamy_Jazz triaged T362284: Logs without a defined title or page_id cause an exception in CheckUser as Unbreak Now! priority.
Thu, Apr 11, 12:10 PM · Wikimedia-production-error, MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, MW-1.42-release
Dreamy_Jazz added a subtask for T360158: 1.42.0-wmf.26 deployment blockers: T362284: Logs without a defined title or page_id cause an exception in CheckUser.
Thu, Apr 11, 12:09 PM · Patch-For-Review, Release-Engineering-Team (Priority Backlog 📥), Release, Train Deployments
Dreamy_Jazz added a parent task for T362284: Logs without a defined title or page_id cause an exception in CheckUser: T360158: 1.42.0-wmf.26 deployment blockers.
Thu, Apr 11, 12:09 PM · Wikimedia-production-error, MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, MW-1.42-release
Dreamy_Jazz updated the task description for T362321: Set wgLoginNotifyUseCheckUser to false and wgLoginNotifyUseSeenTable to true in extension.json.
Thu, Apr 11, 12:06 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Trust and Safety Product Team, MediaWiki-extensions-LoginNotify, Community-Tech, CheckUser
Dreamy_Jazz set the point value for T362321: Set wgLoginNotifyUseCheckUser to false and wgLoginNotifyUseSeenTable to true in extension.json to 1.
Thu, Apr 11, 12:03 PM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Trust and Safety Product Team, MediaWiki-extensions-LoginNotify, Community-Tech, CheckUser
Dreamy_Jazz created T362321: Set wgLoginNotifyUseCheckUser to false and wgLoginNotifyUseSeenTable to true in extension.json.
Thu, Apr 11, 11:50 AM · MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Trust and Safety Product Team, MediaWiki-extensions-LoginNotify, Community-Tech, CheckUser
Dreamy_Jazz removed a subtask for T329189: Add read new support to Special:Investigate for event table migration: T362152: Improve test coverage on Special:Investigate code.
Thu, Apr 11, 11:35 AM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Patch-For-Review, Anti-Harassment, CheckUser
Dreamy_Jazz edited parent tasks for T362152: Improve test coverage on Special:Investigate code, added: T329200: Enable read new support in Special:Investigate's 'Timeline' tab, T329201: Enable read new support in Special:Investigate's 'IPs & User agents' tab; removed: T329189: Add read new support to Special:Investigate for event table migration.
Thu, Apr 11, 11:35 AM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser
Dreamy_Jazz added a subtask for T329201: Enable read new support in Special:Investigate's 'IPs & User agents' tab: T362152: Improve test coverage on Special:Investigate code.
Thu, Apr 11, 11:35 AM · Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)), CheckUser
Dreamy_Jazz added a subtask for T329200: Enable read new support in Special:Investigate's 'Timeline' tab: T362152: Improve test coverage on Special:Investigate code.
Thu, Apr 11, 11:35 AM · Anti-Harassment, CheckUser
Dreamy_Jazz claimed T329189: Add read new support to Special:Investigate for event table migration.
Thu, Apr 11, 11:20 AM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Patch-For-Review, Anti-Harassment, CheckUser
Dreamy_Jazz closed T361722: 'ipusers' does not handle 'cupe_actor' as NULL as Resolved.
Thu, Apr 11, 10:33 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, CheckUser
Dreamy_Jazz closed T361722: 'ipusers' does not handle 'cupe_actor' as NULL, a subtask of T341827: Add read new support to the CheckUser API, as Resolved.
Thu, Apr 11, 10:33 AM · Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Trust and Safety Product Team, Patch-For-Review, CheckUser

Wed, Apr 10

Dreamy_Jazz moved T362152: Improve test coverage on Special:Investigate code from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Wed, Apr 10, 10:01 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser
Dreamy_Jazz moved T362284: Logs without a defined title or page_id cause an exception in CheckUser from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Wed, Apr 10, 8:50 PM · Wikimedia-production-error, MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, MW-1.42-release
Dreamy_Jazz claimed T362284: Logs without a defined title or page_id cause an exception in CheckUser.
Wed, Apr 10, 8:45 PM · Wikimedia-production-error, MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, MW-1.42-release
Dreamy_Jazz created T362284: Logs without a defined title or page_id cause an exception in CheckUser.
Wed, Apr 10, 8:44 PM · Wikimedia-production-error, MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, MW-1.42-release
Dreamy_Jazz moved T326865: Special:CheckUser can expose suppressed information for log events from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Wed, Apr 10, 8:27 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, SecTeam-Processed, Vuln-Infoleak, Security
Dreamy_Jazz updated the task description for T361722: 'ipusers' does not handle 'cupe_actor' as NULL.
Wed, Apr 10, 7:08 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, CheckUser
Dreamy_Jazz set the point value for T362152: Improve test coverage on Special:Investigate code to 3.
Wed, Apr 10, 6:17 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser
Dreamy_Jazz closed T362096: CheckUser test failures when using postgres DB as Resolved.
Wed, Apr 10, 5:47 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), PostgreSQL, CheckUser
Dreamy_Jazz added a comment to T313446: Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder.

The proposed idea is to do the following:

  1. On Special:Investigate provide two block buttons, one for accounts and one for IPs. This means that the CU can use two different forms to block users and IPs without having to manually remove either the users or IPs for a particular use of the form.
  2. This would also be done for Special:CheckUser 'Get users', by replacing the form with links to Special:InvestigateBlock with one for all users and one for all IPs. This would implement T329493: Replace Special:CheckUser's 'get users' block form with a usage of Special:InvestigateBlock
    1. Doing this means that we have one form for mass blocking users in CheckUser, which makes implementing feature requests related to it easier. Currently we have to modify two different forms (one for CheckUser and one for Investigate). This means that
    2. The InvestigateBlock form has more features and is easier to use. There are several issues with the 'Get users' block form, such as T314700: Restore the bottom paging links on 'Get users' and that submitting the form causes the CU to need to re-load the 'Get users' request, which links to Special:InvestigateBlock that prefill the targets would not bring.
  3. We may warn if the user attempts to use Special:InvestigateBlock for both IPs and users.
Wed, Apr 10, 4:53 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Trust and Safety Product Team, CheckUser, Epic
Dreamy_Jazz added a project to T313446: Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder: Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)).
Wed, Apr 10, 3:26 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Trust and Safety Product Team, CheckUser, Epic
Dreamy_Jazz added a comment to T313446: Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder.

The team will be taking a look at this next week.

Wed, Apr 10, 2:33 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Trust and Safety Product Team, CheckUser, Epic
Dreamy_Jazz added a project to T313446: Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder: Trust and Safety Product Team.
Wed, Apr 10, 2:31 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Trust and Safety Product Team, CheckUser, Epic
Dreamy_Jazz merged Restricted Task into T326865: Special:CheckUser can expose suppressed information for log events.
Wed, Apr 10, 1:50 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, SecTeam-Processed, Vuln-Infoleak, Security
Dreamy_Jazz merged Restricted Task into T326865: Special:CheckUser can expose suppressed information for log events.
Wed, Apr 10, 1:49 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, SecTeam-Processed, Vuln-Infoleak, Security
Dreamy_Jazz closed T253796: Make CheckUser record the log_id of logged actions as Resolved.

This should be done now based on T330158: Enable write new for the event table migration being complete.

Wed, Apr 10, 1:42 PM · Schema-change, Anti-Harassment, CheckUser
Dreamy_Jazz closed T253796: Make CheckUser record the log_id of logged actions, a subtask of T311337: CVE-2022-39193: Edits with the performer suppressed still show the performer in results from the CheckUser extension, as Resolved.
Wed, Apr 10, 1:41 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), Platform Engineering, Vuln-Infoleak, CheckUser, Security, Security-Team
Dreamy_Jazz closed T253796: Make CheckUser record the log_id of logged actions, a subtask of T316360: Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it, as Resolved.
Wed, Apr 10, 1:41 PM · Security-Team, Anti-Harassment (AHaT Sprint 32 - Baseball Cap), SecTeam-Processed, Vuln-Infoleak, CheckUser, Security
Dreamy_Jazz closed T253796: Make CheckUser record the log_id of logged actions, a subtask of T316414: CVE-2022-39193: Special:Investigate can expose supressed information in check results, as Resolved.
Wed, Apr 10, 1:41 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), SecTeam-Processed, Vuln-Infoleak, CheckUser, Anti-Harassment, Security, Security-Team
Dreamy_Jazz closed T253796: Make CheckUser record the log_id of logged actions, a subtask of T318166: CVE-2022-39193: CheckUser API can expose the suppressed performer, as Resolved.
Wed, Apr 10, 1:41 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), SecTeam-Processed, CheckUser, Security, Security-Team
Dreamy_Jazz closed T253796: Make CheckUser record the log_id of logged actions, a subtask of T326866: Special:Investigate can expose suppressed information for log events, as Resolved.
Wed, Apr 10, 1:41 PM · CheckUser, SecTeam-Processed, Anti-Harassment, Vuln-Infoleak, Security
Dreamy_Jazz closed T253796: Make CheckUser record the log_id of logged actions, a subtask of T326865: Special:CheckUser can expose suppressed information for log events, as Resolved.
Wed, Apr 10, 1:41 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, SecTeam-Processed, Vuln-Infoleak, Security
Dreamy_Jazz closed T253796: Make CheckUser record the log_id of logged actions, a subtask of T326867: CheckUser API can expose suppressed information for log events, as Resolved.
Wed, Apr 10, 1:41 PM · Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, SecTeam-Processed, Vuln-Infoleak, Security
Dreamy_Jazz claimed T326865: Special:CheckUser can expose suppressed information for log events.
Wed, Apr 10, 1:39 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, SecTeam-Processed, Vuln-Infoleak, Security
Dreamy_Jazz added projects to T326865: Special:CheckUser can expose suppressed information for log events: Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team.
Wed, Apr 10, 1:38 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, SecTeam-Processed, Vuln-Infoleak, Security
Dreamy_Jazz updated the task description for T361722: 'ipusers' does not handle 'cupe_actor' as NULL.
Wed, Apr 10, 1:31 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, CheckUser
Dreamy_Jazz closed T361869: Display temp account names on Special:Contributions for IP addresses, a subtask of T358852: [Epic] Display temporary account contributions on Special:Contributions for IP addresses and IP ranges, as Resolved.
Wed, Apr 10, 1:27 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Patch-For-Review, Epic, Trust and Safety Product Team, Temporary accounts (Create/update essential tools/anti-abuse management), Stewards-and-global-tools
Dreamy_Jazz closed T361866: Display contributions from temporary accounts on Special:Contributions/IP, a subtask of T358852: [Epic] Display temporary account contributions on Special:Contributions for IP addresses and IP ranges, as Resolved.
Wed, Apr 10, 1:27 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Patch-For-Review, Epic, Trust and Safety Product Team, Temporary accounts (Create/update essential tools/anti-abuse management), Stewards-and-global-tools
Dreamy_Jazz closed T361869: Display temp account names on Special:Contributions for IP addresses as Resolved.
Wed, Apr 10, 1:27 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, CheckUser, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Temporary accounts
Dreamy_Jazz closed T361866: Display contributions from temporary accounts on Special:Contributions/IP as Resolved.
Wed, Apr 10, 1:27 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, CheckUser, Temporary accounts, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April))
Dreamy_Jazz closed T362053: Make MediaModeration sleep on JobQueueError as Resolved.
Wed, Apr 10, 1:27 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), MediaModeration (MediaModeration 2.0)
Dreamy_Jazz closed T326867: CheckUser API can expose suppressed information for log events as Resolved.
Wed, Apr 10, 1:26 PM · Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, SecTeam-Processed, Vuln-Infoleak, Security
Dreamy_Jazz closed T361951: 'isWriteMode' method overrides on ApiQueryBase subclasses is ignored causing transaction profiler expectations to not be met as Resolved.
Wed, Apr 10, 1:01 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Action-API, CheckUser, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team
Dreamy_Jazz closed T361291: If the reason provided for a log entry is hidden, it is not hidden in the checkuser API response for an actions request as Resolved.
Wed, Apr 10, 8:31 AM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, CheckUser

Tue, Apr 9

DannyS712 awarded T313446: Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder a Like token.
Tue, Apr 9, 10:06 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Trust and Safety Product Team, CheckUser, Epic
Dreamy_Jazz merged T353938: Better safeguards against blocking IPs and user accounts together in the Special:CheckUser blocking interface into T313446: Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder.
Tue, Apr 9, 10:06 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Trust and Safety Product Team, CheckUser, Epic
Dreamy_Jazz merged task T353938: Better safeguards against blocking IPs and user accounts together in the Special:CheckUser blocking interface into T313446: Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder.
Tue, Apr 9, 10:05 PM · CheckUser
Dreamy_Jazz moved T326867: CheckUser API can expose suppressed information for log events from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.

For QA I would suggest suppressing a variety of information about log events and see if the information for these log events still displays in the CheckUser API.

Tue, Apr 9, 9:20 PM · Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser, SecTeam-Processed, Vuln-Infoleak, Security
Dreamy_Jazz moved T361291: If the reason provided for a log entry is hidden, it is not hidden in the checkuser API response for an actions request from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Tue, Apr 9, 9:16 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, CheckUser
Dreamy_Jazz moved T361951: 'isWriteMode' method overrides on ApiQueryBase subclasses is ignored causing transaction profiler expectations to not be met from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Tue, Apr 9, 5:34 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Action-API, CheckUser, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team
Dreamy_Jazz closed T362079: Set GlobalBlocking account blocks config to false on REL1_42 as Resolved.
Tue, Apr 9, 2:40 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, GlobalBlocking, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), MW-1.42-release
Dreamy_Jazz claimed T362152: Improve test coverage on Special:Investigate code.
Tue, Apr 9, 1:42 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser
Dreamy_Jazz closed T361695: The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log. as Resolved.

Going to mark this as resolved, because all the logs I've seen in logstash have been addressed. The entries should reduce down to nothing once wmf.26 is out on all wikis.

Tue, Apr 9, 12:51 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WMF-General-or-Unknown, Wikimedia-production-error
Dreamy_Jazz moved T362152: Improve test coverage on Special:Investigate code from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Tue, Apr 9, 12:27 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser
Dreamy_Jazz assigned T362079: Set GlobalBlocking account blocks config to false on REL1_42 to Jdforrester-WMF.
Tue, Apr 9, 12:15 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, GlobalBlocking, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), MW-1.42-release
Dreamy_Jazz created T362152: Improve test coverage on Special:Investigate code.
Tue, Apr 9, 12:05 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), CheckUser
Dreamy_Jazz moved T329189: Add read new support to Special:Investigate for event table migration from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Tue, Apr 9, 12:01 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Patch-For-Review, Anti-Harassment, CheckUser

Mon, Apr 8

Dreamy_Jazz added a comment to T360621: Test and make improvements to the fixGlobalBlockWhitelist.php script.

Suggested QA steps for a local wiki:

  1. Perform a infinite global block on an IP address
  2. Perform a infinite global block on an account
  3. Locally disable the global blocks performed in steps 1 and 2
  4. Remove the global blocks performed in steps 1 and 2
  5. Re-block the same IP address as you blocked in step 1 with a global block with that is not indefinite
  6. Run the fixGlobalBlockWhitelist.php script with the --delete option included specified
  7. Open Special:GlobalBlockList and verify that the global block on the IP address is marked as disabled
  8. Open the database for the local wiki
  9. Run SELECT gbw_expiry from global_block_whitelist where gbw_address = <IP>; replacing <IP> with the IP address you blocked in step 5
  10. Verify that returned value is not indefinite and also matches the expiry you specified when you performed the global block in step 5
  11. Run SELECT COUNT(*) from global_block_whitelist where gbw_address = <username>; replacing <username> with the username of the account you blocked in step 2 and verify that the result is 0.
Mon, Apr 8, 5:38 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, GlobalBlocking
Dreamy_Jazz moved T361866: Display contributions from temporary accounts on Special:Contributions/IP from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.

Suggested QA steps for local wiki or patch demo:

  1. Install CheckUser
  2. Enable temporary account autocreation
  3. Make an edit while logged out (which should also create a temporary account for you)
  4. Note down the username of this temporary account
  5. Log into an account with the checkuser user group
  6. Find the edit made by the temporary account and press Show IP
  7. Load Special:Contributions for the IP address that was displayed in step 6
  8. Verify that the edit by the temporary account performed in step 3 appears in the contributions list, including that the username of the temporary account that made the edit is shown. For example, it should look like the following:

image.png (64×920 px, 16 KB)

  1. Load Special:Contributions for the IP address that was displayed in step 6 while logged out and verify that the edit performed by the temporary account in step 3 is not shown.
Mon, Apr 8, 5:27 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, CheckUser, Temporary accounts, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April))
Dreamy_Jazz moved T361869: Display temp account names on Special:Contributions for IP addresses from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.

This will be QA'd through T361866: Display contributions from temporary accounts on Special:Contributions/IP.

Mon, Apr 8, 5:25 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, CheckUser, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Temporary accounts
Dreamy_Jazz moved T361869: Display temp account names on Special:Contributions for IP addresses from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Mon, Apr 8, 5:20 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, CheckUser, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Temporary accounts
Dreamy_Jazz removed a project from T360621: Test and make improvements to the fixGlobalBlockWhitelist.php script: Patch-For-Review.
Mon, Apr 8, 5:17 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, GlobalBlocking
Dreamy_Jazz moved T362096: CheckUser test failures when using postgres DB from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Mon, Apr 8, 4:32 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), PostgreSQL, CheckUser
Dreamy_Jazz claimed T362096: CheckUser test failures when using postgres DB.
Mon, Apr 8, 4:21 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), PostgreSQL, CheckUser
Dreamy_Jazz added projects to T362096: CheckUser test failures when using postgres DB: Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team.
Mon, Apr 8, 4:20 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), PostgreSQL, CheckUser
Dreamy_Jazz created T362096: CheckUser test failures when using postgres DB.
Mon, Apr 8, 4:19 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), PostgreSQL, CheckUser
Dreamy_Jazz updated the task description for T361924: Update TemporaryAccountHandler for CheckUser event table migration.
Mon, Apr 8, 4:06 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, CheckUser
Dreamy_Jazz claimed T361924: Update TemporaryAccountHandler for CheckUser event table migration.
Mon, Apr 8, 3:47 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, CheckUser
Dreamy_Jazz awarded T361747: Provide some feedback in scap whilst waiting for helmfile deploys to complete a Like token.
Mon, Apr 8, 2:48 PM · MW-on-K8s, Scap
Dreamy_Jazz added a comment to T362079: Set GlobalBlocking account blocks config to false on REL1_42.

Ideally I wanted it to still be true for the master branch.

Mon, Apr 8, 2:14 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, GlobalBlocking, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), MW-1.42-release
Dreamy_Jazz created T362079: Set GlobalBlocking account blocks config to false on REL1_42.
Mon, Apr 8, 1:37 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, Trust and Safety Product Team, GlobalBlocking, Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), MW-1.42-release
Dreamy_Jazz moved T361924: Update TemporaryAccountHandler for CheckUser event table migration from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Mon, Apr 8, 12:51 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)), Trust and Safety Product Team, CheckUser
Dreamy_Jazz moved T361884: Remove $wgIPInfoGeoIP2EnterprisePath from production config from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Tabla (1st - 14th April)) board.
Mon, Apr 8, 12:13 PM · Trust and Safety Product Sprint (Sprint Pennywhistle (23rd April - 3rd May)), Patch-For-Review, IP Info