I believe this ticket can now be closed since T302297: Display geopoint SPARQL queries in a map in Wikipedia (GeoPoints) was deployed to all wikis on Sept 26. Kartographer generated maps can now display the result of a SPARQL query with geopoints/markers instead of only geoshapes as it was previously.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Sep 29 2022
This feature was deployed
Closing ticket as this feature has been deployed to all wikis
Can the points be re-estimated for the remaining work only?
Re-opening because focus/selected styling was not complete. Pulling into sprint, but this does not need to block deployment if it isn't done in time
Sep 28 2022
Agreed in story time to timebox and review the feature's prioritization if it seems that it will take more time than that.
I think it would be "metadata" (one word) even in English. The downside to this is it might be slightly more confusing for people who have come to know it as TemplateData, but I don't mind much either way.
Ah true! And that's a good point. Maybe leaving the changes as-is is a good middle ground, where hopefully it's a bit clearer to both people who are and aren't familiar.
Sep 27 2022
@ECohen_WMDE It seems that the map is always focused when opening the fullscreen mode. It's nice to have the keyboard interactions of course, but this means that the blue box is always drawn which seems less nice. Thoughts?
I will put this in the preparation column and assign to myself to determine the best approach. I think leaving it as-is for now is fine, as the broken image icon is not giving the user much more information on what is wrong. Will think about this in combination with the rest of the error/broken maps tickets.
Yup makes sense to me! Improving this message was actually something that we had on our list but gotten taken out of scope because of time limits. Happy to see it'll still get a bit better.
@ECohen_WMDE, I think it was a while ago that we talked about the icons on the two buttons in the bottom right corner of a fullscreen map. A pin for the nearby feature and an external link icon for the other button. Should we remove these?
Yes, both should be removed. Thanks for remembering! I kept not finding the time to make the ticket for these. If you wouldn't mind doing it, that would be great.
Sep 22 2022
Sep 20 2022
As discussed in the story time, I am fine with the changes listed above. Go ahead and merge, since they are definitely better than the large red box.
Thanks @thiemowmde for the screenshot and context.
Sep 16 2022
The survey link has also been updated
Text has been finalized and is in the task description
Sep 14 2022
Documenting decisions here as made on mattermost and in story time. Will update the task description next.
Sep 13 2022
The button to close and hide: Nein, danke defaults to Nein danke we could leave it like that and spare creating an overwrite page for that message on the project page. We could change the de translation for the default message in the extension using translatewiki though and add the comma there.
This is fine to leave as is without the comma.
@WMDE-Fisch Ok, all text and links are there. If you need anything else, let me know :)
Sep 12 2022
The question was whether we want to show the nearby markers on a different layer, "above" the rest of the annotations, or show the mapframe annotations above the nearby markers, or exclusively show one layer or the other.
Sep 5 2022
Code for review has a nice transparency effect, we'll merge it and discuss
Sep 1 2022
Nice! I think the color is looking good.
@ECohen_WMDE Can you suggest a nicer marker background color, or should we stick with the neutral default?
Aug 31 2022
We noticed and removed the outlines already. Here is a live example: https://maps-beta.wmflabs.org/v4/marker/pin-m-29+0a0@2x.png.
Glad to hear that.
@awight Is there a test page to see the new markers, numbers and letters live on beta - in addition to the images in the task description? I'd like to review the sizing and placement of the icons.
Aug 30 2022
Confirmed in sprint review that the general direction is good. Not reviewed is how the points disappear when zooming out and they become too dense, since this still needs to be merged.