Page MenuHomePhabricator

Dialects without Wikipedias are still prompted for translation in sidebar
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to repro:

  1. Set user language to British English
  2. Check sidebar of any(?) Wikipedia article
  3. British English appears in gray

Screenshot from 2015-09-28 13:35:22.png (176×162 px, 8 KB)

  1. Clicking through sends you to the non-existent en-gb.wikipedia.org

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedAmire80
OpenNone
OpenNone
ResolvedAmire80
ResolvedAmire80
ResolvedKartikMistry
Resolvedsanthosh
ResolvedKartikMistry
ResolvedAmire80
ResolvedAmire80
ResolvedAmire80
ResolvedEsanders
ResolvedNikerabbit
OpenNone
DeclinedNone
ResolvedBUG REPORTngkountas

Event Timeline

MC8 raised the priority of this task from to Needs Triage.
MC8 updated the task description. (Show Details)
MC8 added a project: ContentTranslation.
MC8 subscribed.
MC8 set Security to None.
Amire80 triaged this task as High priority.Sep 29 2015, 5:12 PM
Amire80 subscribed.

This might be fixed on master, but we'll test after deployment in the end of the week.

Ooops, no. Still happens. I just verified it with Traditional Chinese (中文(台灣)).

Amire80 moved this task from CX6 to CX7 on the ContentTranslation board.
Amire80 added a subscriber: santhosh.

Seems fixed for British English and Brazilian Portuguese, but broken for - guess what! - 'nb'. I'll fix.

Change 247263 had a related patch set uploaded (by Amire80):
Fix the behavior of be-tarask and nb in gray interlanguage links

https://gerrit.wikimedia.org/r/247263

Change 247263 merged by jenkins-bot:
Fix the behavior of be-tarask and nb in gray interlanguage links

https://gerrit.wikimedia.org/r/247263

Verified for nb. Could not view be-tarask in the interlanguage link section. Someone may need to confirm.

I don't think that it's deployed in production.

Yeah, my bad. Please ignore the earlier comment.

Verified with the English Wikipedia article for Kennedy family. nowiki article exists which is displayed correctly and link to nb is not displayed. be-tarask is also displayed correctly for this and several other articles.

Screen Shot 2015-12-02 at 9.23.44 pm.png (447×540 px, 75 KB)

Facepalm.

I was sure that it was fixed long ago.

Thanks for the reproduction instruction, @He7d3r. I hope to get this fixed soon.

Change 270599 had a related patch set uploaded (by Amire80):
Remove hyphens from all languages when creating a gray link

https://gerrit.wikimedia.org/r/270599

Change 270599 merged by jenkins-bot:
Remove hyphens from all languages when creating a gray link

https://gerrit.wikimedia.org/r/270599

Arrbee moved this task from Backlog to QA on the LE-CX8-Sprint 3 board.