Remove mediawiki.legacy.wikibits methods deprecated since before 1.18
Closed, ResolvedPublic

Description

WARNING: All JavaScript functionality is broken since 2017-04-27 for users who use old scripts. Some advice on what to disable is available.
	 * @deprecated since 1.17 Use jquery.client instead
	 * @deprecated since 1.17 Use jQuery instead
	 * @deprecated since 1.17 Use jquery.checkboxShiftClick instead
	 * @deprecated since 1.17 Use mw.toolbar instead
	 * @deprecated since 1.18 Use jquery.spinner instead
	 * @deprecated since 1.18 Use mw.html instead
	 * @deprecated since 1.17 Use mediawiki.notify instead
	 * @deprecated since 1.17 Use mediawiki.util or jquery.accessKeyLabel instead
	 * @deprecated since 1.17 Use mw.loader instead. Warnings added in 1.25.
	 * @deprecated since 1.17 Use mw.loader instead. Warnings added in 1.25.

I'm guessing most of them will be onwiki usages, which are more of a PITA to cleanup

mw-js-deprecate usage (logged-in users only, sampled 1:100)

Krenair added a subscriber: Krenair.Jan 3 2016, 1:20 AM
Reedy set Security to None.
Reedy edited the task description. (Show Details)Jan 3 2016, 1:28 AM
Reedy added a comment.Jan 3 2016, 1:47 AM
addCheckboxClickHandlers
checkboxClickHandler
ff2_bugs
is_chrome_mac
is_chrome
is_ff2
is_ff2_win
is_ff2_x11
is_opera_preseven
is_safari_win
opera6_bugs
opera7_bugs
opera95_bugs
removeHandler
runOnloadHook
setupCheckboxShiftClick
webkit_match

Have no usages onwiki in the MediaWiki namespace, but they do in User :/

Reedy added a comment.Jan 3 2016, 2:18 AM

He7d3r added a subscriber: He7d3r.Jan 7 2016, 4:03 PM
Danny_B moved this task from Unsorted to Cleanup on the Technical-Debt board.
Danny_B added a subscriber: Danny_B.
Krinkle changed the title from "Cleanup pre MW 1.20 deprecations in Wikibits.js" to "Remove legacy wikibits".Mar 24 2016, 2:27 AM
Krinkle triaged this task as "Low" priority.
Krinkle added a subscriber: Krinkle.EditedMar 24 2016, 2:33 AM

Detaching from parent task T122754 because this is not gonna happen in this release cycle.

wikibits.js only contains deprecation markers. There is nothing left. This is really about the removal of that library in general. However we're not ready for that yet:

  • Deprecation (2011; MediaWiki 1.17)
  • Announce deprecation (October 2013)
  • Deprecation warnings (MediaWiki 1.23)

Normally the next step would be removal. However we need an additional phase in our case because this module is loaded by default. Adding a blocker on T35836: Set $wgIncludeLegacyJavaScript = false by default (part of MediaWiki 1.27) which will ride the deployment train a few weeks from now. After that, people will have the option to temporary restore any breakage they find by adding an explicit dependency as stop-gap measure. Then (closer to when we'll cut the 1.28 branch in September 2016) we can remove the library.

Jdforrester-WMF changed the title from "Remove legacy wikibits" to "Remove use of legacy wikibits".Mar 24 2016, 8:54 PM
Krinkle changed the title from "Remove use of legacy wikibits" to "Remove mediawiki.legacy.wikibits module".Mar 25 2016, 10:49 PM
Krinkle changed the title from "Remove mediawiki.legacy.wikibits module" to "Remove mediawiki.legacy.wikibits methods deprecated since 1.17".Apr 10 2016, 2:12 AM
Krinkle changed the title from "Remove mediawiki.legacy.wikibits methods deprecated since 1.17" to "Remove mediawiki.legacy.wikibits methods deprecated since before 1.18".

Change 282506 had a related patch set uploaded (by Krinkle):
[WIP] wikibits: Remove methods deprecated since 1.17 and 1.18

https://gerrit.wikimedia.org/r/282506

Krinkle moved this task from Accepted: Enhancement to Assigned on the MediaWiki-ResourceLoader board.
Krinkle claimed this task.
Krinkle moved this task from Inbox to Doing on the Performance-Team board.
Krinkle edited the task description. (Show Details)Tue, Apr 11, 10:54 PM

Change 282506 merged by jenkins-bot:
[mediawiki/core@master] wikibits: Remove methods deprecated since 1.17 and 1.18

https://gerrit.wikimedia.org/r/282506

Krinkle closed this task as "Resolved".Wed, Apr 12, 2:35 AM
TheDJ added a subscriber: TheDJ.Fri, Apr 28, 12:49 PM

Note that this change has two side effects I think, which are causing a lot of errors since deploy:

1: some variables that were silently failing are now hard failing, because the variable is no longer defined, yet still referenced.
2: mediawiki.util dependency was dropped, exposing a lot more user scripts that were not actively ensuring their dependency on mediawiki.util.

Nemo_bis edited the task description. (Show Details)Sat, Apr 29, 1:04 PM