Maniphest T133055

Split ext.popups.settings.js in units
Closed, InvalidPublic5 Estimated Story Points
Actions

Assigned To

None

Authored By

	• Jhernandez
	Apr 19 2016, 3:58 PM

Tags

Referenced Files

None

Subscribers

Description

Module does too much.

Split the view and its unit tests to a view file that only renders.
Split the global code that adds the footer link and the function somewhere else.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		Jdlrobson	T111329 [GOAL] Page previews on mobileweb
		Resolved		phuedx	T133947 [EPIC] Reduce bloat of Page Previews RL module(s)
		Resolved		Jdlrobson	T144522 [EPIC] Hovercards technical debt and quality enhancements
		Resolved		Jdlrobson	T67103 [EPIC] Hovercards: Test Coverage
		Resolved		None	T133017 Spike: What's tested and what needs testing in Hovercards
		Resolved		Jdlrobson	T133018 Set up browser tests running on CI (jenkins) for Hovercards
		Resolved		Jdlrobson	T133019 Create browser tests for hovering link and showing hovercard
		Resolved		Jdlrobson	T133020 Unit test ext.popups.core.js
		Resolved		None	T133022 Unit test src/renderer.js
		Duplicate		None	T133162 Unit test ext.popups.renderer.article.js (part 2 HARD)
		Invalid		None	T133023 Unit test ext.popups.disablenavpop.js
		Resolved		• Jhernandez	T133024 Unit test ext.popups.logger.js
		Invalid		None	T133055 Split ext.popups.settings.js in units
		Resolved		phuedx	T133025 Unit test ext.popups.settings.js
		Resolved		phuedx	T133054 Create browser test for add footer link in ext.popups.settings.js
		Resolved		Jdlrobson	T133163 BetaFeatures test failure

Event Timeline

• Jhernandez created this task.Apr 19 2016, 3:58 PM

• Jhernandez added a parent task: T67103: [EPIC] Hovercards: Test Coverage.

MBinder_WMF added a project: Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 19 2016, 8:38 PM

MBinder_WMF set the point value for this task to 5.Apr 20 2016, 3:28 PM

• Jhernandez removed a parent task: T133054: Create browser test for add footer link in ext.popups.settings.js.Apr 20 2016, 3:30 PM

• Jhernandez added a subtask: T133054: Create browser test for add footer link in ext.popups.settings.js.

• Jhernandez edited subtasks, added: T133025: Unit test ext.popups.settings.js; removed: T133054: Create browser test for add footer link in ext.popups.settings.js.Apr 20 2016, 3:32 PM

dr0ptp4kt edited projects, added Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one; removed Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 20 2016, 4:02 PM

• Jhernandez moved this task from Needs Analysis to Ignore on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 21 2016, 4:59 PM

Danny_B moved this task from Unsorted to Separate concerns on the Technical-Debt board.Apr 21 2016, 9:16 PM

MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 5:10 PM

MBinder_WMF moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Apr 27 2016, 5:13 PM

phuedx closed subtask T133025: Unit test ext.popups.settings.js as Resolved.Apr 29 2016, 9:04 AM

Jdlrobson edited projects, added Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card; removed Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.May 9 2016, 4:56 PM

dr0ptp4kt removed a project: Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card.May 11 2016, 4:24 PM

dr0ptp4kt moved this task from 2016-17 Q2 to Triaged but Future on the Web-Team-Backlog board.May 20 2016, 11:45 AM

MBinder_WMF added a project: Reading-Web-Tech-Debt.Oct 3 2016, 8:34 PM

MBinder_WMF edited projects, added Technical-Debt (RW-Tech-Debt); removed Technical-Debt.Oct 4 2016, 6:15 PM

MBinder_WMF removed a project: Reading-Web-Tech-Debt.Oct 4 2016, 7:53 PM

• bmansurov moved this task from Uncategorized to Maintainability on the Technical-Debt (RW-Tech-Debt) board.Oct 5 2016, 10:44 PM

ovasileva added a parent task: T144522: [EPIC] Hovercards technical debt and quality enhancements.Oct 21 2016, 9:23 AM

ovasileva moved this task from Backlog to Needs Analysis on the Page-Previews board.Dec 20 2016, 12:37 AM

This code was removed during T149801: [EPIC] Refactor Hovercards (née Popups). Since the rewrite branch has been merged, this task is now invalid.