Page MenuHomePhabricator
Create Task
Maniphest T133023

Unit test ext.popups.disablenavpop.js
Closed, InvalidPublic
Actions

Description

No coverage whatsoever. Unit test properly.

Just a function, 22LOC. Relies in a lot of global state.

Also, please remove // HACK: This is a temporary fix, because it clearly is not. Disabling navigation popups in hovercards is a feature, at least while navigation popups exists.

Related Objects
Search...

Event Timeline

• Jhernandez created this task.Apr 19 2016, 9:37 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2016, 9:37 AM
• Jhernandez moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 19 2016, 9:37 AM
• Jhernandez moved this task from To Do to Needs Analysis on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 19 2016, 4:11 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 19 2016, 4:11 PM
MBinder_WMF added a project: Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 19 2016, 8:38 PM
• Jhernandez updated the task description. (Show Details)Apr 20 2016, 11:10 AM

Also, please remove // HACK: This is a temporary fix, because it clearly is not. Disabling navigation popups in hovercards is a feature, at least while navigation popups exists.

• Jhernandez added a comment.Apr 20 2016, 3:36 PM

I heavily encourage followup patches after testing to refactor this little piece of code. Could be a good exercise for offsite.

• bmansurov updated the task description. (Show Details)Apr 20 2016, 3:36 PM
dr0ptp4kt edited projects, added Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one; removed Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 20 2016, 4:02 PM
• Jhernandez moved this task from Needs Analysis to Ignore on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 21 2016, 4:59 PM
Danny_B moved this task from Unsorted to Test coverage on the Technical-Debt board.Apr 21 2016, 8:52 PM
MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:21 PM
MBinder_WMF moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Apr 27 2016, 4:48 PM
Jdlrobson edited projects, added Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card; removed Reading-Web-Sprint-72-Ninety-nine-problems-but-Nirzar-aint-one.May 9 2016, 4:56 PM
dr0ptp4kt removed a project: Reading-Web-Sprint-73-One-day-we'll-finish-the-EventLogging-card.May 11 2016, 4:24 PM
dr0ptp4kt moved this task from 2016-17 Q2 to Triaged but Future on the Web-Team-Backlog board.May 20 2016, 11:41 AM
MBinder_WMF added a project: Reading-Web-Tech-Debt.Oct 3 2016, 8:34 PM
MBinder_WMF edited projects, added Technical-Debt (RW-Tech-Debt); removed Technical-Debt.Oct 4 2016, 6:15 PM
MBinder_WMF removed a project: Reading-Web-Tech-Debt.Oct 4 2016, 7:53 PM
• bmansurov moved this task from Uncategorized to Team Workflows/Internal on the Technical-Debt (RW-Tech-Debt) board.Oct 5 2016, 10:44 PM
ovasileva added a parent task: T144522: [EPIC] Hovercards technical debt and quality enhancements.Oct 21 2016, 9:23 AM
ovasileva moved this task from Backlog to Needs Analysis on the Page-Previews board.Dec 20 2016, 12:37 AM
phuedx closed this task as Invalid.Feb 15 2017, 6:16 AM
phuedx subscribed.

This code was removed during T149801: [EPIC] Refactor Hovercards (née Popups). Since the rewrite branch has been merged, this task is now invalid.

For posterity, T151058: Allow users who have navigational popups to use hovercards tracked ensuring that NavPopups and Page Previews played nicely together in the rewrite branch.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits