Maniphest T191585

Release mapframe to all NON-Flagged Revs wikipedia (and a few who do have Flagged Revs).
Closed, ResolvedPublic
Actions

Description

Pending the results of the consultation described in T191583, release mapframe to all NON-Flagged Revs wikipedia (and some do have Flagged Revs, as described below).

Flagged Revisions can cause problems with mapframe. Our investigations into this issue T151665 have determined that there are various flavors of Flagged Revisions. One style ( $wgFlaggedRevsOverride = false) still shows users the most recent edit; this does not cause problems. The other style, best known for being the style used on German Wikipedia, hides the latest version of an article until the edit has been reviewed and approved ( $wgFlaggedRevsOverride = true). This style causes problems and will be omitted from the mapframe general release.

Which wikis WILL get mapframe?

All Wikipedias which do NOT use Flagged Revisions.
Wikipedias which have Flagged Revs, but which show the latest version of a page by default ( $wgFlaggedRevsOverride = false):
1. Als—Alemannisch
2. Be—Belarusian
3. Bn—Bengali
4. Ce—Chechen
5. Ckb—Central Kurdish
6. En— English
7. Eo—Esperanto
8. Fa—Persian
9. Hi—Hindi
10. Ia—Interlingua
11. Uk—Ukrainian
12. Vec—Venetian

Which wikis WILL NOT get mapframe in this release?

These Flagged Rev Wikipedias hide the latest version of a page ( $wgFlaggedRevsOverride = true)

Bs—Bosnian
De—German
Hu—Hungarian
Id—Indonesian
Ka—Georgian
Pl—Polish
Sq—Albanian
Tr—Turkish
Zh_classicalwiki—Classical Chinese

Details

	Subject	Repo	Branch	Lines +/-
	Enable mapframe on all but a few wikis	operations/mediawiki-config	master	+12 -40

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• jmatazzoni	T191585 Release mapframe to all NON-Flagged Revs wikipedia (and a few who do have Flagged Revs).
		Resolved		CKoerner_WMF	T191583 Consult with NON-Flagged Revs Wikipedias: Do they want mapframe?

Event Timeline

• jmatazzoni triaged this task as Medium priority.Apr 6 2018, 12:28 AM

• jmatazzoni created this task.

• jmatazzoni mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).

• jmatazzoni updated the task description. (Show Details)

• jmatazzoni added a subtask: T191583: Consult with NON-Flagged Revs Wikipedias: Do they want mapframe? .

• jmatazzoni moved this task from Untriaged to Blocked on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Apr 6 2018, 12:33 AM

Note to self: when we do this deployment, we will also need to restart Parsoid afterwards.

• jmatazzoni closed subtask T191583: Consult with NON-Flagged Revs Wikipedias: Do they want mapframe? as Resolved.May 4 2018, 12:18 AM

• jmatazzoni updated the task description. (Show Details)

mxn subscribed.May 8 2018, 6:38 AM

Change 432031 had a related patch set uploaded (by Catrope; owner: Catrope):
[operations/mediawiki-config@master] Enable mapframe on all but a few wikis

https://gerrit.wikimedia.org/r/432031

gerritbot added a project: Patch-For-Review.May 9 2018, 2:06 AM

Catrope updated the task description. (Show Details)May 9 2018, 2:11 AM

Change 432031 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable mapframe on all but a few wikis

https://gerrit.wikimedia.org/r/432031

Mentioned in SAL (#wikimedia-operations) [2018-05-09T13:27:32Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:432031|Enable mapframe on all but a few wikis (T191585)]] (duration: 01m 20s)

SBisson moved this task from Blocked to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 9 2018, 1:31 PM

huwiki has $wgFlaggedRevsOverride = false now (changed about a month ago, see T121995).

In T191585#4199522, @Tgr wrote:

huwiki has $wgFlaggedRevsOverride = false now (changed about a month ago, see T121995).

The task says it's a temporary 6-month change, and that it might be re-enabled afterwards. You can have mapframe with override, there's no fundamental conflict, but you'll run into broken maps somewhat frequently. See T151665. For that reason I'm hesitant to enable mapframe on huwiki and have things potentially break in six months, unless the community is OK with maps being broken occasionally.

Note that ruwiki has similar settings, and has mapframe enabled, but has not observed any issues (or at least they have not reported them).

In T191585#4201551, @Yurik wrote:

Note that ruwiki has similar settings, and has mapframe enabled, but has not observed any issues (or at least they have not reported them).

Thanks Yurik. It's true, there are 800 mapframe maps on ru.wiki.

With all we have going on we decided not to promote the idea, but if the Flagged Rev wikis want to request mapframe, knowing the risks, we can think about implementing it for them. But the Flagged Revs issues are challenging. So my fear is that such an implementation might become an implicit promise to fix the problems.

Checked all three cases - mapframe works as expected:

default (no FlaggedRevs)
wikis with $wgFlaggedRevsOverride = false - enwiki, fawiki, hiwiki, and vecwiki
wikis with $wgFlaggedRevsOverride = false - plwiki, dewiki, huwiki

QA Recommendation: Resolve

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 11 2018, 11:22 PM

I should add, of course, that we'd love to fix this problem and bring mapframe to all. Germany has asked for it I know. That's why the team has talked about it so extensively. But we may not have time before June.

In all honesty, this might be about the right size for a Wishlist proposal, don't people think? @Catrope?

Tgr mentioned this in T185664: Code stewardship review: FlaggedRevs.May 23 2018, 1:01 PM

• jmatazzoni closed this task as Resolved.Jun 1 2018, 5:15 PM

• jmatazzoni claimed this task.

Liuxinyu970226 mentioned this in T138057: Epic: Enable <mapframe> on Wikipedia.Jun 12 2018, 10:26 PM

MSantos mentioned this in T202793: Clarify/document whether mapframe thumbnails are meant to be interactive or static.Sep 7 2018, 4:23 PM

MSantos mentioned this in T218051: Raw <mapframe> code displayed in an infobox template when mapframe is not enabled on that wiki.Mar 27 2019, 4:15 PM

Urbanecm mentioned this in T229726: Activate Kartographer in Georgian wikipedia.Aug 4 2019, 4:30 PM

Bennylin subscribed.Aug 10 2019, 1:46 AM

Mehman97 subscribed.Aug 31 2019, 5:54 PM

Will this problem be solved? It would be great if it works on trwiki.