Page MenuHomePhabricator
Create Task
Maniphest T207472

Watchlist is no longer showing seen indicators and point types have become small
Closed, ResolvedPublic
Actions

Assigned To
Catrope
Authored By
Xaosflux
Oct 19 2018, 2:20 PM
Tags
Referenced Files
F26636753: Screenshot from 2018-10-19 10-54-06.png
Oct 19 2018, 5:55 PM
F26636745: Screenshot from 2018-10-19 10-52-19.png
Oct 19 2018, 5:55 PM
F26636760: Screenshot from 2018-10-19 10-53-46.png
Oct 19 2018, 5:55 PM
F26636742: Screenshot from 2018-10-19 10-52-28.png
Oct 19 2018, 5:55 PM
Subscribers
Abelmoschus_Esculentus
Aklapper
Catrope
Daimona
Doc_James
gerritbot
greg
View All 16 Subscribers
Tokens
"Baby Tequila" token, awarded by RandomDSdevel."Burninate" token, awarded by Tomybrz.

Description

Current reports on enwiki at:
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Watchlist_problem?

I've noticed today that my watchlist is no longer differentiating between changes I've seen and changes I haven't. Each entry now just starts with the same period/full stop. Using >Firefox on Mac, and no relevant preference options that I can see. Tried Chrome on Mac too, and the differentiation between seen and unseen changes also does not show. >Anyone else seen this, and any idea what the problem is? Boing! said Zebedee (talk) 12:54, 19 October 2018 (UTC)

Same here, using Firefox 62.0.3 under Windows 7, 32-bit. The bullet points are now much smaller (are the size of periods) and undifferentiated. Dhtwiki (talk) 13:09, 19 October >2018 (UTC)

    I've got the same problem. Chrome Version 69.0.3497.81 (Official Build) (64-bit) on a Windows 7 terminal. Simonm223 (talk) 13:19, 19 October 2018 (UTC)

Disabling "improved watchlist" restores functionality for some users

Related Objects

Event Timeline

Xaosflux created this task.Oct 19 2018, 2:20 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 19 2018, 2:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Xaosflux updated the task description. (Show Details)Oct 19 2018, 2:23 PM
Daimona subscribed.Oct 19 2018, 2:48 PM
Doc_James subscribed.Oct 19 2018, 4:42 PM

Yup same here. This is a hug issue.

Doc_James added a comment.Oct 19 2018, 5:24 PM

Managed to figure out an okay work around by turning on the gadget "Display pages on your watchlist that have changed since your last visit in bold". So this issue is less critical.

MMiller_WMF subscribed.Oct 19 2018, 5:28 PM
MMiller_WMF added subscribers: kostajh, SBisson, kaldari, Catrope.Oct 19 2018, 5:37 PM

Thanks for filing this, @Xaosflux and @Doc_James. We're looking into this now. cc @Catrope @SBisson @kostajh @kaldari.

greg triaged this task as Unbreak Now! priority.Oct 19 2018, 5:41 PM
greg added a parent task: T191072: 1.32.0-wmf.26 deployment blockers.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptOct 19 2018, 5:41 PM
Daimona added a comment.Oct 19 2018, 5:49 PM

FWIW, I tried a git bisect but ended up with the wrong commit (i.e. not the one which introduced the problem). This may be because I erroneously typed "good" instead of "bad" or vice versa, or there may be another explanation: in order to speed up the bisect, I always used the same composer and vendor, without running update.php. This could mean that the problem is in an external library (in this case, the obvious choice would be OOUI).

greg lowered the priority of this task from Unbreak Now! to High.Oct 19 2018, 5:54 PM
greg subscribed.
In T207472#4681250, @Doc_James wrote:

Managed to figure out an okay work around by turning on the gadget "Display pages on your watchlist that have changed since your last visit in bold". So this issue is less critical.

greg removed a parent task: T191072: 1.32.0-wmf.26 deployment blockers.Oct 19 2018, 5:54 PM
Catrope added a comment.Oct 19 2018, 5:55 PM

Thanks @Daimona . I was about to start bisecting myself, but I'll try the OOUI release first with this knowledge.

My testing so far confirms that this is a regression between wmf.24 and wmf.26.

wmf.24:

Screenshot from 2018-10-19 10-52-28.png (88×389 px, 12 KB)

wmf.26:

Screenshot from 2018-10-19 10-52-19.png (91×406 px, 12 KB)

However, you can work around this by enabling this gadget:

Screenshot from 2018-10-19 10-54-06.png (28×807 px, 10 KB)

Which highlights seen changes in bold, even though the radio buttons are still broken:

Screenshot from 2018-10-19 10-53-46.png (191×440 px, 25 KB)

Anomie subscribed.Oct 19 2018, 5:58 PM

Locally bisecting gave me rMWd6ff526ae39b: RCFilters: Improve circle mixin and change to new standard icon size as the first bad commit.

Catrope added a comment.Oct 19 2018, 6:02 PM
In T207472#4681416, @Anomie wrote:

Locally bisecting gave me rMWd6ff526ae39b: RCFilters: Improve circle mixin and change to new standard icon size as the first bad commit.

Thanks! I suspected that. Now looking at the difference in generated CSS and figuring out how to patch this with a [[MediaWiki:Common.css]] change.

Catrope added a comment.Oct 19 2018, 6:10 PM

I've put a temporary workaround on enwiki: https://en.wikipedia.org/w/index.php?title=MediaWiki%3AGadget-WatchlistBase.css&type=revision&diff=864822816&oldid=803487199

Catrope added a comment.Oct 19 2018, 6:26 PM

Found the cause: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/424848/12/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ChangesListWrapperWidget.less#83

TheresNoTime subscribed.Oct 19 2018, 6:59 PM
gerritbot subscribed.Oct 19 2018, 7:21 PM

Change 468633 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Fix completely broken highlight circles

https://gerrit.wikimedia.org/r/468633

gerritbot added a project: Patch-For-Review.Oct 19 2018, 7:21 PM
gerritbot added a comment.Oct 19 2018, 7:45 PM

Change 468633 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Fix completely broken highlight circles

https://gerrit.wikimedia.org/r/468633

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 19 2018, 8:01 PM
gerritbot added a comment.Oct 19 2018, 8:01 PM

Change 468636 had a related patch set uploaded (by 20after4; owner: Catrope):
[mediawiki/core@wmf/1.32.0-wmf.26] RCFilters: Fix completely broken highlight circles

https://gerrit.wikimedia.org/r/468636

gerritbot added a comment.Oct 19 2018, 8:20 PM

Change 468636 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.26] RCFilters: Fix completely broken highlight circles

https://gerrit.wikimedia.org/r/468636

Stashbot subscribed.Oct 19 2018, 8:33 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-19T20:33:37Z] <twentyafterfour> deployed RCFilters: Fix completely broken highlight circles refs T207472

gerritbot added a comment.Oct 19 2018, 8:41 PM

Change 468672 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Fix highlight circles for unseen changes

https://gerrit.wikimedia.org/r/468672

MMiller_WMF added a comment.Oct 19 2018, 8:58 PM

The fix has been deployed to production, and I updated English Wikipedia Village Pump here. There is only one outstanding issue: when using highlighting, all highlighted rows have filled-in circles, whether they are seen or unseen. The fix for that has been written by @Catrope and will be deployed on Monday. Thank you for your patience as we worked on this, and please let us know if anything else is amiss.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 19 2018, 9:01 PM
gerritbot added a comment.Oct 19 2018, 10:58 PM

Change 468672 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Fix highlight circles for unseen changes

https://gerrit.wikimedia.org/r/468672

Abelmoschus_Esculentus subscribed.Oct 20 2018, 12:01 PM
Trizek-WMF renamed this task from Improved watchlist is no longer showing seen indicators and point types have become small to Watchlist is no longer showing seen indicators and point types have become small.Oct 22 2018, 8:25 AM
Trizek-WMF added a project: User-notice.
gerritbot added a comment.Oct 22 2018, 2:12 PM

Change 468987 had a related patch set uploaded (by Bartosz Dziewoński; owner: Catrope):
[mediawiki/core@REL1_32] RCFilters: Fix completely broken highlight circles

https://gerrit.wikimedia.org/r/468987

gerritbot added a comment.Oct 22 2018, 2:13 PM

Change 468988 had a related patch set uploaded (by Bartosz Dziewoński; owner: Catrope):
[mediawiki/core@REL1_32] RCFilters: Fix highlight circles for unseen changes

https://gerrit.wikimedia.org/r/468988

gerritbot added a comment.Oct 22 2018, 2:32 PM

Change 468987 merged by jenkins-bot:
[mediawiki/core@REL1_32] RCFilters: Fix completely broken highlight circles

https://gerrit.wikimedia.org/r/468987

gerritbot added a comment.Oct 22 2018, 2:40 PM

Change 468988 merged by jenkins-bot:
[mediawiki/core@REL1_32] RCFilters: Fix highlight circles for unseen changes

https://gerrit.wikimedia.org/r/468988

ReleaseTaggerBot edited projects, added MW-1.32-notes; removed MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 22 2018, 3:00 PM
SBisson assigned this task to Catrope.Oct 22 2018, 3:29 PM
SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
SBisson moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Oct 22 2018, 5:45 PM

Change 469040 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@wmf/1.32.0-wmf.26] RCFilters: Fix highlight circles for unseen changes

https://gerrit.wikimedia.org/r/469040

gerritbot added a comment.Oct 22 2018, 6:23 PM

Change 469040 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.26] RCFilters: Fix highlight circles for unseen changes

https://gerrit.wikimedia.org/r/469040

Stashbot added a comment.Oct 22 2018, 6:38 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-22T18:38:22Z] <jforrester@deploy1001> Synchronized php-1.32.0-wmf.26/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.ChangesListWrapperWidget.highlightCircles.seenunseen.less: SWAT RCFIlters: Fix highlight circles for unseen changes T207472 (duration: 00m 46s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed MW-1.32-notes.Oct 22 2018, 7:00 PM
Johan moved this task from To Triage to Announce in next Tech/News on the User-notice board.Oct 23 2018, 12:55 AM
Tomybrz subscribed.Oct 23 2018, 3:11 PM

(for archival : oldid=865341037)

Tomybrz awarded a token.Oct 23 2018, 3:15 PM
Etonkovidova closed this task as Resolved.Oct 24 2018, 5:20 PM
Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Oct 25 2018, 10:19 PM
Liuxinyu970226 unsubscribed.Oct 27 2018, 7:42 AM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Nov 1 2018, 9:38 AM
RandomDSdevel awarded a token.Nov 7 2018, 2:50 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 6:34 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL