Page MenuHomePhabricator

TemplateStyles CSS appears in notification text
Open, Needs TriagePublic

Description

(see the text in the middle of the image)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2019, 12:00 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 25 2019, 12:01 PM
TerraCodes updated the task description. (Show Details)Mar 25 2019, 12:01 PM
Anomie moved this task from Up next to External on the TemplateStyles board.Mar 25 2019, 1:43 PM
Tgr added a subscriber: Tgr.

I think this is a bug in RemexStripTagHandler (called via EchoMentionPresentationModel::getBodyMessage() -> EchoDiscussionParser::getTextSnippet() -> Sanitizer::stripAllTags()) which IMO tends to be used as a rough equivalent of Element.innerText and should behave somewhat along those lines (specifically, hidden elements should be ignored).

Tgr added a comment.Jul 24 2019, 11:39 AM

Even more pronounced in emails:

Tgr removed a project: RemexHtml.

I think this is a bug in RemexStripTagHandler

Maybe not bug as such, but poor DX. Made that a separate task: T228856: RemexStripTagHandler should strip <style> contents