Page MenuHomePhabricator
Create Task
Maniphest T266136

Update CI config once geoip2 is available
Closed, ResolvedPublic2 Estimated Story PointsDec 15 2020
Actions

Description

IPInfo uses the geoip2 library, which will be added in T174553/T269475, following a security readiness review: T262963.

Until then Phan CI fails, blocking new commits to the IPInfo repo, so we either need to disable Phan temporarily or use composer in CI temporarily.

We should reinstate the original config once geoip2 is available in mediawiki/vendor.

Details

Due Date
Dec 15 2020, 5:00 AM
SubjectRepoBranchLines +/-
Zuul: [mediawiki/extensions/IPInfo] Re-enable phan, move to prod sectionintegration/configmaster+6 -8
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedSTranT298955 Return different data from IPInfo api based on context [M]
 ResolvedSTranT300825 IPInfo logger should queue a logging job instead of writing directly
 OpenNoneT285977 IP Info
 ResolvedNiharikaT287648 Reviews and deployment
 ResolvedTchandersT260597 Deploy IP Info extension to all wikis (as a beta feature)
 ResolvedNiharikaT261372 Replace mock data returned from API endpoint with live data
 Resolved• AGueyteT306212 Remove AdHocDebug logging for investigating duplicate log entries
 ResolvedSTranT296480 Enable the ipinfo instrument in production
 ResolvedSTranT304438 Enable IP Info instrumentation in testwiki
 Resolved• AGueyteT307493 Update IPInfo disclaimer per Legal
 ResolvedNiharikaT292755 Epic: IP Info access
 ResolvedSTranT292842 Log when the user's access level changes
 ResolvedNiharikaT263756 Create a table to store which users have access to IPInfo, and the timestamp when access was granted [L]
 ResolvedTchandersT264795 Decide how we want to store how we log which users have access to IP Info [8 hours]
 InvalidNoneT291827 Create IPInfo access manager
 InvalidNoneT291854 Create revoke user access maintenance script
 InvalidNoneT296186 Create a group that revokes all ipinfo* rights
 ResolvedSTranT264150 User needs to request access to IP information [L]
 ResolvedSTranT291582 Implement condition agreements in Special:Preferences [M]
 ResolvedSpikephuedxT291583 [SPIKE] Check that IPInfo-related user properties aren't replicated to publicly accessible databases [8H]
 ResolvedSTranT294658 Create a log entry when the RevisionHandler is called
 Resolved• TThoabalaT294657 Create a log entry when the LogHandler is called
 ResolvedphuedxT294680 IP Info: Create a logger function to be used in both the popup and accordion presenters [M]
 DeclinedTchandersT296184 Automatically promote users to the group that grants basic rights
 ResolvedSTranT296085 Create a group that grants basic ipinfo* rights
 ResolvedSTranT296499 Grant certain groups the ipinfo-view-full right
 ResolvedTchandersT260598 Deploy IP Info extension to test.wikipedia.org
 ResolvedTchandersT260599 Deploy IP Info extension to beta cluster
 ResolvedDec 15 2020TchandersT266136 Update CI config once geoip2 is available
 ResolvedTchandersT269475 Add geoip2/geoip2 library to mediawiki/vendor
 ResolvedTchandersT260602 Complete the necessary reviews for the IP Info extension
 InvalidNoneT260601 Remove the static mock data from the popup and make a request to the API endpoint for dynamic mock data
 ResolvedSep 22 2020TchandersT260603 Create an API endpoint that accepts a log id or revision id and returns mock data about the IP address
 ResolvedSep 22 2020TchandersT260604 Display a popup with fixed mock data for an IP address on the specified page(s)
 ResolvedTchandersT260605 Add IP Info extension to translatewiki.net
 ResolveddbarrattT260607 Deploy the IP Info extension to The Good Place
 ResolvedTchandersT260609 Create a basic extension.json file and a new wikipage for the IP Info extension
 ResolveddbarrattT260611 Request a repository for the IP Info Extension
 ResolvedTchandersT260610 Request the necessary reviews of the IP Info extension
 ResolvedsbassettT260822 Security review of IP Info extension
 ResolvedNiharikaT260821 Performance review of IP Info extension
 InvalidNoneT270347 Remove 'ipinfo' right from administrators on the Beta Cluster
 StalledNoneT309318 Can global sysops have ipinfo-view-full and ipinfo-view-log access?
 ResolvedSecurityUrbanecmT309411 sysop access to ipinfo logs can leak IP addresses that sysops should not have access to
 ResolvedUrbanecmT309928 Remove `ipinfo-view-log` from sysops

Event Timeline

Tchanders created this task.Oct 21 2020, 2:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2020, 2:24 PM
Tchanders added a comment.Oct 21 2020, 2:26 PM

This is a deployment blocker.

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Oct 21 2020, 4:05 PM
ARamirez_WMF set the point value for this task to 2.Oct 21 2020, 4:11 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Dec 2 2020, 6:03 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
ARamirez_WMF set Due Date to Dec 15 2020, 5:00 AM.Dec 2 2020, 6:05 PM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".
Tchanders added a subtask: T269475: Add geoip2/geoip2 library to mediawiki/vendor.Dec 4 2020, 8:16 PM
Tchanders added a parent task: T260599: Deploy IP Info extension to beta cluster.
gerritbot added a comment.Dec 4 2020, 9:45 PM

Change 645440 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[integration/config@master] Re-enable phan for IPInfo extension

https://gerrit.wikimedia.org/r/645440

gerritbot added a project: Patch-For-Review.Dec 4 2020, 9:45 PM
Tchanders claimed this task.Dec 4 2020, 9:47 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Reedy closed subtask T269475: Add geoip2/geoip2 library to mediawiki/vendor as Resolved.Dec 4 2020, 11:06 PM
Reedy updated the task description. (Show Details)
gerritbot added a comment.Dec 4 2020, 11:12 PM

Change 645440 merged by jenkins-bot:
[integration/config@master] Zuul: [mediawiki/extensions/IPInfo] Re-enable phan, move to prod section

https://gerrit.wikimedia.org/r/645440

Stashbot added a comment.Dec 4 2020, 11:12 PM

Mentioned in SAL (#wikimedia-releng) [2020-12-04T23:12:42Z] <James_F> Zuul: [mediawiki/extensions/IPInfo] Re-enable phan, move to prod section T266136

Jdforrester-WMF closed this task as Resolved.Dec 4 2020, 11:13 PM
Tchanders moved this task from Code Review 🔍 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.Dec 4 2020, 11:49 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 5 2020, 12:10 AM
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 8:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits