Page MenuHomePhabricator
Create Task
Maniphest T260599

Deploy IP Info extension to beta cluster
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

The IP Info extension should be deployed to the beta cluster.

Details

SubjectRepoBranchLines +/-
Add IPInfo extension config to InitialiseSettings-labs.phpoperations/mediawiki-configmaster+14 -0
Load IPInfo extension in CommonSettings.phpoperations/mediawiki-configmaster+4 -0
Add IPInfo config to InitialiseSettings.phpoperations/mediawiki-configmaster+6 -0
extension-list: Add IPInfo extensionoperations/mediawiki-configmaster+1 -0
make-release: Start branching IPInfo extension for productionmediawiki/tools/releasemaster+1 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedSTranT298955 Return different data from IPInfo api based on context [M]
 ResolvedSTranT300825 IPInfo logger should queue a logging job instead of writing directly
 OpenNoneT285977 IP Info
 Resolved• NiharikaT287648 Reviews and deployment
 ResolvedTchandersT260597 Deploy IP Info extension to all wikis (as a beta feature)
 Resolved• NiharikaT261372 Replace mock data returned from API endpoint with live data
 Resolved• AGueyteT306212 Remove AdHocDebug logging for investigating duplicate log entries
 ResolvedSTranT296480 Enable the ipinfo instrument in production
 ResolvedSTranT304438 Enable IP Info instrumentation in testwiki
 Resolved• AGueyteT307493 Update IPInfo disclaimer per Legal
 Resolved• NiharikaT292755 Epic: IP Info access
 ResolvedSTranT292842 Log when the user's access level changes
 Resolved• NiharikaT263756 Create a table to store which users have access to IPInfo, and the timestamp when access was granted [L]
 ResolvedTchandersT264795 Decide how we want to store how we log which users have access to IP Info [8 hours]
 InvalidNoneT291827 Create IPInfo access manager
 InvalidNoneT291854 Create revoke user access maintenance script
 InvalidNoneT296186 Create a group that revokes all ipinfo* rights
 ResolvedSTranT264150 User needs to request access to IP information [L]
 ResolvedSTranT291582 Implement condition agreements in Special:Preferences [M]
 ResolvedSpikephuedxT291583 [SPIKE] Check that IPInfo-related user properties aren't replicated to publicly accessible databases [8H]
 ResolvedSTranT294658 Create a log entry when the RevisionHandler is called
 Resolved• TThoabalaT294657 Create a log entry when the LogHandler is called
 ResolvedphuedxT294680 IP Info: Create a logger function to be used in both the popup and accordion presenters [M]
 DeclinedTchandersT296184 Automatically promote users to the group that grants basic rights
 ResolvedSTranT296085 Create a group that grants basic ipinfo* rights
 ResolvedSTranT296499 Grant certain groups the ipinfo-view-full right
 ResolvedTchandersT260598 Deploy IP Info extension to test.wikipedia.org
 ResolvedTchandersT260599 Deploy IP Info extension to beta cluster
 ResolvedsbassettT262963 Security Readiness Review For geoip2/geoip2
 ResolvedDec 15 2020TchandersT266136 Update CI config once geoip2 is available
 ResolvedTchandersT269475 Add geoip2/geoip2 library to mediawiki/vendor
 ResolvedTchandersT260602 Complete the necessary reviews for the IP Info extension
 InvalidNoneT260601 Remove the static mock data from the popup and make a request to the API endpoint for dynamic mock data
 ResolvedSep 22 2020TchandersT260603 Create an API endpoint that accepts a log id or revision id and returns mock data about the IP address
 ResolvedSep 22 2020TchandersT260604 Display a popup with fixed mock data for an IP address on the specified page(s)
 ResolvedTchandersT260605 Add IP Info extension to translatewiki.net
 ResolveddbarrattT260607 Deploy the IP Info extension to The Good Place
 ResolvedTchandersT260609 Create a basic extension.json file and a new wikipage for the IP Info extension
 ResolveddbarrattT260611 Request a repository for the IP Info Extension
 ResolvedTchandersT260610 Request the necessary reviews of the IP Info extension
 ResolvedsbassettT260822 Security review of IP Info extension
 Resolved• NiharikaT260821 Performance review of IP Info extension
 InvalidNoneT270347 Remove 'ipinfo' right from administrators on the Beta Cluster
 StalledNoneT309318 Can global sysops have ipinfo-view-full and ipinfo-view-log access?
 ResolvedSecurityUrbanecmT309411 sysop access to ipinfo logs can leak IP addresses that sysops should not have access to
 ResolvedUrbanecmT309928 Remove `ipinfo-view-log` from sysops

Event Timeline

dbarratt created this task.Aug 17 2020, 7:47 PM
dbarratt updated the task description. (Show Details)
dbarratt removed a subtask: T260601: Remove the static mock data from the popup and make a request to the API endpoint for dynamic mock data.Aug 17 2020, 7:57 PM
• Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Sep 17 2020, 7:36 PM
ARamirez_WMF set the point value for this task to 3.Nov 18 2020, 5:39 PM
dbarratt unsubscribed.Nov 18 2020, 5:41 PM
• Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Nov 20 2020, 5:50 PM
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Nov 23 2020, 7:16 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
Tchanders claimed this task.Nov 25 2020, 3:05 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
• Niharika triaged this task as Medium priority.Nov 30 2020, 8:02 PM
Tchanders updated the task description. (Show Details)Dec 1 2020, 2:13 PM
gerritbot added a comment.Dec 1 2020, 3:16 PM

Change 644538 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/tools/release@master] make-release: Start branching IPInfo extension for production

https://gerrit.wikimedia.org/r/644538

gerritbot added a project: Patch-For-Review.Dec 1 2020, 3:16 PM
Tchanders added a subscriber: • Niharika.Dec 1 2020, 3:52 PM

@Niharika Do we want to enable this on every wiki in the beta cluster, or just specific ones?

gerritbot added a comment.Dec 1 2020, 4:09 PM

Change 644548 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[operations/mediawiki-config@master] extension-list: Add IPInfo extension

https://gerrit.wikimedia.org/r/644548

gerritbot added a comment.Dec 1 2020, 4:09 PM

Change 644549 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[operations/mediawiki-config@master] Add IPInfo config to InitialiseSettings.php

https://gerrit.wikimedia.org/r/644549

gerritbot added a comment.Dec 1 2020, 4:09 PM

Change 644550 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[operations/mediawiki-config@master] Add IPInfo extension config to InitialiseSettings-labs.php

https://gerrit.wikimedia.org/r/644550

gerritbot added a comment.Dec 1 2020, 4:09 PM

Change 644551 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[operations/mediawiki-config@master] Load IPInfo extension in CommonSettings.php

https://gerrit.wikimedia.org/r/644551

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Dec 1 2020, 4:11 PM
Tchanders edited subtasks, added: T262963: Security Readiness Review For geoip2/geoip2; removed: T260602: Complete the necessary reviews for the IP Info extension.Dec 1 2020, 4:14 PM
Urbanecm subscribed.Dec 2 2020, 12:11 AM

@Tchanders Note the extension needs to be branched for at least two weeks before being deployed (even to beta), see https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment#Deploy_to_Beta_Cluster.

sbassett changed the status of subtask T262963: Security Readiness Review For geoip2/geoip2 from Stalled to Open.Dec 3 2020, 8:42 PM
sbassett closed subtask T262963: Security Readiness Review For geoip2/geoip2 as Resolved.Dec 3 2020, 10:50 PM
Tchanders added a subtask: T266136: Update CI config once geoip2 is available.Dec 4 2020, 8:16 PM
Tchanders updated the task description. (Show Details)Dec 4 2020, 9:55 PM
Jdforrester-WMF closed subtask T266136: Update CI config once geoip2 is available as Resolved.Dec 4 2020, 11:13 PM
gerritbot added a comment.Dec 4 2020, 11:15 PM

Change 644538 merged by jenkins-bot:
[mediawiki/tools/release@master] make-release: Start branching IPInfo extension for production

https://gerrit.wikimedia.org/r/644538

Jdforrester-WMF updated the task description. (Show Details)Dec 4 2020, 11:20 PM
Jdforrester-WMF updated the task description. (Show Details)
Tchanders updated the task description. (Show Details)Dec 17 2020, 1:06 PM
gerritbot added a comment.Dec 17 2020, 7:05 PM

Change 644548 merged by jenkins-bot:
[operations/mediawiki-config@master] extension-list: Add IPInfo extension

https://gerrit.wikimedia.org/r/644548

Stashbot added a comment.Dec 17 2020, 7:08 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-17T19:08:02Z] <urbanecm@deploy1001> Synchronized wmf-config/extension-list: 5180f12ee74feae1024ae4ec45e19cd775c805b2: extension-list: Add IPInfo extension (T260599) (duration: 01m 03s)

gerritbot added a comment.Dec 17 2020, 7:08 PM

Change 644549 merged by jenkins-bot:
[operations/mediawiki-config@master] Add IPInfo config to InitialiseSettings.php

https://gerrit.wikimedia.org/r/644549

Stashbot added a comment.Dec 17 2020, 7:09 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-17T19:09:50Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: 54046876d2217200618236e22f77d2138345bb92: Add IPInfo config to InitialiseSettings.php [noop for prod] (T260599) (duration: 01m 03s)

gerritbot added a comment.Dec 17 2020, 7:10 PM

Change 644551 merged by jenkins-bot:
[operations/mediawiki-config@master] Load IPInfo extension in CommonSettings.php

https://gerrit.wikimedia.org/r/644551

gerritbot added a comment.Dec 17 2020, 7:11 PM

Change 644550 merged by jenkins-bot:
[operations/mediawiki-config@master] Add IPInfo extension config to InitialiseSettings-labs.php

https://gerrit.wikimedia.org/r/644550

Stashbot added a comment.Dec 17 2020, 7:12 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-17T19:12:08Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: 2c1b339b47454e5df4f78b87ca577afb1d2f32af: Load IPInfo extension in CommonSettings.php [noop for prod] (T260599) (duration: 01m 04s)

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Dec 18 2020, 1:46 PM
Tchanders added a comment.EditedDec 19 2020, 8:50 PM

Message translations have not come through to beta due to T270560

@dom_walden It's probably not worth testing this until that's fixed.

Tchanders added a subscriber: dom_walden.Dec 19 2020, 9:09 PM
Tchanders added a comment.Dec 21 2020, 6:07 PM

@dom_walden It's probably not worth testing this until that's fixed.

Update: it's fixed now, translations are there.

Tchanders updated the task description. (Show Details)Dec 21 2020, 6:11 PM
Tchanders moved this task from QA/Testing 🐞 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.Dec 22 2020, 6:07 AM

Moving this on from QA in anticipation of the column filling up, and because this will be tested implicitly as other IPInfo tasks are tested on beta.

• Prtksxna subscribed.Jan 6 2021, 3:27 AM

I can see the box and popup on Beta! F33986809 F33986807

• Prtksxna moved this task from Design Review 🔬 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.Jan 6 2021, 3:27 AM
• Niharika closed this task as Resolved.Jan 6 2021, 3:40 AM
• Niharika added a parent task: T287648: Reviews and deployment.Jul 28 2021, 11:34 PM
Tchanders mentioned this in T306909: Prerequisites to deploying SimilarEditors to the beta cluster.Apr 26 2022, 4:44 PM
• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 8:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL