Page MenuHomePhabricator
Create Task
Maniphest T272225

Special:Contributions no longer accepts display form of IPv6 addresses
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to reproduce:

  1. View an edit, such as this.
  2. Copy the displayed IP address, e.g. from a discussion comment signature, or from the diff, or the history page, or recent changes, or elsewhere in the interface. 2600:1004:b14a:5ddd:3ebe:bba4:bfba:f37e
  3. Open Special:Contributions and paste it in the form. Or, as power user, one might have an existing contributions query open and paste it in the address bar as /wiki/Special:Contributions/ <paste here>

Actual results:

https://en.wikipedia.org/wiki/Special:Contributions/2600:1004:b14a:5ddd:3ebe:bba4:bfba:f37e

Nothing, no edits?

Expected results:

The edits in question.

Notes:

It turns that the query only works when the address is in the internal uppercase format, which is generally not displayed to users. So the above edit is accessible via the following instead:

https://en.wikipedia.org/wiki/Special:Contributions/2600:1004:B14A:5DDD:3EBE:BBA4:BFBA:F37E

Interestingly, even the "actual" result link above (lowercase IP) has a heading that says it is displaying results for the uppercase IP. It says "//2600:1004:B14A://…". The two pages look identical, except that one is broken and the other isn't.

cs.wikipedia.org example:

which is the very same IPv6 address, just lowercase.

Details

SubjectRepoBranchLines +/-
Normalize IP addresses before writing/reading actor.actor_namemediawiki/coremaster+23 -11
Special:Contributions: Pass normalized target to ContribsPagermediawiki/coremaster+13 -7
Pass normalized target username to contributionsSub()mediawiki/extensions/GlobalContribsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Urbanecm created this task.Jan 16 2021, 5:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2021, 5:37 PM
Amorymeltzer subscribed.Jan 16 2021, 7:46 PM
DannyS712 subscribed.Jan 17 2021, 6:14 AM
L235 subscribed.Jan 17 2021, 8:19 AM

This is a big issue and I hope that it receives priority for fixing.

Mz7 subscribed.Jan 17 2021, 8:21 AM
JJMC89 subscribed.Jan 17 2021, 9:44 AM
Umherirrender edited projects, added Regression; removed MediaWiki-Core-Revision-backend.Jan 17 2021, 10:02 AM
Umherirrender subscribed.

Possibly regression from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/589659, because the target is user input for the target is used and not normalized by Title::getText (which handles the case part in ips)

gerritbot added a comment.Jan 17 2021, 11:22 AM

Change 656605 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Special:Contributions: Account for IP normalization

https://gerrit.wikimedia.org/r/656605

gerritbot added a project: Patch-For-Review.Jan 17 2021, 11:22 AM
Ammarpad claimed this task.Jan 17 2021, 11:30 AM
GeneralNotability subscribed.Jan 17 2021, 5:50 PM
Krinkle renamed this task from Special:Contributions no longer ignores case on IPv6 addresses to Special:Contributions no longer accepts display form of IPv6 addresses.Jan 17 2021, 7:50 PM
Krinkle added a project: Growth-Team.
Krinkle updated the task description. (Show Details)
Krinkle moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.
ToBeFree subscribed.Jan 24 2021, 5:33 AM

This is a serious issue still remaining in place. I searched for a template error first, then noticed that this is a MediaWiki regression. It causes problems at enwiki's vandalism report page, where bots like DatBot automatically create urgent reports with lowercase IPv6 addresses that are incorrectly interpreted as non-actionable.

ToBeFree awarded a token.Jan 24 2021, 5:33 AM
Base subscribed.Jan 24 2021, 5:42 AM
Xaosflux subscribed.Jan 25 2021, 5:45 PM
Trizek-WMF added a project: User-notice.Jan 25 2021, 6:56 PM
MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jan 25 2021, 6:56 PM
MMiller_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
MMiller_WMF added subscribers: Tgr, MMiller_WMF.

@Tgr is going to code review the patch this week.

Tgr added a comment.Jan 26 2021, 2:52 AM
This comment was removed by Tgr.
Tgr added a comment.Jan 26 2021, 4:01 AM

The uppercase variant is somewhat standard: https://en.wikipedia.org/wiki/User:2600:1004:b14a:5ddd:3ebe:bba4:bfba:f37e for example redirects to it. This is handled by MediaWikiTitleCodec sending User namespace page names through IPUtils::sanitizeIP (which might perform other changes as well, since IPv6 addresses have abbreviated forms).

I think the breakage is caused when ContribPager turns the target string into a User and passes it to ActorMigration::getWhere which uses it as is to match actor_name. That broke during the commit @Urbanecm indicated.

It would be nice to handle this on a low level to avoid future problems, and normalize IPs in User::$name (seems scary) or in ActorMigration::getWhere and ActorMigration::getNewActorId (less scary).

gerritbot added a comment.Jan 26 2021, 4:34 AM

Change 658486 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Normalize IP addresses before writing/reading actor.actor_name

https://gerrit.wikimedia.org/r/658486

Tgr added a project: Platform Engineering.Jan 26 2021, 4:36 AM

Adding the platform team for visibility since they maintain User and ActorMigration.

gerritbot added a comment.Jan 26 2021, 10:36 AM

Change 656611 had a related patch set uploaded (by Gergő Tisza; owner: Ammarpad):
[mediawiki/extensions/GlobalContribs@master] Pass normalized target username to contributionsSub()

https://gerrit.wikimedia.org/r/656611

gerritbot added a comment.Jan 26 2021, 10:57 AM

Change 656605 merged by jenkins-bot:
[mediawiki/core@master] Special:Contributions: Pass normalized target to ContribsPager

https://gerrit.wikimedia.org/r/656605

gerritbot added a comment.Jan 26 2021, 10:57 AM

Change 656611 merged by jenkins-bot:
[mediawiki/extensions/GlobalContribs@master] Pass normalized target username to contributionsSub()

https://gerrit.wikimedia.org/r/656611

• Urbanecm added a comment.Jan 26 2021, 10:59 AM

@Tgr Thanks! Should we backport?

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 26 2021, 11:00 AM
Tgr mentioned this in rEGCN76f049b9d776: Pass normalized target username to contributionsSub().Jan 26 2021, 11:04 AM
Trizek-WMF moved this task from To Triage to In current Tech/News draft on the User-notice board.Jan 26 2021, 3:22 PM
• holger.knust triaged this task as Low priority.Jan 26 2021, 9:27 PM
• holger.knust removed a project: Platform Engineering.
• holger.knust subscribed.

Untagging PET

Tgr added a comment.Jan 27 2021, 2:41 AM
In T272225#6776780, @Urbanecm wrote:

@Tgr Thanks! Should we backport?

This is a minor bug and the regression happened three weeks ago, it can wait another week IMO.

gerritbot added a comment.Jan 29 2021, 12:17 PM

Change 658486 merged by jenkins-bot:
[mediawiki/core@master] Normalize IP addresses before writing/reading actor.actor_name

https://gerrit.wikimedia.org/r/658486

Maintenance_bot removed a project: Patch-For-Review.Jan 29 2021, 1:10 PM
Ammarpad closed this task as Resolved.Jan 29 2021, 2:51 PM
Ammarpad raised the priority of this task from Low to Medium.
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Feb 4 2021, 8:23 AM
Thibaut120094 subscribed.Feb 4 2021, 8:29 AM
Thibaut120094 added a comment.EditedFeb 6 2021, 8:26 AM

Um, has the update been deployed? The bug is still present on enwiki, cswiki (links in OP) and frwiki:

https://fr.wikipedia.org/wiki/Spécial:Contributions/2a02:21b0:644f:f7f2:61df:5f07:a3b1:a49f
https://fr.wikipedia.org/wiki/Spécial:Contributions/2A02:21B0:644F:F7F2:61DF:5F07:A3B1:A49F

kostajh subscribed.Feb 6 2021, 8:34 AM
In T272225#6808311, @Thibaut120094 wrote:

Um, has the update been deployed? The bug is still present on enwiki, cswiki (links in OP) and frwiki:

https://fr.wikipedia.org/wiki/Spécial:Contributions/2a02:21b0:644f:f7f2:61df:5f07:a3b1:a49f
https://fr.wikipedia.org/wiki/Spécial:Contributions/2A02:21B0:644F:F7F2:61DF:5F07:A3B1:A49F

Not yet, wmf.29 had some issues and is not rolled out yet (T271343)

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits