Page MenuHomePhabricator
Create Task
Maniphest T277675

Add native support for ES2016-ES2017 to the minifier
Closed, ResolvedPublic
Actions

Description

Now that we have done T272104: Allow modules to opt-in to ES6 syntax support, we should consider doing the same thing for ES2016 and ES2017.

We will have to consider the benefits of new language features in a given ES version versus the costs of dropping browsers that don't support it, and the complexity of feature detection.

Notable syntax features in later versions:

Later: T386530: Add native support for ES2018-ES2020 to the minifier

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jun 21 2024, 11:36 PM

Change #1048590 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/Minify@master] JavaScriptMinifier: Add support for `**=` operator (ECMAScript 2016)

https://gerrit.wikimedia.org/r/1048590

gerritbot added a project: Patch-For-Review.Jun 21 2024, 11:36 PM
gerritbot added a comment.Jun 24 2024, 8:18 PM

Change #1048590 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Add support for `**=` operator (ECMAScript 2016)

https://gerrit.wikimedia.org/r/1048590

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2024, 8:30 PM
Krinkle updated the task description. (Show Details)Aug 6 2024, 10:14 PM
Krinkle updated the task description. (Show Details)
Catrope added a comment.Aug 6 2024, 10:15 PM

Some things related to async functions that don't work yet:

  • Async function as the first alternative in a ternary: foo = bar ? async function x() {} : 42
  • Async function as an object property value: foo = { bar: async function x() {} }

In both of these cases, if you minify them with maxLineLength=1, the output puts async and function on separate lines, which is a syntax error.

Krinkle updated the task description. (Show Details)Aug 6 2024, 10:16 PM
Xover mentioned this in T370304: Bursts of occasional severe contention on s4 (commonswiki) primary mariadb causing recurrent user-facing outages on all wikis.Aug 31 2024, 8:19 AM
Krinkle mentioned this in T373990: ResourceLoader ignores @nomin pragma for extension provided javascript.Sep 13 2024, 11:05 PM
Krinkle updated the task description. (Show Details)Oct 16 2024, 7:43 PM
Od1n added a comment.EditedOct 25 2024, 2:07 AM

T371938 (gerrit 1060177), that you created at the same time, adds (in addition to the previously existing PAREN_EXPRESSION_OP_NO_NL state) EXPRESSION_TERNARY_NO_NL, PAREN_EXPRESSION_NO_NL and PROPERTY_EXPRESSION_NO_NL states. These might help to add support for the remaining async functions.

I feel we are soooo close to have full ES8 support, thus async/await!

Bugreporter mentioned this in T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).Nov 20 2024, 9:58 AM
ExE-Boss subscribed.Dec 3 2024, 2:22 AM
Diskdance subscribed.Dec 4 2024, 8:24 AM
Novem_Linguae mentioned this in T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).Dec 4 2024, 9:47 PM
Bugreporter subscribed.Dec 5 2024, 12:36 AM

After T368204: Consider removing new-line insertion from JavaScriptMinifier Minifier adds no new lines. So this one T277675#10046960 should no longer causes problems. We should focus on when new lines are required but ignored by Minifier.

Novem_Linguae renamed this task from Add native support for ES2016-ES2020 or higher versions to Add native support for ES2016-ES2020 or higher versions to the minifier.Dec 11 2024, 3:57 AM
Novem_Linguae updated the task description. (Show Details)Dec 11 2024, 4:05 AM
SD0001 added a subtask: T382291: ES7 class properties minification bug.Dec 17 2024, 4:27 PM
Catrope mentioned this in T382391: Transition to ES2016 for leaner codebase and improved compatibility.Dec 18 2024, 2:32 PM
Jdforrester-WMF removed a subtask: T382291: ES7 class properties minification bug.Dec 19 2024, 6:23 PM
ekrem subscribed.Jan 8 2025, 1:19 PM
Nemoralis subscribed.Jan 8 2025, 2:41 PM
JTweed-WMF edited projects, added MediaWiki-Platform-Team (Roadmap); removed MediaWiki-Platform-Team.Jan 22 2025, 3:46 PM
JTweed-WMF moved this task from Now => Move to Inbox to Parking Lot on the MediaWiki-Platform-Team (Roadmap) board.
Alex44019 subscribed.Jan 24 2025, 11:03 PM
MHorsey-WMF subscribed.Jan 27 2025, 7:32 PM
Krinkle renamed this task from Add native support for ES2016-ES2020 or higher versions to the minifier to Add native support for ES2016-ES2017 to the minifier.Feb 14 2025, 11:37 PM
Krinkle mentioned this in T386530: Add native support for ES2018-ES2020 to the minifier.
Krinkle updated the task description. (Show Details)
Escargot_rouge subscribed.Feb 24 2025, 1:58 PM
Krinkle assigned this task to Hokwelum.Feb 25 2025, 8:29 PM
Krinkle raised the priority of this task from Low to Medium.
Krinkle updated the task description. (Show Details)Mar 18 2025, 6:29 PM
Krinkle updated the task description. (Show Details)Mar 21 2025, 7:09 AM
Krinkle added a comment.Mar 21 2025, 7:13 AM

With T386139 resolved, we're ready for a Minify release to roll out the ES2017 tokens to MediaWiki.

As part of that, we do need to update the JavaScriptMinified class doc as there's still various references to ECMAScript 7.0 (ES2016) that should now point to ECMAScript 8.0. When doing we also need to check the specification linked from the class against those references, to verify that we haven't forgotten to add/change/remove/reorder anything. The order and grouping of class constants does not change the library behaviour but helps future updates and verification.

Nemoralis added a project: User-notice.Mar 21 2025, 8:12 AM
Hokwelum closed subtask T386139: Add minification support for async function method as Resolved.Mar 21 2025, 10:55 AM
Quiddity moved this task from To Triage to Not ready to announce on the User-notice board.Mar 21 2025, 8:13 PM
Krinkle moved this task from Roadmap to Needs refinement on the MediaWiki-Platform-Team board.Mar 24 2025, 3:57 PM
Krinkle edited projects, added MediaWiki-Platform-Team; removed MediaWiki-Platform-Team (Roadmap).
gerritbot added a comment.Mar 24 2025, 11:46 PM

Change #1130172 had a related patch set uploaded (by Krinkle; author: Hokwelum):

[mediawiki/libs/Minify@master] JavaScriptMinifier: Update class documentation for ES2017 support

https://gerrit.wikimedia.org/r/1130172

gerritbot added a project: Patch-For-Review.Mar 24 2025, 11:46 PM

Change #1130172 merged by jenkins-bot:

[mediawiki/libs/Minify@master] JavaScriptMinifier: Update class documentation for ES2017 support

https://gerrit.wikimedia.org/r/1130172

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2025, 12:30 AM
Hokwelum moved this task from Needs refinement to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.Mar 25 2025, 11:13 AM
gerritbot added a comment.Mar 26 2025, 11:25 AM

Change #1131296 had a related patch set uploaded (by Hokwelum; author: Hokwelum):

[mediawiki/libs/Minify@master] Tag 2.9.0

https://gerrit.wikimedia.org/r/1131296

gerritbot added a project: Patch-For-Review.Mar 26 2025, 11:25 AM
Jdforrester-WMF mentioned this in T388273: Minify's dependency `pear/net_url2` triggers a PHPUnit test failure on PHP 8.4 in vendor.Mar 26 2025, 2:45 PM
gerritbot added a comment.Mar 26 2025, 5:43 PM

Change #1131296 merged by jenkins-bot:

[mediawiki/libs/Minify@master] Tag 2.9.0

https://gerrit.wikimedia.org/r/1131296

gerritbot added a comment.Mar 26 2025, 6:30 PM

Change #1131406 had a related patch set uploaded (by Hokwelum; author: Hokwelum):

[mediawiki/vendor@master] update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131406

gerritbot added a comment.Mar 26 2025, 6:38 PM

Change #1131409 had a related patch set uploaded (by Hokwelum; author: Hokwelum):

[mediawiki/core@master] ResourceLoader: update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131409

gerritbot added a comment.Mar 26 2025, 7:28 PM

Change #1131406 merged by jenkins-bot:

[mediawiki/vendor@master] update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131406

gerritbot added a comment.Mar 26 2025, 7:28 PM

Change #1131409 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131409

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 7:31 PM
gerritbot added a comment.Mar 26 2025, 7:54 PM

Change #1131426 had a related patch set uploaded (by Reedy; author: Hokwelum):

[mediawiki/vendor@REL1_43] update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131426

gerritbot added a project: Patch-For-Review.Mar 26 2025, 7:54 PM

Change #1131427 had a related patch set uploaded (by Reedy; author: Hokwelum):

[mediawiki/vendor@REL1_42] update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131427

gerritbot added a comment.Mar 26 2025, 7:58 PM

Change #1131428 had a related patch set uploaded (by Reedy; author: Hokwelum):

[mediawiki/vendor@REL1_39] update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131428

gerritbot added a comment.Mar 26 2025, 7:58 PM

Change #1131429 had a related patch set uploaded (by Reedy; author: Hokwelum):

[mediawiki/core@REL1_43] ResourceLoader: update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131429

gerritbot added a comment.Mar 26 2025, 8:00 PM

Change #1131430 had a related patch set uploaded (by Reedy; author: Hokwelum):

[mediawiki/core@REL1_42] ResourceLoader: update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131430

gerritbot added a comment.Mar 26 2025, 8:00 PM

Change #1131431 had a related patch set uploaded (by Reedy; author: Hokwelum):

[mediawiki/core@REL1_39] ResourceLoader: update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131431

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 26 2025, 8:00 PM
gerritbot added a comment.Mar 26 2025, 9:43 PM

Change #1131428 merged by Reedy:

[mediawiki/vendor@REL1_39] update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131428

gerritbot added a comment.Mar 26 2025, 9:43 PM

Change #1131427 merged by Reedy:

[mediawiki/vendor@REL1_42] update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131427

gerritbot added a comment.Mar 26 2025, 9:43 PM

Change #1131426 merged by Reedy:

[mediawiki/vendor@REL1_43] update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131426

gerritbot added a comment.Mar 26 2025, 9:56 PM

Change #1131431 merged by jenkins-bot:

[mediawiki/core@REL1_39] ResourceLoader: update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131431

gerritbot added a comment.Mar 26 2025, 9:59 PM

Change #1131430 merged by jenkins-bot:

[mediawiki/core@REL1_42] ResourceLoader: update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131430

ReleaseTaggerBot added projects: MW-1.42-notes, MW-1.39-notes.Mar 26 2025, 10:00 PM
gerritbot added a comment.Mar 26 2025, 10:00 PM

Change #1131429 merged by jenkins-bot:

[mediawiki/core@REL1_43] ResourceLoader: update wikimedia/minify to 2.9.0

https://gerrit.wikimedia.org/r/1131429

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2025, 10:30 PM
ReleaseTaggerBot added a project: MW-1.43-notes.Mar 26 2025, 11:00 PM
Quiddity moved this task from Not ready to announce to In current Tech/News draft on the User-notice board.Mar 28 2025, 9:52 PM
Tacsipacsi added subscribers: Quiddity, Tacsipacsi.Mar 29 2025, 7:38 PM

@Quiddity Are you really sure this is ready to be announced? I think actually T381537 should be the User-notice task instead of this one, and that one still lists a couple of steps to be done.

Krinkle moved this task from In current Tech/News draft to Not ready to announce on the User-notice board.Mar 29 2025, 7:40 PM
Krinkle removed a project: User-notice.EditedMar 29 2025, 7:44 PM

You're exactly right. The relevant tech news will be: mediawiki generally changing browser support, and gadgets can use new syntax. Neither is the case (yet) and is better captured in the parent task.

Krinkle closed this task as Resolved.Mar 29 2025, 7:47 PM
Krinkle added a project: User-notice.EditedMar 29 2025, 7:55 PM

Okay, I see it did make it in, but what made it in is completely accurate, well-phrased, and minimal in scope. This is harmless and shouldn't cause confusion I think.

https://meta.wikimedia.org/wiki/Tech/News/2025/14

The MediaWiki minifier now supports ES2016 and ES2017.

It is perhaps a useful FYI to report progress in the general area, but it is not actionable for readers, so I wouldn't mind removing it to reduce noise.

Krinkle moved this task from Not ready to announce to In current Tech/News draft on the User-notice board.Mar 29 2025, 7:55 PM
Quiddity added a comment.Mar 29 2025, 7:59 PM

Haha! Edits crossing in the night, I removed the entry as you were typing the above. I had meant to ask you if it should be clarified, but i didn't notice it till late yesterday (yesterday was very busy....) so I just left it in.
We can go either way - Up to you.
I'd hesitantly suggest leaving it out if there's nothing actionable.
If you want it back in, and if I/we replace it within the next hour, then that should be fine, but if you don't notice this response for longer, then let's keep it out.

Tacsipacsi added a comment.Mar 29 2025, 8:16 PM
In T277675#10689760, @Krinkle wrote:

[…] what made it in is completely accurate, well-phrased, and minimal in scope. This is harmless and shouldn't cause confusion I think.

When I was reading the Tech News draft, my first thought was “cool, we can finally use async/await”, and even reading it twice, I was still not entirely sure this isn’t the case. I’m pretty sure others would have similar thoughts – probably because we expect Tech News entries to be actionable, and if they aren’t, we unconsciously make up something. So I appreciate the unactionable entry being removed.

Quiddity removed a project: User-notice.Mar 29 2025, 8:19 PM

Makes sense. +1. Thanks again, Tacsipacsi (and Krinkle!). Sorry for the confusion & noise.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits