Page MenuHomePhabricator

1.37.0-wmf.18 deployment blockers
Closed, ResolvedPublicRelease

Details

Backup Train Conductor
mmodell
Release Version
1.37.0-wmf.18
Release Date
Aug 9 2021, 12:00 AM
Train Status

Unblocked as of 21:13 utc.

2021 week 32 1.37-wmf.18 Changes wmf/1.37.0-wmf.18

This MediaWiki Train Deployment is scheduled for the week of Monday, August 9th:

Monday August 9thTuesday, August 10thWednesday, August 11thThursday, August 12thFriday
Backports only.Branch wmf.18 and deploy to Group 0 Wikis.Deploy wmf.18 to Group 1 Wikis.Deploy wmf.18 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.18 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.37.0-wmf.17
Next: 1.37.0-wmf.19

Event Timeline

thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: mmodell.

Change 711188 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.37.0-wmf.18 refs T281159

https://gerrit.wikimedia.org/r/711188

Change 711188 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.37.0-wmf.18 refs T281159

https://gerrit.wikimedia.org/r/711188

Mentioned in SAL (#wikimedia-operations) [2021-08-10T19:04:20Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.37.0-wmf.18 refs T281159

Dear train conductor,
Just like last week, T281158#7253330, there is a possibility of minor visual regressions relating to T287410, this time inside the more widely used Vector skin. In the last roll out we noticed changes relating to how elements were floated/aligned (T288288), as well as issues with how certain tables are displayed (T287997).

Any issues that arise will be considered for next week's train but should not be considered deploy blockers as there has been plenty of warning relating to this.

Please ping me on any bug reports relating to UI changes so I can provide support in the assessment and any required actions.

Thanks and good luck with this week! :)

Change 711660 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 wikis to 1.37.0-wmf.18 refs T281159

https://gerrit.wikimedia.org/r/711660

Change 711660 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.37.0-wmf.18 refs T281159

https://gerrit.wikimedia.org/r/711660

Mentioned in SAL (#wikimedia-operations) [2021-08-11T19:10:27Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.37.0-wmf.18 refs T281159

Change 711663 had a related patch set uploaded (by Jeena Huneidi; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.18 refs T281159

https://gerrit.wikimedia.org/r/711663

Change 711663 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.37.0-wmf.18 refs T281159

https://gerrit.wikimedia.org/r/711663

Mentioned in SAL (#wikimedia-operations) [2021-08-11T19:28:30Z] <jhuneidi@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.37.0-wmf.18 refs T281159

Mentioned in SAL (#wikimedia-operations) [2021-08-11T19:29:39Z] <jhuneidi@deploy1002> Synchronized php: group1 wikis to 1.37.0-wmf.18 refs T281159 (duration: 01m 08s)

T288724: defaultcontentmodel missing from most namespaces in Wikidata namespaces siteinfo (breaks pywikibot) prevents Pywikibot from running on Wikidata (I assume already-running bots can continue to run but any newly started ones will fail), not sure if that’s bad enough to block the train.

Edit: I’m no longer confident this is a regression in wmf.18. Edit 2: It appears to be a wmf.18 regression after all, tested in T288724#7278345. Edit 3: And I have a fix for it, so a rollback will probably not be necessary. Edit 4: Fix deployed and seems to work, no train action necessary.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/712039 (Fix for T288683) is merged, but need to deploy in wmf.18 to unblock the train. Since, it crossed EU Mid-day backport window, can anyone from RelEng please deploy it before train's run?

I've just filed T288739: Regression: Colour of 'new' ('red') links has changed to #d33 in Vector skin, not sure of its worth blocking but I'm not aware of any notice and someone's already complained it affects how easy it is to read.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/712039 (Fix for T288683) is merged, but need to deploy in wmf.18 to unblock the train. Since, it crossed EU Mid-day backport window, can anyone from RelEng please deploy it before train's run?

The same patch will fix two UBN! tasks:

  1. T288683: FuzzyBot overwriting fully translated pages with original text
  2. T288700: Translation page is no more updated while creating or editing translation units

To test these, please follow the steps mentioned below:

  1. https://phabricator.wikimedia.org/T288683#7278909
  2. https://phabricator.wikimedia.org/T288700#7278925

Anyone willing to deploy I2f46abb20145630c27449ce57f1256e92f440144? There’s a (so far completely empty) backport window happening right now, which is the last before the scheduled train window.

If someone is willing to test, we can find a deployer. Normally you schedule a patch and show up during the slot.

I can execute the test cases written by @abi_ (I have translation admin right on Meta) if it makes the deployment happen.

Mentioned in SAL (#wikimedia-operations) [2021-08-12T19:43:12Z] <twentyafterfour@deploy1002> Synchronized php-1.37.0-wmf.18/extensions/Translate/src/PageTranslation/TranslationPage.php: sync I2f46abb20145630c27449ce57f1256e92f440144 which should fix T288683 & T288700 thus unblocking the train: T281159 (duration: 01m 07s)

Mentioned in SAL (#wikimedia-operations) [2021-08-12T21:13:19Z] <twentyafterfour@deploy1002> Synchronized php-1.37.0-wmf.18/extensions/DiscussionTools/includes/Notifications/EventDispatcher.php: sync Ic27418a0ec976347be5fa586bbd32cc4a0d8d511 to unblock the train refs T288775 and T281159 (duration: 01m 07s)

Change 712626 had a related patch set uploaded (by 20after4; author: 20after4):

[operations/mediawiki-config@master] all wikis to 1.37.0-wmf.18 refs T281159

https://gerrit.wikimedia.org/r/712626

Change 712626 merged by jenkins-bot:

[operations/mediawiki-config@master] all wikis to 1.37.0-wmf.18 refs T281159

https://gerrit.wikimedia.org/r/712626

Mentioned in SAL (#wikimedia-operations) [2021-08-12T21:30:30Z] <twentyafterfour@deploy1002> rebuilt and synchronized wikiversions files: all wikis to 1.37.0-wmf.18 refs T281159