Page MenuHomePhabricator

Define the system's typographic scale (font sizes and line-heights)
Closed, ResolvedPublic3 Estimated Story Points

Description

Background/Goal

We need to define and document Codex's typographic scale. The system's type scale is made out of reusable text styles that result from combining system font sizes with their appropriate, corresponding line heights.

User stories

As a designer, I need to have access to the system's typographic scale, so I'm aware of which font styles I can apply, and where, when creating system compliant designs.

Figma specification sheet

Typographic style

Acceptance criteria (or Done)

  • We are able to document each one of the text styles that compose the system's typographic scale:
    • font sizes
    • line heights

Related Objects

StatusSubtypeAssignedTask
Duplicate STH
InvalidNone
ResolvedVolker_E
ResolvedNone
Resolvedbmartinezcalvo
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
Resolvedldelench_wmf
ResolvedVolker_E
Resolved EUdoh-WMF
ResolvedSarai-WMDE
Resolved DAbad
ResolvedVolker_E
Resolvedbmartinezcalvo
ResolvedSarai-WMDE
ResolvedCatrope
OpenNone
Resolvedovasileva
ResolvedBUG REPORTVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedSarai-WMDE
ResolvedVolker_E
Resolvedbmartinezcalvo
ResolvedCatrope
Resolved DAbad
ResolvedVolker_E

Event Timeline

STH triaged this task as High priority.May 1 2022, 1:20 PM
STH changed the task status from Open to In Progress.May 26 2022, 1:16 AM

Hey @Sarai-WMDE , wanted to check in and see if this task was still in progress, or if it would be helpful to break down further? Thanks!

The Typographic scale is caring for font-size and line-height tokens and is currently in v5 exploration phase. It doesn't necessarily make sense to further split this up as the two properties are intertweened and co-dependent.
We've prioritized other topics in the meantime and wanted to go in a big round of designers to support the decision making here, as it's one of the most prominent design attributes.

Status update: We're working on v7 of the current typographic styles proposal. The goal is to document this initial proposal* as Figma styles and apply them to Codex and OOUI components (as part of T295606: Create Figma styles based on design tokens and apply them to the Codex and OOUI Figma libraries). I think we should close this task once styles are both documented and applied (the latter can help us detect inconsistencies and require changes).

Making the typographic styles available for designers to use in their Figma files is going to help us detect needed improvements, which we could document in separate tasks.

*We tried to create a set of unified styles based on the designs and previous decisions made in our code libraries. We consider this an initial proposal/step because reaching a point where we're able to consolidate the extensive amount of typographic styles in all our projects is going to be a long, iterative process.

Pulling back into backlog since the task hasn't seen any action in >1 month; feel free to adjust.

@ldelench_wmf The conversations have all been happening on DS design sync, other Slack conversations and the Figma proposal itself. We're currently already on v10 of typographic styles proposal, latest update yesterday.

From DS design sync: We've agreed on putting option token line-height-100: 1.6 as normalized base.

Change 834403 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens: Add design-first `line-height` tokens

https://gerrit.wikimedia.org/r/834403

Change 834403 merged by jenkins-bot:

[design/codex@main] tokens: Add design-first `line-height` tokens

https://gerrit.wikimedia.org/r/834403

Change 848169 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens: Amend design-first `line-height` tokens to latest

https://gerrit.wikimedia.org/r/848169

ldelench_wmf set the point value for this task to 3.Oct 24 2022, 3:36 PM

Change 849191 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2

https://gerrit.wikimedia.org/r/849191

Change 849191 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.2.1 to v0.2.2

https://gerrit.wikimedia.org/r/849191

Volker_E updated the task description. (Show Details)

Change 848169 merged by jenkins-bot:

[design/codex@main] tokens: Amend design-first `line-height` tokens to latest

https://gerrit.wikimedia.org/r/848169

Change 859597 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0

https://gerrit.wikimedia.org/r/859597

Change 859597 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0

https://gerrit.wikimedia.org/r/859597

Volker_E renamed this task from Define the system's typographic scale (sizes and line-heights) to Define the system's typographic scale (font sizes and line-heights).Dec 23 2022, 5:53 PM

Ha, one task that wasn't mentioned most importantly in https://gerrit.wikimedia.org/r/c/design/codex/+/871022/
Design-first font size tokens are in now!

v13 of the typographic styles' proposal reflects the latest stable version of Codex font styles.
These have been documented as Figma styles in our Design tokens library, and used to style both the Codex and OOUI design components (See T295606: Create Figma styles based on design tokens and apply them to the Codex and OOUI Figma libraries). Lastly, font sizes and line-heights have also been incorporated as design tokens in our library.

Given that this first iteration of the typographic scale has been both documented, applied and implemented consistently, I'd say that this ticket can be signed-off from a design point of view.

(As previously mentioned, the attempt to consolidate all existing font styles in the Wikiverse will be a long, and necessarily iterative process. This is our first step in that undertaking.)

Volker_E claimed this task.
Volker_E added a subscriber: DAbad.

All resolved with Codex v0.3.0