Page MenuHomePhabricator

[IP Masking] Temporary account VisualEditor support
Closed, DuplicatePublic


Update VisualEditor by analogy with the core EditPage changes for IP masking. When IP masking is enabled:

  • Show an appropriate edit warning (mockup F34933178).
  • Acquire a temporary name when it is needed and show the name in signatures.
  • Page save should create the temporary account and redirect through in order to acquire CentralAuth cookies.
  • After save, a notice should be shown, as in core (mockup F34933175).

Event Timeline

Change 837131 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] ApiEditPage: Create temporary account on edit attempt if enabled

@Ladsgroup asked me to figure out why the minimal IP masking functionality wasn't working in VE (edits would still be attributed to your IP address rather than a temporary account). I found that the function implementing this was not called when saving using the API. This patch seems to work for me, but I wonder if this is the approach you intended @tstarling? You wrote "Acquire a temporary name…" and I'm wondering if you meant to add a separate API module for "logging into" a temporary account or something.

(I'm not currently working on any of the interface changes required for this, just this tiny patch.)

Change 837131 merged by jenkins-bot:

[mediawiki/core@master] ApiEditPage: Create temporary account on edit attempt if enabled

The basic issue (edits being saved under IP when edits are done with VE) is now fixed:

The rest is needed but I think it's pretty good already ^_^

I'll merge this into T332435, where I've started working on updating VisualEditor for IP masking.