Page MenuHomePhabricator

Provide (legacy) font families as Codex tokens
Closed, ResolvedPublic

Description

Background/Goal

In order to move forward with T318016 Codex needs to provide the current in production font-family tokens.

WikimediaUI Base currently features:

/* == Typography incl. print properties == */
/* See https://design.wikimedia.org/style-guide/visual-style_typography.html */
/* Font Families */
--font-family-base:                var( --font-family-sans );
--font-family-heading-main:        var( --font-family-serif );
/* To be deprecated, see T247166. */
--font-family-sans:                'Helvetica Neue', 'Helvetica', 'Liberation Sans', 'Arial', sans-serif;
/* Provide better operating system-specific readability, see T175877. */
/* `system-ui` is currently not an option due to OS/language combination issues, see T175877#4776576. */
--font-family-system-sans:         -apple-system, 'BlinkMacSystemFont', 'Segoe UI', 'Roboto', 'Inter', 'Helvetica', 'Arial', sans-serif;
--font-family-sans--fallback:      sans-serif;
--font-family-serif:               'Linux Libertine', 'Georgia', 'Times', 'Source Serif Pro', serif;
--font-family-serif--fallback:     serif;
/* Provide better operating system-specific monospace stack, see T209915. */
--font-family-monospace:           'Menlo', 'Consolas', 'Liberation Mono', 'Fira Code', 'Courier New', monospace;
--font-family-monospace--fallback: monospace, monospace; /* See T176636. */

User stories

As a developer, I would like to be sure, that my font family definitions achieved by WikimediaUI Base continue to work

Acceptance criteria or Done

  • Codex features legacy WikimediaUI Base

Related Objects

StatusSubtypeAssignedTask
Duplicate STH
InvalidNone
ResolvedVolker_E
ResolvedNone
Resolvedbmartinezcalvo
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
Resolvedldelench_wmf
ResolvedVolker_E
Resolved EUdoh-WMF
ResolvedSarai-WMDE
Resolved DAbad
ResolvedSarai-WMDE
ResolvedCatrope
OpenNone
Resolvedovasileva
ResolvedBUG REPORTVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedVolker_E
ResolvedSarai-WMDE
ResolvedVolker_E
Resolvedbmartinezcalvo
ResolvedCatrope
Resolved DAbad
ResolvedVolker_E

Event Timeline

Volker_E removed a project: Epic.

Change 855625 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] tokens: Introduce `font-family` (legacy) tokens

https://gerrit.wikimedia.org/r/855625

Change 855625 merged by jenkins-bot:

[design/codex@main] tokens: Introduce `font-family` (legacy) tokens

https://gerrit.wikimedia.org/r/855625

Change 859597 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0

https://gerrit.wikimedia.org/r/859597

Change 859597 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.2.2 to v0.3.0

https://gerrit.wikimedia.org/r/859597

@Volker_E is this task done, or do we need to do more work?

@Catrope The one thing missing from dev experience POV is, I've added the comments in latest patch set about context for font families in theme*.json. But the decision tokens in the output are missing the comments.
As the tokens itself are in (with willingful exception of font-family-sans), this is good to be resolved.