Stop using webpack in mobile.editor.overlay module
Open, Needs TriagePublic
Actions

Description

Background

The web team would like to move away from webpack in MobileFrontend to avoid having to do a costly upgrade with little benefit. We plan to do this gradually on a per-feature basis to avoid any breakages.

Before doing this we would need buy-in from the editing team who co-maintain the MobileFrontend repository.

User story

As a developer I want to remove unhelpful dependencies from my codebases.

Requirements

The mobile.editor.overlay module no longer requires webpack to be built
The editing team is happy with this interim state

BDD

For QA engineer to fill out

Test Steps

For QA engineer to fill out

Design

Add mockups and design requirements

Acceptance criteria

Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

Add communication criteria

Rollback plan

What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Details

	Subject	Repo	Branch	Lines +/-
	Fixes: switching between VisualEditor and SourceEditor	mediawiki/extensions/MobileFrontend	master	+4 -0
	Move mobile.editor.overlay off of Webpack	mediawiki/extensions/MobileFrontend	master	+177 -85

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T162936 Improve developer happiness in reading web maintained extensions
Stalled	None	T158980 [EPIC] Generate compiled assets from continuous integration
Declined	None	T199004 RFC: Add a frontend build step to skins/extensions to our deploy process
Open	None	T315929 Reconsider build step in Popups and MobileFrontend
Open	None	T379793 [EPIC] Remove Webpack from MobileFrontend
Open	None	T379822 Stop using webpack in mobile.editor.overlay module

Event Timeline

Jdlrobson created this task.Wed, Nov 13, 8:09 PM

Editing engineers would be happy with this. Going module by module will be a little confusing for a while but hopefully that won't be too long, and the end state will be a great improvement.

Side note: you may want to trim the subscribers list when creating a sub task :)

Krinkle unsubscribed.Thu, Nov 14, 4:45 PM

Change #1091375 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Move mobile.editor.overlay off of Webpack

https://gerrit.wikimedia.org/r/1091375

gerritbot added a project: Patch-For-Review.Thu, Nov 14, 9:40 PM

No urgency @Esanders but there's the MVP for what that would look like for editing engineers to look at whenever time allows.

Samwilson unsubscribed.Thu, Nov 14, 10:43 PM

LGTM - happy to merge when you guys are ready.

In T379822#10325962, @Esanders wrote:

LGTM - happy to merge when you guys are ready.

My hope was that editing team could merge and QA this since you are more familiar with the codebase and I see you as maintainers of that code and would get the most benefits. With that in mind you can merge whenever makes sense!

In terms of the rest of the codebase, I'm hoping we can begin the transition away from Webpack next quarter (possibly starting earlier in December if we make more progress than expected on the other things we have in flight).

For editing QA, we should check that the basic workflows of mobile editing are unaffected:

open the editor
switch edit modes (visual/source)
close the editor
publish changes (both modes)

AnneT unsubscribed.Tue, Nov 19, 1:52 PM

Ryasmeen edited projects, added Verified; removed Editing QA, Patch-For-Review.Tue, Nov 19, 4:43 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Tue, Nov 19, 4:46 PM

egardner unsubscribed.Tue, Nov 19, 5:06 PM

Change #1091375 merged by Jdlrobson:

[mediawiki/extensions/MobileFrontend@master] Move mobile.editor.overlay off of Webpack

https://gerrit.wikimedia.org/r/1091375

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Tue, Nov 19, 7:00 PM

Kenrick95 unsubscribed.Wed, Nov 20, 2:00 AM

phuedx unsubscribed.Wed, Nov 20, 2:28 PM

Change #1094065 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Fixes: switching between VisualEditor and SourceEditor

https://gerrit.wikimedia.org/r/1094065

gerritbot added a project: Patch-For-Review.Thu, Nov 21, 11:20 PM

ppelberg subscribed.Thu, Nov 21, 11:32 PM

SD0001 unsubscribed.Fri, Nov 22, 1:03 AM

Change #1094065 merged by jenkins-bot: