Page MenuHomePhabricator

User rights change notification email does not specify in body which account was affected
Open, NormalPublic

Description

I just received this email (in relevant part):

From: Meta <wiki@wikimedia.org>
To: MarkTraceur (WMF) <mholmquist@wikimedia.org>
Subject: Your user rights have changed on Meta

My mail client did not display the (WMF) to me in the human-readable view, because that syntax designates a comment. It should be made clear in the message body which account is being acted on, because I was convinced at first that my account had been tampered with, as [[:m:User:MarkTraceur]] has a very different mailing address.

Details

Reference
bz69981

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:40 AM
bzimport added a project: Notifications.
bzimport set Reference to bz69981.
bzimport added a subscriber: Unknown Object (MLST).

Don't get it. What would you have expected?

To: "MarkTraceur (WMF)" <mholmquist@wikimedia.org>

instead? What kind of "syntax designates a comment" by which definition?

I clarified the bug summary to what I think Mark was getting at.

Basically. The "(WMF)" in the raw header got taken out of the display, because it's a comment based on http://www.ietf.org/rfc/rfc2822.txt

I'd like the message body to include the account name for clarity.

Sounds like a bug with "(WMF)" accounts names to me :>

Mattflaschen-WMF renamed this task from User rights change notification email does not specify which account was affected to User rights change notification email does not specify in body which account was affected.Dec 11 2014, 5:14 AM
Mattflaschen-WMF triaged this task as Normal priority.
Mattflaschen-WMF set Security to None.
Legoktm moved this task from Backlog to Needs code on the Notifications board.Jul 6 2015, 8:15 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 6 2015, 8:15 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 22 2016, 12:04 AM

Confirmed the bug - username's part in parentheses got dropped when displayed in To header of a received email.

e.g. ET (ABC) will become
to: ET <etonkovidova@wikimedia.org>

@jmatazzoni , @Pginer-WMF Any preference for how to include the user account name in the user-rights notification messages?

One option is to replace you by the account name and maybe bold it.

Your user rights were changed. You have been added to: ‪Add-1‬, ‪Add-2‬. You are no longer a member of: ‪Remove-1‬, ‪Remove-2‬.

Would become

Your user rights were changed. MyUsername (WMF) has been added to: ‪Add-1‬, ‪Add-2‬. MyUsername (WMF) is no longer a member of: ‪Remove-1‬, ‪Remove-2‬.

DannyH removed a subscriber: DannyH.Jun 23 2016, 7:12 PM
matej_suchanek removed a subscriber: wikibugs-l-list.

Basically. The "(WMF)" in the raw header got taken out of the display, because it's a comment based on http://www.ietf.org/rfc/rfc2822.txt
I'd like the message body to include the account name for clarity.

Is there a way to escape the string? I'm not familiar with this particular format, but I'd expect some way to indicate text is literal. Using quotes was suggested in this discussion about brackets disappearing on emails which I'm not sure how closely related is to our case.

I think it's useful to put in the body regardless. People might not know to check the To (they know they received the email after all) even if the escaping works.

Filed the To issue as T158269: Escape round parentheses so they properly show in To

revi added a subscriber: revi.Aug 14 2018, 7:36 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 14 2018, 7:36 AM
kostajh added subscribers: Catrope, kostajh.

Discussed in Growth team triage meeting today. @Catrope is going to create a task for redesigning Notification emails, and then this task could get added as a subtask of that. Once we have the overall picture of what needs to get done, we could look at scheduling the work for this particular feature.