Page MenuHomePhabricator

Indicate deployed status (wmf branch) for Gerrit patches in Phabricator
Open, LowPublicFeature

Description

Whether a patch is live or not on a specific wiki is a common source of confusion. It should be easy to write a web service which checks whether the patch commit id is the parent of HEAD for the set0/set1/set2 wmf branches and/or the REL* branches, and return a shield that can be included in the gerrit skin.

Event Timeline

Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr subscribed.

See also: T280: [EPIC] Code Deploy Dashboard, which is more and different than this, but related.

greg triaged this task as Low priority.Mar 20 2015, 6:38 PM
greg edited projects, added Deployments; removed Release-Engineering-Team.
greg set Security to None.
Legoktm subscribed.

Not really. ReleaseTaggerBot tells you if a certain bug is deployed (or when it will be), but not all patches have bugs associated with them.

And some tasks have multiple patches associated with them, which also makes the meaning of the release tags unclear.

Gerrit shows the list of including branches nowadays, which tells you whether something is deployed as long as you remember the current WMF branch names, but it would be still nice to have something that is understandable to the average user.

greg removed hashar as the assignee of this task.Apr 1 2016, 9:30 AM

This may now be possible as polygerrit is built from js and html not java a lot more people can contribute to do this :).

We could get them to support doing this from a polygerrit plugin which will use polymer template which is very extendable :)

With PolyGerrit we could develop a plugin that display deployment status right above the file list. Would need some kind of rest api or json file where we could parse.

Krinkle added subscribers: mmodell, Krinkle.

Within Gerrit, the "Included In" section already indicates which branches a change was naturally a part of.

However, this could also be realised on the Phabricator side. Per T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator (show "Related Gerrit Patches"), @mmodell has implemented the following:

Screenshot 2019-11-08 at 11.36.02.png (432×1 px, 60 KB)
somelevelofawesomeness.png (173×437 px, 10 KB)

To resolve this task, perhaps it could be extended to, in addition to the branch it was merged into, also the newest deploy/release branch it is a part of. E.g. to display at most one "wmf/*" or "REL*" (the newest one), falling back to "master" (or whatever the repo's head branch is). E.g. it would show "master" for stuff landed just now, "1.35-0.wmf.5" for stuff that's in prod already, and "REL1_34" (or 1.34.x) for stuff that's been in prod longer and and released already.

To resolve this task, perhaps it could be extended to, in addition to the branch it was merged into, also the newest deploy/release branch it is a part of. E.g. to display at most one "wmf/*" or "REL*" (the newest one), falling back to "master" (or whatever the repo's head branch is). E.g. it would show "master" for stuff landed just now, "1.35-0.wmf.5" for stuff that's in prod already, and "REL1_34" (or 1.34.x) for stuff that's been in prod longer and and released already.

That sounds pretty reasonable, however, due to our practice of cherry-picking changes to release branches, I think that each copy of a patch will get its own row in the "related gerrit patches" table. I could filter or group the table to get the behavior you described but as it stands now it should be easy to determine where a patch was merged since it will be listed once for each cherry-picked copy of the patch.

Yeah, for cherry-picks it would be separate at first. I think that's okay for now (not required to resolve the immediate need). At least the information will be in the table somewhere. Perhaps we could make it slightly easier by sorting the rows in a way that makes them next to each other (e.g. sort by Change-Id first, then by last-mod as now). That way we don't need a new concept for "grouping" yet.

.Nafees791 renamed this task from Deployment status indicator for gerrit patches to Deployment status.Jan 23 2020, 4:05 AM
.Nafees791 removed mmodell as the assignee of this task.
.Nafees791 updated the task description. (Show Details)
.Nafees791 removed subscribers: matmarex, Krinkle, mmodell and 6 others.
DannyS712 renamed this task from Deployment status to Deployment status indicator for gerrit patches.Jan 23 2020, 5:05 AM
DannyS712 assigned this task to mmodell.
DannyS712 updated the task description. (Show Details)
DannyS712 added subscribers: matmarex, Krinkle, mmodell and 6 others.
mmodell raised the priority of this task from Low to Medium.Apr 15 2020, 5:23 PM
Krinkle renamed this task from Deployment status indicator for gerrit patches to Indicate deployed status (wmf branch) for Gerrit patches in Phabricator.Apr 17 2020, 5:05 PM
mmodell lowered the priority of this task from Medium to Low.May 6 2020, 5:06 PM
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 13 2021, 11:41 AM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).

Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.

If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".

Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.