Page MenuHomePhabricator
Feed Advanced Search

Jul 10 2016

PeterBowman added a comment to T137632: misleading error about thumbnails for OGG audio files.

@matmarex if I understand it correctly, this patch overrides any explicit size set in audio files and forces it to 120px. Thus, the following code doesn't work anymore:

[[File:Example.ogg|15px|noicon]]

(I'll obviate the noicon part) This would output just the play/stop button and omit the rest of the player's layout. Such a shrinked version of the player had a purpose on eswiktionary, now it's shown in full length.

Jul 10 2016, 3:51 PM · Patch-For-Review, MW-1.28-release (WMF-deploy-2016-06-28_(1.28.0-wmf.8)), TimedMediaHandler, MediaWiki-File-management, Commons, MediaWiki-Action-API, Multimedia

Jun 28 2016

PeterBowman added a comment to T138283: Some users use persistent connections that are idle, wasting memory and other resources that could be used for other users.

Hi, @jcrespo, thank you for your quick response. I'm just starting to develop some simple tools for a relatively small project and their usage is still scarce. By now, I'll happily follow your recommendations, keep an eye on the resource usage and contact you if needed.

Jun 28 2016, 5:15 PM · Discovery-ARCHIVED, Maps, Toolforge, Cloud-Services, DBA
PeterBowman added a comment to T138283: Some users use persistent connections that are idle, wasting memory and other resources that could be used for other users.

I've disabled connection pooling by enforcing the number of idle connections to zero with an immediate eviction. In case someone finds this useful, I'm putting here the specific <Resource> attributes in Tomcat's context.xml that had to be set (in my case) in order to disable pooling:

  • minIdle="0"
  • maxIdle="0"
  • initialSize="0"
  • minEvictableIdleTimeMillis="0"

@jcrespo in spite of that policy, would it be acceptable to keep a minimal pool of short-lived idle connections (let's say 1-5 minutes, only one idle connection per finished active connection), leaving it empty if there is no activity? Does said policy apply to databases created on the shared server (tools.labsdb), too? Are there any other configuration aspects related to resource saving that should be considered (e.g. maximum number of connections)?

Jun 28 2016, 3:11 PM · Discovery-ARCHIVED, Maps, Toolforge, Cloud-Services, DBA

Jun 21 2016

PeterBowman added a comment to T138283: Some users use persistent connections that are idle, wasting memory and other resources that could be used for other users.

I'm sorry, this shouldn't have happened. I've killed those processes and disabled any scripts and webapps that had access to that db until I fix this issue.

Jun 21 2016, 11:40 AM · Discovery-ARCHIVED, Maps, Toolforge, Cloud-Services, DBA

Apr 4 2016

PeterBowman created T131799: Fix URL encoding of link to user's profile on 'No webservice' warning page.
Apr 4 2016, 8:37 PM · Patch-For-Review, Cloud-Services, Toolforge

Mar 22 2016

PeterBowman added a comment to T130595: labsdb accounts being created without grants to create personal databases.

Thanks! I'm including this possibly relevant comment on IRC, the mentioned outage happened in June 2015 (I presume it was 20150617-LabsNFSOutage since I gained access to Labs on 19/06):

Mar 22 2016, 11:48 AM · Toolforge, Cloud-Services
PeterBowman added a comment to T50950: Some of my tools don't have .my.cnf / can't create databases in tools-db.

@coren: I hit a similar issue when trying to create a database with my tool (pbbot):

$ cat replica.my.cnf | grep user
user='s52584'
$ sql local
MariaDB [(none)]> create database s52584__test;
ERROR 1044 (42000): Access denied for user 's52584'@'%' to database 's52584__test'

Apparently, I don't have the necessary grants to perform this action (per http://dev.mysql.com/doc/refman/5.7/en/grant.html#idm139794624158480) despite what says the help page:

MariaDB [(none)]> show grants;
+-----------------------------------------------------------------------------------------------------------+
| Grants for s52584@%                                                                                       |
+-----------------------------------------------------------------------------------------------------------+
| GRANT SHOW VIEW ON *.* TO 's52584'@'%' IDENTIFIED BY PASSWORD '__EDITED__' |
| GRANT SELECT, SHOW VIEW ON `%\_p`.* TO 's52584'@'%'                                                       |
+-----------------------------------------------------------------------------------------------------------+
2 rows in set (0.02 sec)
Mar 22 2016, 11:18 AM · Cloud-Services, Toolforge

Mar 21 2016

PeterBowman awarded T127633: install Morfeusz (morphological analyser) and Python bindings a Like token.
Mar 21 2016, 10:56 AM · Toolforge, Cloud-Services

Mar 14 2016

PeterBowman added a comment to T129517: The refreshLinks jobs enqueue rate is 10 times the normal rate.

I launched a forcerecursivelinkupdate purge API action on 03/10 at 02:40 UTC affecting all pages on plwiktionary, a smaller peak is clearly visible on Grafana right after that. The jobs counter of this project continued growing for the next days when it usually stops after a few hours. Could this have any connection?

Mar 14 2016, 1:21 PM · MediaWiki-Core-JobQueue, SRE

Mar 2 2016

PeterBowman reopened T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used as "Open".

@matmarex: I'm reopening, we have recently hit this issue on plwiktionary (report, answer). The steps to reproduce this are still the same:

  1. Disable the preference Show edit toolbar.
  2. Open any page in edit mode and try to insert a character contained in the Edittools box.
  3. TypeError: mw.toolbar is undefined
Mar 2 2016, 8:29 PM · MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)), Patch-For-Review, Regression, Contributors-Team, JavaScript, CharInsert
PeterBowman reopened T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used, a subtask of T85787: CharInsert Extension should use mw.toolbar.insertTags instead of window.insertTags, as Open.
Mar 2 2016, 8:29 PM · good first task, JavaScript, Technical-Debt, CharInsert
PeterBowman reopened T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used, a subtask of T19653: Classic edit toolbar & edit tools (tracking), as Open.
Mar 2 2016, 8:29 PM · MediaWiki-Page-editing, JavaScript, Tracking-Neverending, MediaWiki-User-Interface
PeterBowman reopened T88922: ReferenceError due to CharInsert extension not loading mediawiki.toolbar before it is used, a subtask of T92781: EditTools issues on Special:Upload, as Open.
Mar 2 2016, 8:29 PM · MW-1.28-release (WMF-deploy-2016-05-31_(1.28.0-wmf.4)), CharInsert, JavaScript

Feb 22 2016

PeterBowman added a comment to T124356: Incorrect TOC and section edit links rendering in Vector due to ParserCache corruption via ParserOutput::setText( ParserOutput::getText() ).

I'm seeing this now on eswiktionary's entry güirro and there were confirmed cases on plwiktionary, too (reported in January).

Feb 22 2016, 5:22 PM · User-notice-archive, Patch-For-Review, Reading-Web-Sprint-68-"Java and JavaScript are basically the same", MW-1.27-release (WMF-deploy-2016-03-15_(1.27.0-wmf.17)), MobileFrontend, Traffic, SRE, Regression

Feb 10 2016

PeterBowman renamed T126407: [CatWatch] Ignore Lua-transcluded pages in summaries from [CatWatch] Ignore Lua-transcluded pages to [CatWatch] Ignore Lua-transcluded pages in summaries.
Feb 10 2016, 2:43 PM · TCB-Team-Sprint-2016-04-13, Patch-For-Review, CatWatch, MediaWiki-Watchlist
PeterBowman added a comment to T126407: [CatWatch] Ignore Lua-transcluded pages in summaries.

So as far as I can tell this is just about summaries?

Feb 10 2016, 2:42 PM · TCB-Team-Sprint-2016-04-13, Patch-For-Review, CatWatch, MediaWiki-Watchlist
PeterBowman added a comment to T126407: [CatWatch] Ignore Lua-transcluded pages in summaries.

See also T126139.

Feb 10 2016, 12:09 AM · TCB-Team-Sprint-2016-04-13, Patch-For-Review, CatWatch, MediaWiki-Watchlist
PeterBowman added a subtask for T9148: Watch edits which add or remove pages from a category: T126407: [CatWatch] Ignore Lua-transcluded pages in summaries.
Feb 10 2016, 12:09 AM · User-notice-archive, CatWatch, MW-1.27-release, WMF-deploy-2015-08-25_(1.26wmf20), WMF-deploy-2015-08-18_(1.26wmf19), TCB-Team-Sprint-2015-08-12, TCB-Team-Sprint-2015-07-29, TCB-Team-Sprint-2015-07-15, TCB-Team-Sprint-2015-07-01, TCB-Team-Sprint-2015-06-17, TCB-Team-Sprint-2015-06-03, TCB-Team (now WMDE-TechWish), German-Community-Wishlist, MediaWiki-Watchlist
PeterBowman added a parent task for T126407: [CatWatch] Ignore Lua-transcluded pages in summaries: T9148: Watch edits which add or remove pages from a category.
Feb 10 2016, 12:09 AM · TCB-Team-Sprint-2016-04-13, Patch-For-Review, CatWatch, MediaWiki-Watchlist
PeterBowman created T126407: [CatWatch] Ignore Lua-transcluded pages in summaries.
Feb 10 2016, 12:07 AM · TCB-Team-Sprint-2016-04-13, Patch-For-Review, CatWatch, MediaWiki-Watchlist

Jan 23 2016

PeterBowman added a comment to T92230: Button option to 'choose all/none/reverse' for revdel.

It turns out that the change-tags buttons and checkboxes are hidden through CSS on test.wikipedia. Sorry!

Jan 23 2016, 12:29 AM · User-revi, User-notice-archive, Patch-For-Review, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), good first task, MediaWiki-Revision-deletion

Jan 20 2016

PeterBowman added a comment to T92230: Button option to 'choose all/none/reverse' for revdel.

@lfaraone: just tested on test.wikipedia.org, I'm seeing these buttons on Special:Log even if no checkboxes are present (which is strange because even if I'm not allowed to revdel I should see the option to add/remove edit tags, now missing - possibly a regression?). BTW I wonder if the buttons could also apply to edit tags on history pages (right now the condition to be met is $user->isAllowed( 'deleterevision' ), this excludes non-sysops).

Jan 20 2016, 1:38 AM · User-revi, User-notice-archive, Patch-For-Review, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), good first task, MediaWiki-Revision-deletion

Jan 11 2016

PeterBowman created T123269: Source editing gets stuck when saving changes that hit an abuse filter.
Jan 11 2016, 7:05 PM · Contributors-Team, AbuseFilter, MobileFrontend

Dec 19 2015

PeterBowman added a comment to T121986: Restore fragment in broken links.

Possibly related code in Linker.php:

Dec 19 2015, 6:53 PM · Regression, MediaWiki-General
PeterBowman created T121986: Restore fragment in broken links.
Dec 19 2015, 6:47 PM · Regression, MediaWiki-General

Dec 10 2015

PeterBowman added a comment to T121047: Broken links to scripts and styles on Special:Gadgets.

Actually, it is pre-pended and I confirm this is a regression that has been recently added.

Dec 10 2015, 3:00 AM · MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), Patch-For-Review, Regression, MediaWiki-extensions-Gadgets
PeterBowman updated the task description for T121047: Broken links to scripts and styles on Special:Gadgets.
Dec 10 2015, 2:59 AM · MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), Patch-For-Review, Regression, MediaWiki-extensions-Gadgets
PeterBowman created T121047: Broken links to scripts and styles on Special:Gadgets.
Dec 10 2015, 12:59 AM · MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), Patch-For-Review, Regression, MediaWiki-extensions-Gadgets

Nov 27 2015

PeterBowman added a comment to T119763: [CatWatch] Category namespace prefix is trimmed from RC links.

You are right, I watched [[Wikipedia:CatWatchTest]] and then it showed up on my watchlist (CatWatch is currently enabled on test WMF wikis, we'll have to wait for its arrival on eswikt). Thanks for investigating this issue :).

Nov 27 2015, 10:51 PM · CatWatch, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Patch-For-Review, MediaWiki-Watchlist
PeterBowman added a comment to T119763: [CatWatch] Category namespace prefix is trimmed from RC links.

I have just noted that there are no logs of page additions/deletions to said category on my watchlist, not sure why. Other categories are shown there as expected.

Nov 27 2015, 4:26 PM · CatWatch, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Patch-For-Review, MediaWiki-Watchlist
PeterBowman added a subtask for T9148: Watch edits which add or remove pages from a category: T119763: [CatWatch] Category namespace prefix is trimmed from RC links.
Nov 27 2015, 4:17 PM · User-notice-archive, CatWatch, MW-1.27-release, WMF-deploy-2015-08-25_(1.26wmf20), WMF-deploy-2015-08-18_(1.26wmf19), TCB-Team-Sprint-2015-08-12, TCB-Team-Sprint-2015-07-29, TCB-Team-Sprint-2015-07-15, TCB-Team-Sprint-2015-07-01, TCB-Team-Sprint-2015-06-17, TCB-Team-Sprint-2015-06-03, TCB-Team (now WMDE-TechWish), German-Community-Wishlist, MediaWiki-Watchlist
PeterBowman added a parent task for T119763: [CatWatch] Category namespace prefix is trimmed from RC links: T9148: Watch edits which add or remove pages from a category.
Nov 27 2015, 4:17 PM · CatWatch, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Patch-For-Review, MediaWiki-Watchlist
PeterBowman created T119763: [CatWatch] Category namespace prefix is trimmed from RC links.
Nov 27 2015, 4:15 PM · CatWatch, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), Patch-For-Review, MediaWiki-Watchlist

Nov 18 2015

PeterBowman created T119006: Add new NS_PROJECT alias on eswiktionary.
Nov 18 2015, 10:47 PM · Wikimedia-Site-requests

Oct 7 2015

PeterBowman added a comment to T85386: Show an error if a named <ref> is defined multiple times with different content.

It might be worth noting that Cite won't raise this kind of error unless a <references> tag is provided: with (error) and without (no error).

Oct 7 2015, 10:10 PM · User-notice-archive, MediaWiki-TrackingCategories, MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), Parsoid, Cite

Sep 23 2015

PeterBowman added a comment to T87631: Interwiki search results should come after local ones in HTML.

@Nemo_bis: this patch has introduced a stray newline character below the results list (pl.wikisource).

Sep 23 2015, 9:07 PM · MW-1.26-release, WMF-deploy-2015-09-22_(1.26wmf24), good first task, MediaWiki-Search
PeterBowman added a comment to T73358: Line height is too low, text appears cramped in Special:Notifications.

This seems to have been fixed with 1.26wmf24.

Sep 23 2015, 7:34 PM · TestMe, Collaboration-Team-Triage, Design, Notifications

Aug 20 2015

PeterBowman added a comment to T109638: Page categorization logs expose user's IP.

@PeterBowman, are those IP addresses in the screenshots your own? Or do we need to remove those from this task before we make it public?

Aug 20 2015, 9:56 PM · Security, Security-Team, Vuln-Infoleak, Security-Core, MediaWiki-Recent-changes
PeterBowman added a comment to T109638: Page categorization logs expose user's IP.

@PeterBowman, can you link to the lua module that is being used for this?

Aug 20 2015, 8:53 PM · Security, Security-Team, Vuln-Infoleak, Security-Core, MediaWiki-Recent-changes

Aug 19 2015

PeterBowman created T109638: Page categorization logs expose user's IP.
Aug 19 2015, 9:49 PM · Security, Security-Team, Vuln-Infoleak, Security-Core, MediaWiki-Recent-changes

Jul 8 2015

PeterBowman created T105237: Enhanced recent changes stopped showing edit marks.
Jul 8 2015, 9:37 PM · MW-1.26-release, WMF-deploy-2015-07-14_(1.26wmf14), WMF-deploy-2015-07-07_(1.26wmf13), Patch-For-Review, Regression, MediaWiki-Recent-changes

May 25 2015

PeterBowman added a comment to T100248: Programmatically applied change tags don't show on Recent Changes.

The ts_rc_id column on the tag_summary table is empty for those revisions: http://quarry.wmflabs.org/query/3762.

May 25 2015, 1:52 AM · User-notice-archive, WMF-deploy-2015-05-13_(1.26wmf6), WMF-deploy-2015-05-20_(1.26wmf7), MW-1.26-release, WMF-deploy-2015-05-27_(1.26wmf8), Regression, MediaWiki-Change-tagging
PeterBowman added a comment to T100248: Programmatically applied change tags don't show on Recent Changes.

Another issue I have encountered at the same time:

  1. Navigate to the history page on which you have recently performed an API tagged edit (see #1 above, it seems to work on pre-23/05 edits), select that revision and click on Edit tags of selected revisions.
  2. Remove the tag and apply changes. Nothing was changed, actually.
May 25 2015, 1:23 AM · User-notice-archive, WMF-deploy-2015-05-13_(1.26wmf6), WMF-deploy-2015-05-20_(1.26wmf7), MW-1.26-release, WMF-deploy-2015-05-27_(1.26wmf8), Regression, MediaWiki-Change-tagging
PeterBowman created T100248: Programmatically applied change tags don't show on Recent Changes.
May 25 2015, 1:16 AM · User-notice-archive, WMF-deploy-2015-05-13_(1.26wmf6), WMF-deploy-2015-05-20_(1.26wmf7), MW-1.26-release, WMF-deploy-2015-05-27_(1.26wmf8), Regression, MediaWiki-Change-tagging

May 21 2015

PeterBowman awarded T30397: Allow collation to be specified per category a Like token.
May 21 2015, 5:32 PM · Patch-Needs-Improvement, All-and-every-Wiktionary, MediaWiki-Categories

May 20 2015

PeterBowman added a comment to T94194: Window on leave code in editor overlay should be reusable or dropped.

@Florian: the code on mediawiki.special.preferences.js#277 (204538) is not working as intended, there should be no parentheses:

May 20 2015, 12:07 PM · Mobile-Web-Sprint-48-Voyage-of-the-Damned, Web-Team-Backlog

Apr 29 2015

PeterBowman created T97501: Missing checkboxes for tag editing on log entries.
Apr 29 2015, 1:32 AM · MW-1.25-release, Patch-For-Review, WMF-deploy-2015-05-06_(1.26wmf5), MediaWiki-Change-tagging

Apr 28 2015

PeterBowman added a comment to T97135: Enable SandboxLink on eswiktionary.

Great, thanks!

Apr 28 2015, 1:33 AM · Spanish-Sites, Patch-For-Review, Wikimedia-Extension-setup

Apr 24 2015

PeterBowman created T97135: Enable SandboxLink on eswiktionary.
Apr 24 2015, 2:44 PM · Spanish-Sites, Patch-For-Review, Wikimedia-Extension-setup

Mar 9 2015

PeterBowman added a comment to T55130: Categories should be displayed in a responsive table and be mobile friendly..

I may have spotted another issue: expanding subcategories make other elements "jump" between columns, sometimes even the expanded entry itself. Test page, Firefox 36.
Before:

Before.png (597×1 px, 219 KB)

After:
After.png (678×1 px, 239 KB)

Mar 9 2015, 11:54 PM · Patch-For-Review, MediaWiki-Categories

Mar 3 2015

PeterBowman created T91433: Hovercards: showing blank space instead of image.
Mar 3 2015, 7:45 PM · Patch-For-Review, Page-Previews

Jan 26 2015

PeterBowman added a comment to T78834: LivePreview: duplicate 'templates used on this page' list.

Related: T55918

Jan 26 2015, 2:36 PM · JavaScript, MediaWiki-Page-editing

Jan 13 2015

PeterBowman created T86702: Parse wikitext in MediaWiki:Lastmodifiedat.
Jan 13 2015, 8:28 PM · Patch-For-Review, Regression, MediaWiki-Parser, MediaWiki-Internationalization

Jan 12 2015

RandomDSdevel awarded T78838: LivePreview: no changes reflected on preview/diff when using CodeEditor a Haypence token.
Jan 12 2015, 11:32 PM · JavaScript, MediaWiki-Page-editing, CodeEditor

Dec 18 2014

PeterBowman added subtasks for T41272: Bugs in "Live preview" feature (tracking): T78838: LivePreview: no changes reflected on preview/diff when using CodeEditor, T78834: LivePreview: duplicate 'templates used on this page' list.
Dec 18 2014, 9:22 PM · JavaScript, MediaWiki-Page-editing, Tracking-Neverending

Dec 17 2014

PeterBowman created T78838: LivePreview: no changes reflected on preview/diff when using CodeEditor.
Dec 17 2014, 11:03 PM · JavaScript, MediaWiki-Page-editing, CodeEditor
PeterBowman created T78834: LivePreview: duplicate 'templates used on this page' list.
Dec 17 2014, 10:21 PM · JavaScript, MediaWiki-Page-editing