We're not using this extension for anything but code review archives anymore, however it has received 18 maintenance commits in 2015 so far which means that it's not free to keep it up forever. Therefore, I propose to make a static dump of it and undeploy.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T106123 Extensions needing to be removed from Wikimedia wikis | |||
| Declined | None | T218079 CodeRevisionListView::getRevCount is creating slow queries on mediawiki.org | |||
| Resolved | Jdforrester-WMF | T116948 Undeploy CodeReview | |||
| Resolved | None | T205361 Make an HTML dump of the output of the CodeReview extension on MediaWiki.org | |||
| Resolved | Dzahn | T243056 Set up static-codereview.wikimedia.org to host static HTML dump of CodeReview | |||
| Resolved | ArielGlenn | T243055 Publish SQL dumps of CodeReview tables |
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions
Change 409290 abandoned by Chad:
Rewrite old Special:Code urls to Phabricator SVN clones
Reason:
Too soon for redirects.
Comment Actions
Hi. Unfortunately, this was an extension that I have used on my server. I came to reinstall it after a recent Ubuntu update caused my post-commit hooks to freeze up (and break Apache in the process), and saw the header on the extension page.
Is there any fork in development for this extension?
Comment Actions
At this point, I am re-deploying it on my newer MediaWiki instance, starting from scratch. I will see if the freezeups go away. I won't be able to test fully of course until I push my next commit.
Comment Actions
As a heads-up, I have determined the freeze is not due to the extension but the svn command itself freezing up.
I just posted a test commit on my new CodeReview instance and it completed without issue, though I did have quite a few freezes of the SVN command during the initial import.
Comment Actions
@BFeely: Hi and welcome! This task is about removing that extension from being available on WMF websites (but not about removing its code repository). Please file a separate task at https://phabricator.wikimedia.org/maniphest/task/edit/form/1/?projects=mediawiki-extensions-codereview about any problems with running that extension on your server - thanks a lot!
Comment Actions
@Krinkle please file a new task for the Code-Stewardship-Reviews instead of hijacking this one.
Comment Actions
I believe T222918: Put "shim" code for namespaces, logs, and log i18n into WikimediaMessages so we can undeploy extensions is not a blocker for this because CodeReview did not add any logs nor namespaces to mediawiki.org. The only thing it added were some API modules and the special page. The API modules will obviously break, and we're going to preserve the special page links via Apache rewrites.
Comment Actions
Change 593350 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop CodeReview, Part I: Stop loading it anywhere
Comment Actions
Change 593351 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop CodeReview, Part II: Stop configuring it anywhere
Comment Actions
Change 593352 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop CodeReview, Part III: Drop from i18n build step
Comment Actions
Change 593353 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/tools/release@master] Stop branching the CodeReview extension for Wikimedia production
Comment Actions
Dropping the table is blocked on this task (as otherwise it'll cause a fatal when anyone tries to load https://www.mediawiki.org/wiki/Special:Code/MediaWiki/1 etc.); this task is blocked on that and the Apache redirects so that the pages keep working, if we're going to do that.
Comment Actions
I think we can move ahead with this now - there are still some tweaks to make to the dump, but we can do that by modifying the existing dump instead of rescraping it from scratch.
Comment Actions
Change 593350 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop CodeReview, Part I: Stop loading it anywhere
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-05-23T20:34:12Z] <jforrester@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:593350|Drop CodeReview, Part I: Stop loading it anywhere (T116948)]] (duration: 00m 51s)
Comment Actions
Change 593351 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop CodeReview, Part II: Stop configuring it anywhere
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-05-23T20:37:24Z] <jforrester@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:593351|Drop CodeReview, Part II: Stop configuring it anywhere (T116948)]] (duration: 00m 51s)
Comment Actions
Change 593352 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop CodeReview, Part III: Drop from i18n build step
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-05-23T20:40:12Z] <jforrester@deploy1002> Synchronized wmf-config/extension-list: Config: [[gerrit:593352|Drop CodeReview, Part III: Drop from i18n build step (T116948)]] (duration: 00m 51s)
Comment Actions
Change 593353 merged by jenkins-bot:
[mediawiki/tools/release@master] Stop branching the CodeReview extension for Wikimedia production
Comment Actions
Change 797533 had a related patch set uploaded (by Dzahn; author: Dzahn):
[operations/puppet@production] httpbb: remove tests for undeployed CodeReview extension
Comment Actions
Change 797533 merged by Dzahn:
[operations/puppet@production] httpbb: remove tests for undeployed CodeReview extension
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2022-05-23T23:20:46Z] <mutante> cumin1001 - systemtl start httpbb_hourly_appserver after deploying gerrit:797533 leads to '+icinga-wm> RECOVERY - Check systemd state on cumin1001 is OK: OK" T116948