Page MenuHomePhabricator
Create Task
Maniphest T156350

Add language-specific CSS modules for Parsoid's Cite output
Closed, ResolvedPublic
Actions

Description

Parsoid is relying on CSS to style Cite output and as part of T86782: Use CSS to style Parsoid's Cite extension output, we created the default ext.cite.style.css and the ext.cite.style.fa.css as the override for language fa. These are part of the Cite extension. We need to create additional language-specific CSS modules for all languages that might possibly customize numbering of references.

Look at https://www.w3.org/TR/css-counter-styles-3/ and the predefined style counters that are available

Details

SubjectRepoBranchLines +/-
Move Parsoid-specific CSS into a subdirectorymediawiki/extensions/Citemaster+5 -8
[Read Views Migration Tooling]: Scripts to generate cite CSSmediawiki/services/parsoidmaster+2 K -0
Parsoid CSS: mw-ref-linkback counter inits to -1, not 0mediawiki/extensions/Citemaster+1 -128
Bump wikimedia/parsoid to 0.17.0-a13mediawiki/vendormaster+3 K -1 K
Parsoid CSS counters: Use child selectors instead of descendent selectorsmediawiki/extensions/Citemaster+194 -194
[Read Views Migration Tooling]: Generate Cite language CSS filesmediawiki/services/parsoidmaster+113 -0
Parsoid CSS: Add (script-generated) language-specific countersmediawiki/extensions/Citemaster+914 -143
Parsoid CSS: Add language specific overrides for es, hu, it, svmediawiki/extensions/Citemaster+90 -0
Add language specific CSS overrides for a few languagesmediawiki/extensions/Citemaster+62 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• ssastry created this task.Jan 26 2017, 9:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2017, 9:23 AM
• ssastry triaged this task as Medium priority.Jan 26 2017, 9:23 AM
• ssastry mentioned this in T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output.Jan 26 2017, 9:29 AM
• ssastry added a subtask: T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output.
Izno moved this task from Unsorted backlog to External on the Cite board.Jan 26 2017, 12:10 PM
• Elitre subscribed.Feb 7 2017, 6:26 PM
• ssastry added a comment.Mar 21 2017, 4:57 PM

I suppose the strategy is to create language overrides for all languages for which customized predefined style counters are available. And, if a wiki doesn't use the language customizations, then, have the on-wiki CSS override the customization as part of T156351.

• ssastry mentioned this in T45235: Cite: Parsoid's port does not support all of the PHP extension's config options and i18n messages.Mar 31 2017, 2:37 PM
• ssastry moved this task from Needs Triage to Read Views on the Parsoid board.Jan 11 2018, 9:20 PM
Reedy edited projects, added Parsoid-Read-Views-Deprecated-Project; removed Parsoid.Sep 17 2018, 7:25 PM
• ssastry moved this task from Uncategorized to Extensions on the Parsoid-Read-Views-Deprecated-Project board.Sep 20 2018, 3:41 PM
• ssastry changed the task status from Open to Stalled.Sep 6 2019, 5:12 PM
• ssastry changed the status of subtask T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output from Open to Stalled.
• Elitre unsubscribed.Sep 9 2019, 8:59 AM
Izno mentioned this in T239911: [Spike] Decide how to guarantee Cite footnote body numbering.Dec 5 2019, 3:15 PM
Aklapper edited projects, added Parsoid; removed Parsoid-Read-Views-Deprecated-Project.Feb 29 2020, 5:14 PM
Krinkle unsubscribed.Feb 29 2020, 6:15 PM
• ssastry moved this task from Read Views to Missing Functionality on the Parsoid board.Mar 5 2020, 10:58 PM
Izno mentioned this in T24265: Allow references to be listed with letters.Mar 3 2021, 4:51 PM
• ssastry added a project: Parsoid-Read-Views (Phase 1 - DiscussionTools support).Sep 29 2021, 10:30 PM
• ssastry moved this task from Backlog to Talk Page Read Views on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.Jan 26 2022, 8:00 PM
• ssastry mentioned this in T308094: Document Parsoid replacement for MediaWiki:cite_link_label-* customization.May 11 2022, 1:52 PM
• JMcLeod_WMF moved this task from Talk Page Read Views to Backlog on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.May 16 2022, 3:46 PM
Jdforrester-WMF mentioned this in T321217: Get rid of Cite formatting i18n messages that are not actually localized.Oct 19 2022, 5:46 PM
• ssastry changed the task status from Stalled to In Progress.Oct 20 2022, 11:31 PM
• ssastry claimed this task.
gerritbot added a comment.Oct 20 2022, 11:31 PM

Change 845072 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/Cite@master] WIP: Add language specific CSS overrides for a few languages

https://gerrit.wikimedia.org/r/845072

gerritbot added a project: Patch-For-Review.Oct 20 2022, 11:31 PM
• ssastry moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.Oct 20 2022, 11:40 PM
gerritbot added a comment.Oct 22 2022, 3:27 AM

Change 845072 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add language specific CSS overrides for a few languages

https://gerrit.wikimedia.org/r/845072

Maintenance_bot removed a project: Patch-For-Review.Oct 22 2022, 3:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 22 2022, 4:00 AM
• Elitre subscribed.Oct 25 2022, 4:04 PM
gerritbot added a comment.Oct 26 2022, 10:40 PM

Change 849700 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/Cite@master] Parsoid CSS: Add WP-biased language specific overrides for es, it, sv

https://gerrit.wikimedia.org/r/849700

gerritbot added a project: Patch-For-Review.Oct 26 2022, 10:40 PM
gerritbot added a comment.Nov 1 2022, 10:16 PM

Change 849738 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] [Read Views Migration Tooling]: Programmatically generate cite CSS

https://gerrit.wikimedia.org/r/849738

gerritbot added a comment.Nov 1 2022, 10:17 PM

Change 849700 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Parsoid CSS: Add language specific overrides for es, hu, it, sv

https://gerrit.wikimedia.org/r/849700

• ssastry changed the status of subtask T156351: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output from Stalled to In Progress.Nov 1 2022, 10:33 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Nov 1 2022, 11:00 PM
gerritbot added a comment.Nov 4 2022, 3:35 AM

Change 853079 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/Cite@master] Parsoid CSS: Add language-specific counters

https://gerrit.wikimedia.org/r/853079

gerritbot added a comment.Nov 4 2022, 3:16 PM

Change 853308 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] [Read Views Migration Tooling]: Generate Cite languge CSS files

https://gerrit.wikimedia.org/r/853308

• ssastry added a project: Content-Transform-Team-WIP.Nov 7 2022, 4:16 PM
• ssastry moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Nov 7 2022, 4:18 PM
• ssastry moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.
• ssastry reassigned this task from • ssastry to cscott.Nov 28 2022, 4:42 PM

Assigning to Scott for review.

gerritbot added a comment.Dec 12 2022, 4:34 PM

Change 853079 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Parsoid CSS: Add (script-generated) language-specific counters

https://gerrit.wikimedia.org/r/853079

gerritbot added a comment.Dec 16 2022, 5:06 PM

Change 853308 abandoned by Subramanya Sastry:

[mediawiki/services/parsoid@master] [Read Views Migration Tooling]: Generate Cite language CSS files

Reason:

squashed into parent patch.

https://gerrit.wikimedia.org/r/853308

gerritbot added a comment.Dec 19 2022, 9:20 PM

Change 868750 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/Cite@master] Ensure Parsoid's linkback ref CSS counters are properly incremented

https://gerrit.wikimedia.org/r/868750

gerritbot added a comment.Jan 8 2023, 2:50 AM

Change 876334 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/Cite@master] Parsoid CSS counters: Use child selectors instead of descendent selectors

https://gerrit.wikimedia.org/r/876334

gerritbot added a comment.Jan 9 2023, 1:45 AM

Change 876334 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Parsoid CSS counters: Use child selectors instead of descendent selectors

https://gerrit.wikimedia.org/r/876334

• ssastry moved this task from In Progress to Code Review on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.Jan 19 2023, 7:02 PM
• JMcLeod_WMF moved this task from Code Review to To Verify on the Content-Transform-Team-WIP board.Jan 23 2023, 4:08 PM
gerritbot added a comment.Jan 24 2023, 5:04 PM

Change 849738 merged by jenkins-bot:

[mediawiki/services/parsoid@master] [Read Views Migration Tooling]: Scripts to generate cite CSS

https://gerrit.wikimedia.org/r/849738

• ssastry claimed this task.Jan 24 2023, 10:29 PM
• ssastry added a subscriber: cscott.

Claiming back for verification.

• ssastry closed this task as Resolved.Jan 24 2023, 11:33 PM

I looked at knwiki and hewiki pages and opened them in VisualEditor and verified that the numbering localization matched read views (except where some wiki-specific CSS rules are needed which will be addressed by T156351).

gerritbot added a comment.Jan 30 2023, 8:41 PM

Change 885031 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.17.0-a13

https://gerrit.wikimedia.org/r/885031

gerritbot added a comment.Jan 30 2023, 9:11 PM

Change 885031 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.17.0-a13

https://gerrit.wikimedia.org/r/885031

gerritbot added a comment.Feb 8 2023, 12:30 AM

Change 887435 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/Cite@master] Parsoid CSS: mw-ref-linkback counter inits to -1, not 0

https://gerrit.wikimedia.org/r/887435

matmarex subscribed.Feb 8 2023, 4:03 PM
gerritbot added a comment.Feb 8 2023, 4:19 PM

Change 887435 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Parsoid CSS: mw-ref-linkback counter inits to -1, not 0

https://gerrit.wikimedia.org/r/887435

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Feb 8 2023, 5:00 PM
gerritbot added a comment.Mar 11 2024, 10:37 AM

Change 1010163 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move Parsoid-specific CSS into a subdirectory

https://gerrit.wikimedia.org/r/1010163

gerritbot added a comment.Mar 11 2024, 4:21 PM

Change 1010163 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move Parsoid-specific CSS into a subdirectory

https://gerrit.wikimedia.org/r/1010163

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 11 2024, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL