Maniphest T205101

McrUndoAction preview doesn't work
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anomie
	Sep 21 2018, 2:47 PM

Description

Apparently DifferenceEngine::renderNewRevision() never really worked right, it only functions when diffing saved revisions.

When the code was written it generated a preview of the latest revision of the page, rather than showing the result of the undo, and this wasn't noticed during coding or review. After 4835a75e it doesn't generate any preview at all.

Details

	Subject	Repo	Branch	Lines +/-
	McrUndoAction: Fix preview	mediawiki/core	master	+56 -3

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T174032 Make relevant API modules aware of MCR
Resolved		daniel	T174025 Implement MCR revision retrieval legacy version
Open		None	T198099 Improve MCR handling of RevisionAccessException family
Resolved		Anomie	T200568 Make API query modules aware of MCR
Resolved		Anomie	T200569 Make ApiComparePages API module aware of MCR
Resolved		Tgr	T194731 Show diffs for all slots [MCR]
Resolved		Tgr	T201842 Use ContentHandler to obtain DifferenceEngine in MobileFrontend
Open		None	T200570 Make ApiEditPage and ApiStashEdit API modules aware of MCR
Open		None	T174033 Refactor EditPage to allow multiple slots to be edited atomically [MCR]
Open		None	T200572 Make ApiParse API module aware of MCR
Resolved		daniel	T174035 Allow the view action to show multiple slots [MCR]
Resolved		daniel	T194048 Introduce RevisionRenderer (baseline)
Invalid		Tgr	T194049 Introduce SlotRenderingProvider
Resolved		Anomie	T194263 Deprecate/Remove ContentHandler::makeParserOptions()
Resolved		Anomie	T190712 Wikibase\Repo\Content\EntityHandler should not override makeParserOptions()
Resolved	PRODUCTION ERROR	Func	T206253 Some ApiParse requests fail due to fatal MWException: "not supported for content model"
Open	Feature	Simontaurus	T338099 ApiQuerySiteinfo should provide known and defined slot roles
Open		None	T189808 Make undo work with multiple slots.
Resolved		daniel	T194412 Make undo fail gracefully for non-main slots.
Duplicate		None	T194413 Make action=undo work properly with multiple slots (phase 2)
Resolved		Anomie	T205101 McrUndoAction preview doesn't work