Page MenuHomePhabricator

McrUndoAction preview doesn't work
Closed, ResolvedPublic

Description

Apparently DifferenceEngine::renderNewRevision() never really worked right, it only functions when diffing saved revisions.

When the code was written it generated a preview of the latest revision of the page, rather than showing the result of the undo, and this wasn't noticed during coding or review. After 4835a75e it doesn't generate any preview at all.

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenBUG REPORTNone
OpenNone
StalledNone
OpenFeatureNone
DuplicateNone
ResolvedNone
OpenNone
OpenNone
OpenFeatureNone
OpenNone
ResolvedNone
ResolvedNone
OpenFeatureNone
StalledNone
OpenNone
OpenNone
OpenNone
Resolveddaniel
OpenNone
ResolvedAnomie
ResolvedAnomie
Resolved Tgr
Resolved Tgr
OpenNone
OpenNone
OpenNone
Resolveddaniel
Resolveddaniel
Invalid Tgr
ResolvedAnomie
ResolvedAnomie
ResolvedPRODUCTION ERRORFunc
OpenNone
Resolveddaniel
DuplicateNone
ResolvedAnomie

Event Timeline

Change 461972 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] McrUndoAction: Fix preview

https://gerrit.wikimedia.org/r/461972

Change 461972 merged by jenkins-bot:
[mediawiki/core@master] McrUndoAction: Fix preview

https://gerrit.wikimedia.org/r/461972