Page MenuHomePhabricator

McrUndoAction preview doesn't work
Closed, ResolvedPublic

Description

Apparently DifferenceEngine::renderNewRevision() never really worked right, it only functions when diffing saved revisions.

When the code was written it generated a preview of the latest revision of the page, rather than showing the result of the undo, and this wasn't noticed during coding or review. After 4835a75e it doesn't generate any preview at all.

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
StalledNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedKrinkle
OpenNone
OpenNone
OpenNone
StalledNone
OpenNone
OpenNone
OpenNone
Resolveddaniel
Opendaniel
ResolvedAnomie
ResolvedAnomie
ResolvedTgr
ResolvedTgr
OpenNone
OpenNone
OpenNone
Resolveddaniel
Resolveddaniel
InvalidTgr
ResolvedAnomie
ResolvedAnomie
OpenPRODUCTION ERRORNone
OpenNone
Resolveddaniel
DuplicateNone
ResolvedAnomie

Event Timeline

Anomie created this task.Sep 21 2018, 2:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2018, 2:47 PM

Change 461972 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] McrUndoAction: Fix preview

https://gerrit.wikimedia.org/r/461972

Change 461972 merged by jenkins-bot:
[mediawiki/core@master] McrUndoAction: Fix preview

https://gerrit.wikimedia.org/r/461972

Anomie closed this task as Resolved.Sep 24 2018, 5:46 PM
Aklapper removed a subscriber: Anomie.Fri, Oct 16, 5:38 PM