Page MenuHomePhabricator

"FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos
Closed, ResolvedPublic

Description

PHPUnit failure:

09:38:54 1) FlaggablePageTest::testPageDataFromTitle
09:38:54 MWException: Title 'somePage' cannot exist as a page
09:38:54 
09:38:54 /workspace/src/includes/page/WikiPage.php:146
09:38:54 /workspace/src/extensions/FlaggedRevs/tests/phpunit/FlaggablePageTest.php:23
09:38:54 /workspace/src/maintenance/doMaintenance.php:106

Selenium failure (when trying to view Special:UserLogin):
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-selenium-docker/25393/artifact/log/Page-should-be-deletable.png

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
StalledNone
DuplicateNone
OpenNone
ResolvedNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedppelberg
ResolvedKrinkle
OpenNone
ResolvedNone
ResolvedNone
StalledNone
OpenNone
OpenNone
Opendaniel
OpenNone
OpenNone
OpenNone
OpenNone
Opendaniel
Opendaniel
Resolveddaniel
ResolvedJdforrester-WMF

Event Timeline

Jdforrester-WMF triaged this task as Unbreak Now! priority.Jan 15 2021, 5:47 PM
Jdforrester-WMF created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2021, 5:47 PM

Change 656461 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/FlaggedRevs@master] FlaggablePageTest::testPageDataFromTitle: Use an initial capital so MW doesn't throw

https://gerrit.wikimedia.org/r/656461

Jdforrester-WMF renamed this task from "FlaggablePageTest::testPageDataFromTitle" erroring on all MediaWiki patches to "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.Jan 15 2021, 6:04 PM

Change 656468 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Revert "Make WikiPage a ProperPageIdentity"

https://gerrit.wikimedia.org/r/656468

Change 656507 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Revert "Define equality for PageIdentity and LinkTarget"

https://gerrit.wikimedia.org/r/656507

Change 656461 abandoned by Jforrester:
[mediawiki/extensions/FlaggedRevs@master] FlaggablePageTest::testPageDataFromTitle: Use an initial capital so MW doesn't throw

Reason:

https://gerrit.wikimedia.org/r/656461

matmarex updated the task description. (Show Details)Jan 15 2021, 8:47 PM

Change 656507 merged by jenkins-bot:
[mediawiki/core@master] Revert "Define equality for PageIdentity and LinkTarget"

https://gerrit.wikimedia.org/r/656507

Change 656468 merged by jenkins-bot:
[mediawiki/core@master] Revert "Make WikiPage a ProperPageIdentity"

https://gerrit.wikimedia.org/r/656468

Jdforrester-WMF closed this task as Resolved.Jan 15 2021, 9:14 PM

OK, things look fixed.

Can we add flagged revs to MW gate? This is maybe the 5th time over a year I remember FlaggedRevs being broken by core changes, so it seems like a good addition to MW gate

Can we add flagged revs to MW gate? This is maybe the 5th time over a year I remember FlaggedRevs being broken by core changes, so it seems like a good addition to MW gate

Yes, probably (overall tracked at T249674: Have all Wikimedia production extensions and skins in the CI gate), but I vaguely remember there being issues about how FR interferes with other extensions' tests.

Change 656944 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944

Change 656906 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Re-apply "Make WikiPage a ProperPageIdentity"

https://gerrit.wikimedia.org/r/656906

Change 656948 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Re-apply "Define equality for PageIdentity and LinkTarget"

https://gerrit.wikimedia.org/r/656948

Change 656944 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944