Page MenuHomePhabricator
Create Task
Maniphest T272170

"FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos
Closed, ResolvedPublic
Actions

Description

PHPUnit failure:

09:38:54 1) FlaggablePageTest::testPageDataFromTitle
09:38:54 MWException: Title 'somePage' cannot exist as a page
09:38:54 
09:38:54 /workspace/src/includes/page/WikiPage.php:146
09:38:54 /workspace/src/extensions/FlaggedRevs/tests/phpunit/FlaggablePageTest.php:23
09:38:54 /workspace/src/maintenance/doMaintenance.php:106

Selenium failure (when trying to view Special:UserLogin):
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-selenium-docker/25393/artifact/log/Page-should-be-deletable.png

image.png (888×1 px, 209 KB)

Details

SubjectRepoBranchLines +/-
Use FlaggableWikiPage only for real pagesmediawiki/extensions/FlaggedRevsmaster+6 -5
Revert "Make WikiPage a ProperPageIdentity"mediawiki/coremaster+29 -140
Revert "Define equality for PageIdentity and LinkTarget"mediawiki/coremaster+27 -464
FlaggablePageTest::testPageDataFromTitle: Use an initial capital so MW doesn't throwmediawiki/extensions/FlaggedRevsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenBUG REPORTNoneT12863 Links on commons upload summaries do not link to commons
 OpenNoneT5498 Image history is confusing
 StalledNoneT96384 Integrate file revisions with description page history
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 OpenNoneT122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
 OpenNoneT135221 Make TimedText content an integral part of the File page
 OpenFeatureNoneT2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
 OpenNoneT132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenFeatureNoneT14963 allow per-page exceptions to spam blacklist
 OpenNoneT203157 Make the spam whitelist its own slot
 OpenFeatureNoneT56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
 StalledNoneT174043 Deploy Multi-Content Revisions
 OpenNoneT174022 Implement multi-content revisions
 OpendanielT196087 Refactored implementation of MCR page update interface
 OpenpmiazgaT302623 FY2022-2023: Improve Backend Pageview Timing
 ResolvedNoneT206498 MediaWiki needlessly queries page data twice on page views
 InvalidNoneT273514 MW expedition work [high effort]
 OpenNoneT273542 Migrate ZObjectStore from WikiPage to PageStore when it exists
 ResolvedNoneT195069 Factor PageStore and PageRecord out of WikiPage
 ResolveddanielT272421 Make WikiPage a PageRecord
 ResolveddanielT272424 Make WikiPage a ProperPageIdentity
 ResolveddanielT272518 Watch for extensions broken by WikiPage now deprecating construction on bad titles
 ResolvedJdforrester-WMFT272170 "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos

Event Timeline

Jdforrester-WMF triaged this task as Unbreak Now! priority.Jan 15 2021, 5:47 PM
Jdforrester-WMF created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2021, 5:47 PM
Esanders added subscribers: daniel, Esanders.Jan 15 2021, 5:50 PM

Could be https://gerrit.wikimedia.org/r/c/mediawiki/core/+/630182 ?

Jdforrester-WMF added a comment.Jan 15 2021, 5:51 PM
In T272170#6751963, @Esanders wrote:

Could be https://gerrit.wikimedia.org/r/c/mediawiki/core/+/630182 ?

Possibly; FR is not in the gate for core.

Jdforrester-WMF added a comment.Jan 15 2021, 5:55 PM

Looks like this error is new in rMW8f46ef5ff4cf: Make WikiPage a ProperPageIdentity.

gerritbot added a comment.Jan 15 2021, 5:57 PM

Change 656461 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/FlaggedRevs@master] FlaggablePageTest::testPageDataFromTitle: Use an initial capital so MW doesn't throw

https://gerrit.wikimedia.org/r/656461

gerritbot added a project: Patch-For-Review.Jan 15 2021, 5:57 PM
Jdforrester-WMF renamed this task from "FlaggablePageTest::testPageDataFromTitle" erroring on all MediaWiki patches to "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.Jan 15 2021, 6:04 PM
RhinosF1 subscribed.Jan 15 2021, 6:55 PM
matmarex subscribed.Jan 15 2021, 8:10 PM
gerritbot added a comment.Jan 15 2021, 8:22 PM

Change 656468 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Revert "Make WikiPage a ProperPageIdentity"

https://gerrit.wikimedia.org/r/656468

gerritbot added a comment.Jan 15 2021, 8:30 PM

Change 656507 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Revert "Define equality for PageIdentity and LinkTarget"

https://gerrit.wikimedia.org/r/656507

matmarex mentioned this in T208776: RFC: Introduce PageIdentity to be used instead of WikiPage.Jan 15 2021, 8:43 PM
gerritbot added a comment.Jan 15 2021, 8:44 PM

Change 656461 abandoned by Jforrester:
[mediawiki/extensions/FlaggedRevs@master] FlaggablePageTest::testPageDataFromTitle: Use an initial capital so MW doesn't throw

Reason:

https://gerrit.wikimedia.org/r/656461

matmarex updated the task description. (Show Details)Jan 15 2021, 8:47 PM
Jdforrester-WMF claimed this task.Jan 15 2021, 8:47 PM
gerritbot added a comment.Jan 15 2021, 9:06 PM

Change 656507 merged by jenkins-bot:
[mediawiki/core@master] Revert "Define equality for PageIdentity and LinkTarget"

https://gerrit.wikimedia.org/r/656507

gerritbot added a comment.Jan 15 2021, 9:10 PM

Change 656468 merged by jenkins-bot:
[mediawiki/core@master] Revert "Make WikiPage a ProperPageIdentity"

https://gerrit.wikimedia.org/r/656468

Jdforrester-WMF closed this task as Resolved.Jan 15 2021, 9:14 PM

OK, things look fixed.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 15 2021, 10:00 PM
• Pchelolo subscribed.Jan 16 2021, 5:55 PM

Can we add flagged revs to MW gate? This is maybe the 5th time over a year I remember FlaggedRevs being broken by core changes, so it seems like a good addition to MW gate

Jdforrester-WMF added a comment.Jan 16 2021, 6:32 PM
In T272170#6753458, @Pchelolo wrote:

Can we add flagged revs to MW gate? This is maybe the 5th time over a year I remember FlaggedRevs being broken by core changes, so it seems like a good addition to MW gate

Yes, probably (overall tracked at T249674: Have all Wikimedia production extensions and skins in the CI gate), but I vaguely remember there being issues about how FR interferes with other extensions' tests.

gerritbot added a comment.Jan 18 2021, 4:07 PM

Change 656944 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944

gerritbot added a comment.Jan 18 2021, 4:09 PM

Change 656906 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Re-apply "Make WikiPage a ProperPageIdentity"

https://gerrit.wikimedia.org/r/656906

gerritbot added a comment.Jan 18 2021, 4:13 PM

Change 656948 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Re-apply "Define equality for PageIdentity and LinkTarget"

https://gerrit.wikimedia.org/r/656948

gerritbot added a comment.Jan 19 2021, 11:25 PM

Change 656944 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Use FlaggableWikiPage only for real pages

https://gerrit.wikimedia.org/r/656944

Jdforrester-WMF added a parent task: T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles.Jan 20 2021, 5:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL