Page MenuHomePhabricator

Category list and siteSub text unusually large font size (Vector regression), absolutely positioned elements relative
Closed, ResolvedPublic

Description

Seen on 1.37.0-wmf.6, currently at group0:

https://www.mediawiki.org/wiki/Template:MediaWiki_PHP_7.4.0_to_7.4.2?safemode=on

Still fine on en.wikipedia.org and test2.wikipedia.org (1.37.0-wmf.5),
e.g. https://test2.wikipedia.org/wiki/Main_Page

Event Timeline

This regression is now live on Wikipedia.

Iniquity renamed this task from Category list text unusually large font size (Vector regression) to Category list and siteSub text unusually large font size (Vector regression).Thu, May 20, 8:55 PM

Hi @Iniquity, Many thanks for merging and tbh thank you for restoring my faith in Phab!. Good to know I'm not going mad (although trying to convince people I actually had a problem was beginning to drive me clinically insane!)

FWIW, I am seeing large category text in "Legacy Vector", in case the above description is ambiguous.

Change 693237 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Introduce the vector-body class

https://gerrit.wikimedia.org/r/693237

Jdlrobson renamed this task from Category list and siteSub text unusually large font size (Vector regression) to Category list and siteSub text unusually large font size (Vector regression), absolutely positioned elements relative.Fri, May 21, 4:15 AM
Jdlrobson added subscribers: Tacsipacsi, Aftabuzzaman, Izno.

Hotfix for the coordinates issue reported in T283286 (to be put in MediaWiki:Vector.css):

#bodyContent {
	position: relative;
	z-index: 0;
}
.mw-body-content {
	position: initial;
}

Please note that this is not intended to be future-proof and should be removed as soon as the Gerrit patch is deployed.

I'm assuming the attached screenshot from https://en.wikipedia.org/wiki/Wikipedia:Deletion_review/Log/2021_May_10#Category:CS1_maint:_discouraged_parameter is another example of the same issue.

BTW: this is unaffected by the "Use Legacy Vector" option in Preferences/Appearance.

When will this issue be fixed? It's very scary to look at the wiki :)

Please fix this problem. Thank you in advance

#mw-normal-catlinks {
	font-size: 85%;
}

this reduces the categories font I have.

This patch looks like it has been ready to deploy for two days. What is the holdup?

We noticed also the large category size (16px) on the French Wikisource, and another (more important) problem seems related, hence I report it here: the transcluded text (example) is now 576px large and not 504px any more (it still is 504px in other skins). The reason is apparently that the 36em width is set at the #text-container div, where the font size is 16px, then this font size is reduced to 14px at a lower level (mw-body-content class, which is located on the #mw-context div).

In other modes (e.g. Previsualization), the mw-body-content `class is set at a higher level, so that the 36em width is computed when the font size is already 14px (hence the width is 504px and not 576px).

I hope that this problem will be fixed by the patch mentioned here.

EDIT: this problem has been fixed by the patch. Thank you!

ovasileva added a subscriber: ovasileva.

Change 693237 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Introduce the vector-body class

https://gerrit.wikimedia.org/r/693237

Change 693653 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.37.0-wmf.6] Introduce the vector-body class

https://gerrit.wikimedia.org/r/693653

Change 693653 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.37.0-wmf.6] Introduce the vector-body class

https://gerrit.wikimedia.org/r/693653

Mentioned in SAL (#wikimedia-operations) [2021-05-24T18:29:35Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.6/skins/Vector/: 1742532687b: Introduce the vector-body class (T283206) (duration: 00m 57s)

Jdforrester-WMF assigned this task to nray.

This patch looks like it has been ready to deploy for two days. What is the holdup?

There are no deploys on Friday, Saturdays, and Sundays.

If we had more group 1 wikis in the Wednesday deployment (especially larger ones in terms of page views) it would help prioritize these sorts of problems earlier before and get them more likely to be fixed before the weekend begins. If your project is interested, please let me know here.

This patch looks like it has been ready to deploy for two days. What is the holdup?

There are no deploys on Friday, Saturdays, and Sundays.

If we had more group 1 wikis in the Wednesday deployment (especially larger ones in terms of page views) it would help prioritize these sorts of problems earlier before and get them more likely to be fixed before the weekend begins. If your project is interested, please let me know here.

Thanks for the explanation. When I worked in IT, we never deployed any changes on days prior to days when changes could not be made, i.e. we never deployed on Friday because we didn't want to come in on the weekend. If the normal deployment schedule was Mon/Tues/Wed, then rollbacks and urgent patches like this one could be addressed on Thu/Fri.