Page MenuHomePhabricator

Update LoginNotify to read data from cu_private_event and cu_log_event if $wgLoginNotifyUseCheckUser is true
Open, Needs TriagePublic

Description

In T324907: Create separate tables for log events in CheckUser, the CheckUser extension has been updated so that checkuser data is stored in three tables (cu_changes, cu_log_event, and cu_private_event). This is so that the action text can be stored as log parameters and the log ID be stored with log events.

The MediaWiki-extensions-LoginNotify extension reads data from the cu_changes table to determine whether an given IP range has been used by the user in the last 90 days when $wgLoginNotifyUseCheckUser = true;

Eventually log events will no longer be written to cu_changes which will mean that the current code used by MediaWiki-extensions-LoginNotify will no longer find all IP addresses that have been used when not using the table added in T346989.

This means that LoginNotify::checkUserOneWiki will need to have two other queries that read data from cu_log_event and cu_private_event. Adding these queries can be done now, as for this use case there would be no problems caused by the tables having duplicate entries due to writing both new and old. Based on the direction given in T345052: LoginNotify seen subnets table, it seems that it will be August 2025 before the integration with CheckUser is removed so the code will need to be updated. Alternatively the August 2025 date could be brought forward to now and the integration with CheckUser be removed.

Related Objects

StatusSubtypeAssignedTask
ResolvedSecurityZabe
ResolvedSecurityDreamy_Jazz
ResolvedSecurityDreamy_Jazz
ResolvedSecurityDreamy_Jazz
OpenBUG REPORTNone
ResolvedBUG REPORTDreamy_Jazz
OpenBUG REPORTDreamy_Jazz
ResolvedDreamy_Jazz
OpenNone
OpenNone
OpenNone
OpenFeatureDreamy_Jazz
DuplicateNone
OpenFeatureNone
OpenFeatureNone
OpenFeatureNone
ResolvedFeatureDreamy_Jazz
ResolvedFeatureDreamy_Jazz
ResolvedFeatureDreamy_Jazz
OpenFeatureNone
OpenFeatureNone
ResolvedBUG REPORTDreamy_Jazz
OpenFeatureNone
OpenFeatureNone
ResolvedGlaisher
OpenNone
ResolvedFeatureDreamy_Jazz
ResolvedGlaisher
ResolvedNiharika
ResolvedNone
ResolvedFeatureDreamy_Jazz
DeclinedNone
ResolvedFeatureDreamy_Jazz
ResolvedFeatureDreamy_Jazz
DuplicateNone
OpenNone
DuplicateNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
OpenFeatureNone
ResolvedDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
ResolvedBUG REPORTDreamy_Jazz
OpenNone
OpenFeatureNone
DeclinedFeatureNone
OpenFeatureNone
ResolvedDreamy_Jazz
Resolvedkostajh
OpenNone
OpenNone
Resolved tstarling
OpenNone
ResolvedTchanders
OpenBUG REPORTNone
OpenFeatureDreamy_Jazz
OpenNone
OpenDreamy_Jazz